Emacs 25.2 RC1 next week

Emacs 25.2 RC1 next week

[Eli Zaretskii]

I think we are getting ready to have the first release candidate of
Emacs 25.2 next week.  If someone thinks there are bugs that have to
be fixed before that, please add them to the list of blockers in
bug#21966.

Thanks.

Re: Emacs 25.2 RC1 next week

[Nicolas Petton]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> I think we are getting ready to have the first release candidate of
> Emacs 25.2 next week.

I expected a second pretest, but I'm fine with a first RC as well.

Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]

Re: Emacs 25.2 RC1 next week

[Leo Liu]

On 2016-12-17 22:10 +0200, Eli Zaretskii wrote:
> I think we are getting ready to have the first release candidate of
> Emacs 25.2 next week.  If someone thinks there are bugs that have to
> be fixed before that, please add them to the list of blockers in
> bug#21966.

Could someone take a look at this bug https://debbugs.gnu.org/23002?
Reported before 25.1 release and still bothers me everyday. It causes a
few seconds delay randomly on M-x.

Thanks,
Leo

Re: Emacs 25.2 RC1 next week

[Eli Zaretskii]

> From: Nicolas Petton <nicolas@petton.fr>
> Date: Sat, 17 Dec 2016 22:10:43 +0100
> 
> > I think we are getting ready to have the first release candidate of
> > Emacs 25.2 next week.
> 
> I expected a second pretest, but I'm fine with a first RC as well.

Let's see if we can expedite things this time.  I'm encouraged by the
fact that the first pretest didn't bring any bug reports (AFAIR).

Thanks.

Re: Emacs 25.2 RC1 next week

[Eli Zaretskii]

> From: Leo Liu <sdl.web@gmail.com>
> Date: Sun, 18 Dec 2016 10:37:27 +0800
> 
> On 2016-12-17 22:10 +0200, Eli Zaretskii wrote:
> > I think we are getting ready to have the first release candidate of
> > Emacs 25.2 next week.  If someone thinks there are bugs that have to
> > be fixed before that, please add them to the list of blockers in
> > bug#21966.
> 
> Could someone take a look at this bug https://debbugs.gnu.org/23002?
> Reported before 25.1 release and still bothers me everyday. It causes a
> few seconds delay randomly on M-x.

My problem with the patch proposed there is that it touches a very
sensitive area, and does that for all the supported systems.

Stefan, any comments on that?

Re: Emacs 25.2 RC1 next week

[Stefan Monnier]

>> Could someone take a look at this bug https://debbugs.gnu.org/23002?
>> Reported before 25.1 release and still bothers me everyday. It causes a
>> few seconds delay randomly on M-x.
> My problem with the patch proposed there is that it touches a very
> sensitive area, and does that for all the supported systems.
> Stefan, any comments on that?

Re-reading the thread, the *right* solution is to fix while-no-input,
and apparently the easiest way to do that would be to change
while-no-input so that it calls an `internal--adjust-polling-frequency`
function after binding throw-on-input (and maybe after un-binding it as
well).

On systems which don't use polling at all,
internal--adjust-polling-frequency would just do nothing.

The patch should be fairly simple, but I don't think anyone wrote
such a patch yet, so I can't tell if it would be appropriate for emacs-25.

Maybe for emacs-25 we can live with the workaround of adding a "dummy"
call to (input-pending-p) in execute-extended-command--shorter.


        Stefan

Re: Emacs 25.2 RC1 next week

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Leo Liu <sdl.web@gmail.com>,  emacs-devel@gnu.org, YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
> Date: Sun, 18 Dec 2016 09:53:14 -0500
> 
> Maybe for emacs-25 we can live with the workaround of adding a "dummy"
> call to (input-pending-p) in execute-extended-command--shorter.

Can you suggest such a patch?  And then it would require one more
pretest, sigh.

Re: Emacs 25.2 RC1 next week

[Stefan Monnier]

> Can you suggest such a patch?  And then it would require one more
> pretest, sigh.

I think the patch below does the trick (tho I luckily don't have
a machine on which to test it).


        Stefan


diff --git a/lisp/simple.el b/lisp/simple.el
index 0ee2f06..34b57fe 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -1699,6 +1699,7 @@ If the value is non-nil and not a number, we wait 2 seconds."
                   ;; Don't show the help message if the binding isn't
                   ;; significantly shorter than the M-x command the user typed.
                   (< len (- max 5))))
+      (input-pending-p)     ;Dummy call to trigger input-processing, bug#23002.
       (let ((candidate (pop candidates)))
         (when (equal name
                        (car-safe (completion-try-completion

Re: Emacs 25.2 RC1 next week

[Eli Zaretskii]

> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: sdl.web@gmail.com, emacs-devel@gnu.org, mituharu@math.s.chiba-u.ac.jp
> Date: Sun, 18 Dec 2016 15:17:52 -0500
> 
> I think the patch below does the trick (tho I luckily don't have
> a machine on which to test it).
> 
> 
>         Stefan
> 
> 
> diff --git a/lisp/simple.el b/lisp/simple.el
> index 0ee2f06..34b57fe 100644
> --- a/lisp/simple.el
> +++ b/lisp/simple.el
> @@ -1699,6 +1699,7 @@ If the value is non-nil and not a number, we wait 2 seconds."
>                    ;; Don't show the help message if the binding isn't
>                    ;; significantly shorter than the M-x command the user typed.
>                    (< len (- max 5))))
> +      (input-pending-p)     ;Dummy call to trigger input-processing, bug#23002.
>        (let ((candidate (pop candidates)))
>          (when (equal name
>                         (car-safe (completion-try-completion

Thanks.

Leo, can you test this?

Re: Emacs 25.2 RC1 next week

[Leo Liu]

On 2016-12-18 22:28 +0200, Eli Zaretskii wrote:
[snipped 27 lines]
> Leo, can you test this?

That patch seems to do the trick.

Sorry for the delay. I was on the road and have trouble building a new
executable on macOS after its recent update.

Leo

Re: Emacs 25.2 RC1 next week

[Eli Zaretskii]

> From: Leo Liu <sdl.web@gmail.com>
> Date: Tue, 20 Dec 2016 09:32:28 +0800
> 
> On 2016-12-18 22:28 +0200, Eli Zaretskii wrote:
> [snipped 27 lines]
> > Leo, can you test this?
> 
> That patch seems to do the trick.

Then let's get it into emacs-25.  Thanks.

> Sorry for the delay. I was on the road and have trouble building a new
> executable on macOS after its recent update.

Thank you for your efforts.

Re: Emacs 25.2 RC1 next week

[Leo Liu]

On 2016-12-20 05:31 +0200, Eli Zaretskii wrote:
>> That patch seems to do the trick.
>
> Then let's get it into emacs-25.  Thanks.

Thanks. Will this be committed in due time?

Leo

Re: Emacs 25.2 RC1 next week

[Eli Zaretskii]

> From:  Leo Liu <sdl.web@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 22 Dec 2016 14:23:28 +0800
> 
> On 2016-12-20 05:31 +0200, Eli Zaretskii wrote:
> >> That patch seems to do the trick.
> >
> > Then let's get it into emacs-25.  Thanks.
> 
> Thanks. Will this be committed in due time?

I hope so.  Stefan?

Re: Emacs 25.2 RC1 next week

[Eli Zaretskii]

> Date: Thu, 22 Dec 2016 18:29:23 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
> 
> > From:  Leo Liu <sdl.web@gmail.com>
> > Cc: emacs-devel@gnu.org
> > Date: Thu, 22 Dec 2016 14:23:28 +0800
> > 
> > On 2016-12-20 05:31 +0200, Eli Zaretskii wrote:
> > >> That patch seems to do the trick.
> > >
> > > Then let's get it into emacs-25.  Thanks.
> > 
> > Thanks. Will this be committed in due time?
> 
> I hope so.  Stefan?

Stefan didn't reply, so I pushed this for him.

Re: Emacs 25.2 RC1 next week

[Leo Liu]

On 2016-12-23 10:55 +0200, Eli Zaretskii wrote:
> Stefan didn't reply, so I pushed this for him.

Thank you and happy holidays.

Leo

Re: Emacs 25.2 RC1 next week

[Stefan Monnier]

> Stefan didn't reply, so I pushed this for him.

Thanks, and sorry for the delay,


        Stefan

Re: Emacs 25.2 RC1 next week

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Fri, 23 Dec 2016 19:56:47 -0500
> 
> > Stefan didn't reply, so I pushed this for him.
> 
> Thanks, and sorry for the delay,

It's a problematic time for making deadlines, and you are welcome ;-)

Re: Emacs 25.2 RC1 next week

[Leo Liu]

On 2016-12-24 10:11 +0200, Eli Zaretskii wrote:
> It's a problematic time for making deadlines, and you are welcome

May I draw your attention to https://debbugs.gnu.org/25260 which I think
should be fixed for 25.2. Any objections?

Leo

Re: Emacs 25.2 RC1 next week

[Eli Zaretskii]

> From:  Leo Liu <sdl.web@gmail.com>
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>,  emacs-devel@gnu.org
> Date: Sun, 25 Dec 2016 10:32:56 +0800
> 
> On 2016-12-24 10:11 +0200, Eli Zaretskii wrote:
> > It's a problematic time for making deadlines, and you are welcome
> 
> May I draw your attention to https://debbugs.gnu.org/25260 which I think
> should be fixed for 25.2. Any objections?

Patches are welcome to fix that.

Re: Emacs 25.2 RC1 next week

[Leo Liu]

On 2016-12-25 05:35 +0200, Eli Zaretskii wrote:
> Patches are welcome to fix that.

Fixed in emacs-25. Thanks.

Leo