From: Eli Zaretskii <eliz@gnu.org>
To: "Perry E. Metzger" <perry@piermont.com>
Cc: cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: Advice needed on modeline customization hack...
Date: Mon, 17 Apr 2017 18:31:28 +0300 [thread overview]
Message-ID: <83d1cbdp9r.fsf@gnu.org> (raw)
In-Reply-To: <20170417112144.7de5cc4f@jabberwock.cb.piermont.com> (perry@piermont.com)
> Date: Mon, 17 Apr 2017 11:21:44 -0400
> From: "Perry E. Metzger" <perry@piermont.com>
> Cc: cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org
>
> I've renamed the variable column-number-indicator-zero-based as
> suggested, though I'm wondering if we should say "display" instead of
> "indicator" to match the documentation.
The manual speaks of an indicator, so I think this is okay. But I
don't pretend to be good with names, so if someone has a better name,
I hope they will speak up.
> I've set it to :type 'boolean in :group 'mode-line (and have made all
> your other proposed changes with one exception):
>
> > > I think it's best to have
> > > it in xdisp.c, where the feature is implemented, in which case you
> > > should add the necessary stuff to cus-start.el to allow its
> > > customization by Custom.
> >
> > I thought that since the rest of the lisp side was done there
> > (including the minor mode) that it was better to have it in the .el
> > file. Do you have a strong opinion?
>
> Looking around, it seems that many such customization variables are in
> simple.el already, and that there is a bias now towards putting code
> into the lisp side and not the C side, so for now, my new patch leaves
> it there.
Then I think it should be in bindings.el, not in simple.el, to at
least be in the same file as related code.
> +(defcustom column-number-indicator-zero-based t
> + "When set to true, Column Number mode displays columns starting
> +from zero at the left margin of the window. Otherwise, displayed
> +column numbers start from one."
> + :type 'boolean
> + :group 'mode-line)
Please add a ':version' tag.
Thanks.
next prev parent reply other threads:[~2017-04-17 15:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-16 1:28 Advice needed on modeline customization hack Perry E. Metzger
2017-04-16 1:55 ` Perry E. Metzger
2017-04-16 3:11 ` Stefan Monnier
2017-04-16 13:49 ` Perry E. Metzger
2017-04-16 14:07 ` Stefan Monnier
2017-04-16 14:46 ` Perry E. Metzger
2017-04-16 15:02 ` Clément Pit-Claudel
2017-04-16 16:09 ` Perry E. Metzger
2017-04-16 20:59 ` Clément Pit-Claudel
2017-04-16 22:06 ` Perry E. Metzger
2017-04-16 22:16 ` Perry E. Metzger
2017-04-16 22:57 ` Perry E. Metzger
2017-04-16 23:48 ` Drew Adams
2017-04-17 0:13 ` Perry E. Metzger
2017-04-17 6:00 ` Eli Zaretskii
2017-04-17 12:53 ` Perry E. Metzger
2017-04-17 14:17 ` Eli Zaretskii
2017-04-17 15:24 ` Perry E. Metzger
2017-04-17 15:34 ` Eli Zaretskii
2017-04-17 18:07 ` Perry E. Metzger
2017-04-17 18:23 ` Eli Zaretskii
2017-04-17 18:55 ` Perry E. Metzger
2017-04-17 19:07 ` Noam Postavsky
2017-04-17 19:18 ` Perry E. Metzger
2017-05-10 17:59 ` Eli Zaretskii
2017-04-17 15:21 ` Perry E. Metzger
2017-04-17 15:31 ` Eli Zaretskii [this message]
2017-04-17 15:55 ` Perry E. Metzger
2017-04-17 16:13 ` Eli Zaretskii
2017-04-17 6:02 ` Eli Zaretskii
2017-04-17 12:32 ` Perry E. Metzger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d1cbdp9r.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=cpitclaudel@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=perry@piermont.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).