From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Advice needed on modeline customization hack... Date: Mon, 17 Apr 2017 18:31:28 +0300 Message-ID: <83d1cbdp9r.fsf@gnu.org> References: <20170415212800.5be89037@jabberwock.cb.piermont.com> <20170416094929.51e94c82@jabberwock.cb.piermont.com> <20170416104633.1768bbb6@jabberwock.cb.piermont.com> <20170416120942.36af8967@jabberwock.cb.piermont.com> <20170416180620.3615b4b6@jabberwock.cb.piermont.com> <20170416181607.4ca1971e@jabberwock.cb.piermont.com> <20170416185740.7d848393@jabberwock.cb.piermont.com> <83ziffefpj.fsf@gnu.org> <20170417085326.1e3c4b30@jabberwock.cb.piermont.com> <20170417112144.7de5cc4f@jabberwock.cb.piermont.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1492443093 772 195.159.176.226 (17 Apr 2017 15:31:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Apr 2017 15:31:33 +0000 (UTC) Cc: cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: "Perry E. Metzger" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 17 17:31:28 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d08ci-00005t-DP for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 17:31:28 +0200 Original-Received: from localhost ([::1]:37149 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d08co-0005fW-6X for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 11:31:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d08cG-0005fN-7m for emacs-devel@gnu.org; Mon, 17 Apr 2017 11:31:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d08cC-0004FG-UY for emacs-devel@gnu.org; Mon, 17 Apr 2017 11:31:00 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46613) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d08cC-0004FA-Pu; Mon, 17 Apr 2017 11:30:56 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1642 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d08cB-0008MN-Rz; Mon, 17 Apr 2017 11:30:56 -0400 In-reply-to: <20170417112144.7de5cc4f@jabberwock.cb.piermont.com> (perry@piermont.com) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214065 Archived-At: > Date: Mon, 17 Apr 2017 11:21:44 -0400 > From: "Perry E. Metzger" > Cc: cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org > > I've renamed the variable column-number-indicator-zero-based as > suggested, though I'm wondering if we should say "display" instead of > "indicator" to match the documentation. The manual speaks of an indicator, so I think this is okay. But I don't pretend to be good with names, so if someone has a better name, I hope they will speak up. > I've set it to :type 'boolean in :group 'mode-line (and have made all > your other proposed changes with one exception): > > > > I think it's best to have > > > it in xdisp.c, where the feature is implemented, in which case you > > > should add the necessary stuff to cus-start.el to allow its > > > customization by Custom. > > > > I thought that since the rest of the lisp side was done there > > (including the minor mode) that it was better to have it in the .el > > file. Do you have a strong opinion? > > Looking around, it seems that many such customization variables are in > simple.el already, and that there is a bias now towards putting code > into the lisp side and not the C side, so for now, my new patch leaves > it there. Then I think it should be in bindings.el, not in simple.el, to at least be in the same file as related code. > +(defcustom column-number-indicator-zero-based t > + "When set to true, Column Number mode displays columns starting > +from zero at the left margin of the window. Otherwise, displayed > +column numbers start from one." > + :type 'boolean > + :group 'mode-line) Please add a ':version' tag. Thanks.