unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* native-comp-async-cu-done-functions
@ 2021-08-21 13:04 Eli Zaretskii
  2021-08-22  7:52 ` native-comp-async-cu-done-functions Andrea Corallo via Emacs development discussions.
  0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2021-08-21 13:04 UTC (permalink / raw)
  To: Andrea Corallo; +Cc: emacs-devel

Andrea,

The doc string of the variable in the Subject says "after
asynchronously compiling one compilation unit", but it actually is
called when we are done native-compiling a .el file in its entirety,
right?  That is, in this context "compilation unit" is the same as the
Lisp file, correct?

Thanks.



^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: native-comp-async-cu-done-functions
  2021-08-21 13:04 native-comp-async-cu-done-functions Eli Zaretskii
@ 2021-08-22  7:52 ` Andrea Corallo via Emacs development discussions.
  2021-08-22  8:43   ` native-comp-async-cu-done-functions Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: Andrea Corallo via Emacs development discussions. @ 2021-08-22  7:52 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

> Andrea,
>
> The doc string of the variable in the Subject says "after
> asynchronously compiling one compilation unit", but it actually is
> called when we are done native-compiling a .el file in its entirety,
> right?

Correct

> That is, in this context "compilation unit" is the same as the
> Lisp file, correct?

I'd say compilation unit is everything that being compiled produces an
eln file (Ex we can also compile single forms).  That said as for async
compilation we handle as input only el files so yeah in this case as you
suggests the two definitions overlap.

If you are thinking about improving the clarity of this docstring please
go head.

Thanks

  Andrea



^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: native-comp-async-cu-done-functions
  2021-08-22  7:52 ` native-comp-async-cu-done-functions Andrea Corallo via Emacs development discussions.
@ 2021-08-22  8:43   ` Eli Zaretskii
  0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2021-08-22  8:43 UTC (permalink / raw)
  To: Andrea Corallo; +Cc: emacs-devel

> From: Andrea Corallo <akrl@sdf.org>
> Cc: emacs-devel@gnu.org
> Date: Sun, 22 Aug 2021 07:52:05 +0000
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Andrea,
> >
> > The doc string of the variable in the Subject says "after
> > asynchronously compiling one compilation unit", but it actually is
> > called when we are done native-compiling a .el file in its entirety,
> > right?
> 
> Correct

Thanks.

> If you are thinking about improving the clarity of this docstring please
> go head.

Done.



^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-22  8:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-21 13:04 native-comp-async-cu-done-functions Eli Zaretskii
2021-08-22  7:52 ` native-comp-async-cu-done-functions Andrea Corallo via Emacs development discussions.
2021-08-22  8:43   ` native-comp-async-cu-done-functions Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).