From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org, luangruo@yahoo.com
Subject: Re: master ee6e4bc525: Update device-specific grab during drag-and-drop
Date: Sun, 21 Aug 2022 16:12:45 +0300 [thread overview]
Message-ID: <838rnhd9ki.fsf@gnu.org> (raw)
In-Reply-To: <87czctn3zl.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 21 Aug 2022 15:03:10 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Po Lu <luangruo@yahoo.com>
> Date: Sun, 21 Aug 2022 15:03:10 +0200
>
> Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
>
> > Update device-specific grab during drag-and-drop
> >
> > * src/xterm.c (x_detect_focus_change): Fix typo.
> > (handle_one_xevent): Set device if DND is in progress and update
> > device->grab.
>
> This (or something other change in this area) leads to the following
> warnings in an --with-x-toolkit=no build on the current Ubuntu:
>
> xterm.c: In function 'handle_one_xevent':
> xterm.c:21537:40: warning: potential null pointer dereference [-Wnull-dereference]
> 21537 | device->grab &= ~(1 << xev->detail);
> | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
> xterm.c:21537:40: warning: potential null pointer dereference [-Wnull-dereference]
> 21537 | device->grab &= ~(1 << xev->detail);
> | ^~
I tried to fix this now.
next prev parent reply other threads:[~2022-08-21 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165594564645.17861.9851899361770628544@vcs2.savannah.gnu.org>
[not found] ` <20220623005406.BF9E6C01682@vcs2.savannah.gnu.org>
2022-08-21 13:03 ` master ee6e4bc525: Update device-specific grab during drag-and-drop Lars Ingebrigtsen
2022-08-21 13:12 ` Eli Zaretskii [this message]
2022-08-21 13:15 ` Lars Ingebrigtsen
2022-08-21 13:33 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838rnhd9ki.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).