From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master ee6e4bc525: Update device-specific grab during drag-and-drop Date: Sun, 21 Aug 2022 16:12:45 +0300 Message-ID: <838rnhd9ki.fsf@gnu.org> References: <165594564645.17861.9851899361770628544@vcs2.savannah.gnu.org> <20220623005406.BF9E6C01682@vcs2.savannah.gnu.org> <87czctn3zl.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6010"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, luangruo@yahoo.com To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 21 15:13:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oPklu-0001Nx-Dd for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Aug 2022 15:13:46 +0200 Original-Received: from localhost ([::1]:36048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oPklt-0005cS-Ed for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Aug 2022 09:13:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oPkku-0004XD-Ge for emacs-devel@gnu.org; Sun, 21 Aug 2022 09:12:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50736) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oPkku-0006VP-2y; Sun, 21 Aug 2022 09:12:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1KfN7ebm8GrN3CeFyMuEIU9JxHQM2MD6u//mIPa3KiU=; b=iH4JtXF/8zkU m5dp6a0BWLELk1dJ45gSwh5W5rkEMd2pnn+0k456oRCp2uujhgIa+XlSQXXssXOkOzdLY54g5mgvf RR2B2St81bP78wVA+9qChhFTY4ByfdNYc+QL2mUjSrm3T8gcCmOb+nub+mlx6WStCN4QkHgqH2nWp cLFR1HpBPYldvDM7kjaG9MGxYg8E7624YvJN3/HUMw+bQFXZhxdJrubZtGwOtPzk84mY536rSC2/B zW0l9m1pO+spAO1vA+/rKiWd4OdlrDqMgK7K65fOLMcaDyjy7RGNseyZLmGIDWd7KSCpYEIi7+3QO pSmPBvdvI3nhtbfPkv+SUw==; Original-Received: from [87.69.77.57] (port=3985 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oPkkt-0007Lw-H3; Sun, 21 Aug 2022 09:12:43 -0400 In-Reply-To: <87czctn3zl.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 21 Aug 2022 15:03:10 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293695 Archived-At: > From: Lars Ingebrigtsen > Cc: Po Lu > Date: Sun, 21 Aug 2022 15:03:10 +0200 > > Po Lu via Mailing list for Emacs changes writes: > > > Update device-specific grab during drag-and-drop > > > > * src/xterm.c (x_detect_focus_change): Fix typo. > > (handle_one_xevent): Set device if DND is in progress and update > > device->grab. > > This (or something other change in this area) leads to the following > warnings in an --with-x-toolkit=no build on the current Ubuntu: > > xterm.c: In function 'handle_one_xevent': > xterm.c:21537:40: warning: potential null pointer dereference [-Wnull-dereference] > 21537 | device->grab &= ~(1 << xev->detail); > | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ > xterm.c:21537:40: warning: potential null pointer dereference [-Wnull-dereference] > 21537 | device->grab &= ~(1 << xev->detail); > | ^~ I tried to fix this now.