Trunk build broken for MinGW

Trunk build broken for MinGW

[Andy Moreton]

Hi,

Building trunk r117570 on Win7 with MinGW toolchain, I see this:

gcc -std=gnu99 -c -mtune=pentium4 -I/c/emacs/mingw-devel/include
-I/c/emacs/mingw-devel/src/xpm/3.5.1/libXpm-3.5.1-src/lib
-DUSE_CRT_DLL=1 -I /c/emacs/src/emacs/trunk/obj-mingw32/../nt/inc
-Demacs -I. -I../../src -I../lib -I../../lib -mtune=pentium4
-mms-bitfields -Ic:/emacs/mingw-devel/include/librsvg-2.0
-Ic:/emacs/mingw-devel/include/glib-2.0
-Ic:/emacs/mingw-devel/lib/glib-2.0/include
-Ic:/emacs/mingw-devel/include/gdk-pixbuf-2.0
-Ic:/emacs/mingw-devel/include/cairo
-Ic:/emacs/mingw-devel/include/libpng16
-Ic:/emacs/mingw-devel/include/pixman-1
-Ic:/emacs/mingw-devel/include/libxml2 -MMD -MF deps/w32term.d -MP
-Ic:/emacs/mingw-devel/include -Ic:/emacs/mingw-devel/include/p11-kit-1
-O0 -g3 ../../src/w32term.c
../../src/w32term.c: In function 'w32_show_hourglass':
../../src/w32term.c:6188:8: error: 'menubar_in_use' undeclared (first use in this function)
../../src/w32term.c:6188:8: note: each undeclared identifier is reported only once for each function it appears in
../../src/w32term.c:6188:27: error: 'current_popup_menu' undeclared (first use in this function)

This appears to be caused by changes in trunk r117570.

    AndyM

Re: Trunk build broken for MinGW

[martin rudalics]

> ../../src/w32term.c: In function 'w32_show_hourglass':
> ../../src/w32term.c:6188:8: error: 'menubar_in_use' undeclared (first use in this function)
> ../../src/w32term.c:6188:8: note: each undeclared identifier is reported only once for each function it appears in
> ../../src/w32term.c:6188:27: error: 'current_popup_menu' undeclared (first use in this function)
>
> This appears to be caused by changes in trunk r117570.

I checked in a provisional fix.  Please try it.

martin

Re: Trunk build broken for MinGW

[Eli Zaretskii]

> Date: Fri, 25 Jul 2014 11:32:27 +0200
> From: martin rudalics <rudalics@gmx.at>
> 
> > ../../src/w32term.c: In function 'w32_show_hourglass':
> > ../../src/w32term.c:6188:8: error: 'menubar_in_use' undeclared (first use in this function)
> > ../../src/w32term.c:6188:8: note: each undeclared identifier is reported only once for each function it appears in
> > ../../src/w32term.c:6188:27: error: 'current_popup_menu' undeclared (first use in this function)
> >
> > This appears to be caused by changes in trunk r117570.
> 
> I checked in a provisional fix.  Please try it.

Thanks.  It was the right fix, but it is better to have extern
declarations in headers.  I did that in r117573.