unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Build is broken on macOS
@ 2017-01-05 10:16 Kaloyan Ivanov
  2017-01-05 16:14 ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Kaloyan Ivanov @ 2017-01-05 10:16 UTC (permalink / raw)
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]

Commit d88cdad2847726438c7d1de9fd2651c4be9243aa doesn’t build on macOS

The sed on El Capitan balks at the script constructed in autopen.sh.
This patch fixes that on macOS, can someone please test it on other platforms - don’t know if it works there as it should.
“
diff --git a/autogen.sh b/autogen.sh
index f6bfde6..e6d7ef4 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -224,7 +224,8 @@ do_git=
   ## Create nt/gnulib.mk if it doesn't exist, as autoreconf will need it.
   if test ! -f nt/gnulib.mk; then
       echo 'Inferring nt/gnulib.mk from lib/gnulib.mk ...'
-      metascript='/^[^#]/s|^.*$|/^## begin  *gnulib module &/,/^## end  *gnulib module &/c ## gnulib module & removed|'
+      metascript='/^[^#]/s|^.*$|/^## begin  *gnulib module &/,/^## end  *gnulib module &/c\
+ ## gnulib module & removed|'
       script=`sed "$metascript" nt/gnulib-modules-to-delete.cfg` || exit
       sed "$script" lib/gnulib.mk > nt/gnulib.mk || exit
   fi
“

to ./configure it quicker, you need to add --without-makeinfo (default makeinfo is 4.8, >4.13 is required) and --with-gnutls=no if you don’t have gnutls installed

See also:
https://lists.gnu.org/archive/html/emacs-devel/2017-01/msg00048.html 

[-- Attachment #2: Type: text/html, Size: 7223 bytes --]

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: Build is broken on macOS
  2017-01-05 10:16 Build is broken on macOS Kaloyan Ivanov
@ 2017-01-05 16:14 ` Eli Zaretskii
  2017-01-06 18:47   ` Kaloyan Ivanov
  0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2017-01-05 16:14 UTC (permalink / raw)
  To: Kaloyan Ivanov; +Cc: emacs-devel

> From: Kaloyan Ivanov <klnvnv@gmail.com>
> Date: Thu, 5 Jan 2017 12:16:43 +0200
> 
> Commit d88cdad2847726438c7d1de9fd2651c4be9243aa doesn’t build on macOS
> 
> The sed on El Capitan balks at the script constructed in autopen.sh.
> This patch fixes that on macOS, can someone please test it on other platforms - don’t know if it works there
> as it should.

Thanks.  Your version doesn't do exactly what the Sed script is
supposed to do, at least not on GNU/Linux and on MS-Windows.  So
please try the current master and see if the alternative solution I
pushed solves the macOS problem.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Build is broken on macOS
  2017-01-05 16:14 ` Eli Zaretskii
@ 2017-01-06 18:47   ` Kaloyan Ivanov
  2017-01-07  7:54     ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Kaloyan Ivanov @ 2017-01-06 18:47 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]

A bit late, but just to confirm - the issue with autogen.sh seems fixed now.
Latest commit 8f0376309ee37e4f1da21d78971c4df2df5fd7b6 builds perfectly fine on macOS Sierra.

> On Jan 5, 2017, at 6:14 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Kaloyan Ivanov <klnvnv@gmail.com>
>> Date: Thu, 5 Jan 2017 12:16:43 +0200
>> 
>> Commit d88cdad2847726438c7d1de9fd2651c4be9243aa doesn’t build on macOS
>> 
>> The sed on El Capitan balks at the script constructed in autopen.sh.
>> This patch fixes that on macOS, can someone please test it on other platforms - don’t know if it works there
>> as it should.
> 
> Thanks.  Your version doesn't do exactly what the Sed script is
> supposed to do, at least not on GNU/Linux and on MS-Windows.  So
> please try the current master and see if the alternative solution I
> pushed solves the macOS problem.


[-- Attachment #2: Type: text/html, Size: 1715 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Build is broken on macOS
  2017-01-06 18:47   ` Kaloyan Ivanov
@ 2017-01-07  7:54     ` Eli Zaretskii
  0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2017-01-07  7:54 UTC (permalink / raw)
  To: Kaloyan Ivanov; +Cc: emacs-devel

> From: Kaloyan Ivanov <klnvnv@gmail.com>
> Date: Fri, 6 Jan 2017 20:47:56 +0200
> Cc: emacs-devel@gnu.org
> 
> A bit late, but just to confirm - the issue with autogen.sh seems fixed now.

Thanks for the confirmation.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-01-07  7:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-05 10:16 Build is broken on macOS Kaloyan Ivanov
2017-01-05 16:14 ` Eli Zaretskii
2017-01-06 18:47   ` Kaloyan Ivanov
2017-01-07  7:54     ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).