From: Eli Zaretskii <eliz@gnu.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: emacs-devel@gnu.org, larsi@gnus.org
Subject: Re: which-func.el unconditionally requiring edebug
Date: Wed, 07 Dec 2022 20:17:08 +0200 [thread overview]
Message-ID: <834ju73wpn.fsf@gnu.org> (raw)
In-Reply-To: <CAAeL0SQXsrDS0UqCQxqKzJ8v46uMs6rJvTdpiJjhjjDL04CX6w@mail.gmail.com> (message from Juanma Barranquero on Wed, 7 Dec 2022 19:09:30 +0100)
> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Wed, 7 Dec 2022 19:09:30 +0100
> Cc: emacs-devel@gnu.org, larsi@gnus.org
>
> In fact, I think the (require 'edebug) in which-func.el is leftover code. I didn't realize that Lars had in fact
> reverted that patch, sort of.
>
> In 55cc8b040b (2022-08-08), he modified lisp-mode.el (mentioned in the commit log), and also
> which-func.el and lisp-mode-tests.el (these are not mentioned).
>
> And then, in 48b0f2606b (2022-08-23), he removed just the changes to lisp-mode.el, but he left the new tests
> and the change in which-func.el.
>
> His reverting lisp-mode.el left behind a few little changes, but he removed all references to
> edebug-form-spec, so there's no point now to the one-line change to which-func.el and it should be reverted
> too, I think.
If that require is not needed, there should be no problem removing it.
next prev parent reply other threads:[~2022-12-07 18:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 18:44 which-func.el unconditionally requiring edebug Juanma Barranquero
2022-12-07 15:17 ` Eli Zaretskii
2022-12-07 15:46 ` Juanma Barranquero
2022-12-07 18:09 ` Juanma Barranquero
2022-12-07 18:17 ` Eli Zaretskii [this message]
2022-12-07 21:28 ` Juanma Barranquero
2022-12-08 6:11 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834ju73wpn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).