From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: which-func.el unconditionally requiring edebug Date: Wed, 07 Dec 2022 20:17:08 +0200 Message-ID: <834ju73wpn.fsf@gnu.org> References: <83k033451k.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30677"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, larsi@gnus.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 07 19:19:04 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2z0a-0007oW-Ae for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Dec 2022 19:19:04 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2yzK-0004HU-3e; Wed, 07 Dec 2022 13:17:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2yyw-0004CW-DK for emacs-devel@gnu.org; Wed, 07 Dec 2022 13:17:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2yyw-0006pK-2f; Wed, 07 Dec 2022 13:17:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Y6ov9vrVzM0u0viWk26KUCHliOCIsxke9QbPsGlsOtM=; b=fLlkiNKoKdHQ GymgkX9YMutZ/Fwudy42qfqef43d0+kGg86pjkEALnDW1lzxA6l0WXmLYkN5fr2T/XzE/XSfc+C6T 0eDZTY3l88g2itv0Xyw026H5wzELi9/pGaNgelGahmS2NNGUYiWeY7ve8WbH+CywH0ojSspW+zVrM O790eVzSHMTdTazO1pw7crMWCM5ZKK6lmuiJzVyM8jM4MuuOeAdzbMqWSAehp3CROLJgYOecAkAyi 7K0zzC1kvO46Msn3v6bGFR3gb3jqMt0r7bI6ri8dT+GCQLIRZijsXEZm5aSNMPT2OBMctRseGaqgl Hwx5dgczT/Mt+WJsgavSew==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2yyu-0004EL-Bi; Wed, 07 Dec 2022 13:17:21 -0500 In-Reply-To: (message from Juanma Barranquero on Wed, 7 Dec 2022 19:09:30 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301024 Archived-At: > From: Juanma Barranquero > Date: Wed, 7 Dec 2022 19:09:30 +0100 > Cc: emacs-devel@gnu.org, larsi@gnus.org > > In fact, I think the (require 'edebug) in which-func.el is leftover code. I didn't realize that Lars had in fact > reverted that patch, sort of. > > In 55cc8b040b (2022-08-08), he modified lisp-mode.el (mentioned in the commit log), and also > which-func.el and lisp-mode-tests.el (these are not mentioned). > > And then, in 48b0f2606b (2022-08-23), he removed just the changes to lisp-mode.el, but he left the new tests > and the change in which-func.el. > > His reverting lisp-mode.el left behind a few little changes, but he removed all references to > edebug-form-spec, so there's no point now to the one-line change to which-func.el and it should be reverted > too, I think. If that require is not needed, there should be no problem removing it.