From: Eli Zaretskii <eliz@gnu.org>
To: larsi@gnus.org
Cc: noloader@gmail.com, emacs-devel@gnu.org
Subject: Re: Hang in make check
Date: Mon, 29 Mar 2021 14:24:07 +0300 [thread overview]
Message-ID: <8335wemcdk.fsf@gnu.org> (raw)
In-Reply-To: <834kgumd9s.fsf@gnu.org> (message from Eli Zaretskii on Mon, 29 Mar 2021 14:04:47 +0300)
> Date: Mon, 29 Mar 2021 14:04:47 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: noloader@gmail.com, emacs-devel@gnu.org
>
> > >> Seems to have something to do with timers and timeouts. This hangs:
> > >>
> > >> (read-event nil nil 1)
> > >>
> > >> when run in batch mode, apparently (instead of timing out after one
> > >> second).
> > >
> > > But that's not what the test does (if it did, it would have hanged for
> > > everyone, regardless of the build details).
> >
> > It's not what the test does -- I was stating that this form hangs (when
> > in batch mode in this Emacs configuration).
>
> Sorry for my misunderstanding.
I think the place where read-event hangs in that configuration is in
this fragment from keyboard.c:kbd_buffer_get_event:
#if !defined HAVE_DBUS && !defined USE_FILE_NOTIFY && !defined THREADS_ENABLED
if (noninteractive
/* In case we are running as a daemon, only do this before
detaching from the terminal. */
|| (IS_DAEMON && DAEMON_RUNNING))
{
int c = getchar (); <<<<<<<<<<<<<<<<<<<<<<<<<<
XSETINT (obj, c);
*kbp = current_kboard;
return obj;
}
#endif /* !defined HAVE_DBUS && !defined USE_FILE_NOTIFY && !defined THREADS_ENABLED */
But we still need to understand why this happens (if that's what
happens) in the real test, because AFAIU when unread-command-events is
non-nil, we were not supposed to get to this place, but instead return
the event in unread-command-events.
next prev parent reply other threads:[~2021-03-29 11:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 22:14 Hang in make check Jeffrey Walton
2021-03-28 8:27 ` Michael Albinus
2021-03-28 9:02 ` Jeffrey Walton
2021-03-28 12:14 ` Michael Albinus
2021-03-28 17:28 ` Jeffrey Walton
2021-03-28 19:11 ` Michael Albinus
2021-03-28 19:20 ` Lars Ingebrigtsen
2021-03-28 19:33 ` Jeffrey Walton
2021-03-28 19:42 ` Lars Ingebrigtsen
2021-03-28 19:51 ` Lars Ingebrigtsen
2021-03-29 4:48 ` Eli Zaretskii
2021-03-29 11:00 ` Lars Ingebrigtsen
2021-03-29 11:04 ` Eli Zaretskii
2021-03-29 11:24 ` Eli Zaretskii [this message]
2021-03-30 13:29 ` Lars Ingebrigtsen
2021-03-30 13:46 ` Eli Zaretskii
2021-03-30 14:14 ` Andreas Schwab
2021-03-30 14:33 ` Eli Zaretskii
2021-03-30 15:16 ` Andreas Schwab
2021-03-30 15:33 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8335wemcdk.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=noloader@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).