unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Arthur Miller <arthur.miller@live.com>
Cc: emacs-devel@gnu.org
Subject: Re: Proposal: ls-lisp.el handle --group-directories-first flag
Date: Sun, 25 Jul 2021 10:46:39 +0300	[thread overview]
Message-ID: <8335s2ygww.fsf@gnu.org> (raw)
In-Reply-To: <AM9PR09MB4977FED977E4BE6B6832C14A96E69@AM9PR09MB4977.eurprd09.prod.outlook.com> (message from Arthur Miller on Sat, 24 Jul 2021 21:02:56 +0200)

> From: Arthur Miller <arthur.miller@live.com>
> Cc: emacs-devel@gnu.org
> Date: Sat, 24 Jul 2021 21:02:56 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: Arthur Miller <arthur.miller@live.com>
> >> Cc: emacs-devel@gnu.org
> >> Date: Sat, 24 Jul 2021 16:58:08 +0200
> >> 
> >> >> > Btw, in my testing, with ls-lisp-dirs-first bound non-nil, the
> >> >> > directories are shown in their correct alphabetically sorted order.
> >> >> > So I'm unsure what problems you saw and in which scenario.  Can you
> >> >> > tell more about this issue?
> >> 
> >> When I was testing, if ls-lisp-dirs-first is nil, and
> >> --group-directories-first is specified, dirs come out in reverse order
> >> in new buffer. Just reverting the buffer didn't show this. I don't know
> >> why it is so.
> >
> > Because --group-directories-first includes 'r'?
> No, it is removed from switches before sorting happends, in this patch.
> 
> >> If you are OK with the patch2, then here is one without -U on top of
> >> that one.
> >
> > I take it that the problem with the reverse order doesn't exist?  Or
> > does it still exist and needs to be debugged?
> 
> No longer, the last patch fixes it by setting let-bound value of
> ls-lisp-dirs-first to 't. I hope somebody else test it too,
> beside me.

Thanks, I installed it, with some minimal changes.

Btw, I don't see a copyright assignment for your contributions on
file.  Would you like to start the legal paperwork rolling, so we
could accept further contributions from you in the future?



  reply	other threads:[~2021-07-25  7:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-15  9:19 Proposal: ls-lisp.el handle --group-directories-first flag Arthur Miller
2021-07-16 11:57 ` Eli Zaretskii
2021-07-16 13:20   ` Arthur Miller
2021-07-16 13:44     ` Eli Zaretskii
2021-07-16 14:58       ` Arthur Miller
2021-07-17 11:57         ` Eli Zaretskii
2021-07-19 20:59           ` Arthur Miller
2021-07-24 11:13             ` Eli Zaretskii
2021-07-24 11:27               ` Eli Zaretskii
2021-07-24 11:54                 ` Arthur Miller
2021-07-24 12:07                   ` Eli Zaretskii
2021-07-24 14:58                     ` Arthur Miller
2021-07-24 15:43                       ` Eli Zaretskii
2021-07-24 19:02                         ` Arthur Miller
2021-07-25  7:46                           ` Eli Zaretskii [this message]
2021-07-25  8:29                             ` Arthur Miller
2021-07-25  9:11                               ` Eli Zaretskii
2021-07-25  9:31                                 ` Arthur Miller
2021-07-25 12:44                                 ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8335s2ygww.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=arthur.miller@live.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).