From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Proposal: ls-lisp.el handle --group-directories-first flag Date: Sun, 25 Jul 2021 10:46:39 +0300 Message-ID: <8335s2ygww.fsf@gnu.org> References: <8335se5v40.fsf@gnu.org> <83y2a64bla.fsf@gnu.org> <83czrh40hf.fsf@gnu.org> <83o8asynga.fsf@gnu.org> <83k0lgymsd.fsf@gnu.org> <83im0zzzhq.fsf@gnu.org> <83a6mbzpia.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3780"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Arthur Miller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 25 09:47:33 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7YrD-0000oL-T9 for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Jul 2021 09:47:31 +0200 Original-Received: from localhost ([::1]:45604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7YrC-00015G-Vo for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Jul 2021 03:47:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51210) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7YqY-0000P6-Sr for emacs-devel@gnu.org; Sun, 25 Jul 2021 03:46:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:32932) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7YqY-0008Uc-8R; Sun, 25 Jul 2021 03:46:50 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4889 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7YqX-0001Dn-S9; Sun, 25 Jul 2021 03:46:50 -0400 In-Reply-To: (message from Arthur Miller on Sat, 24 Jul 2021 21:02:56 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271587 Archived-At: > From: Arthur Miller > Cc: emacs-devel@gnu.org > Date: Sat, 24 Jul 2021 21:02:56 +0200 > > Eli Zaretskii writes: > > >> From: Arthur Miller > >> Cc: emacs-devel@gnu.org > >> Date: Sat, 24 Jul 2021 16:58:08 +0200 > >> > >> >> > Btw, in my testing, with ls-lisp-dirs-first bound non-nil, the > >> >> > directories are shown in their correct alphabetically sorted order. > >> >> > So I'm unsure what problems you saw and in which scenario. Can you > >> >> > tell more about this issue? > >> > >> When I was testing, if ls-lisp-dirs-first is nil, and > >> --group-directories-first is specified, dirs come out in reverse order > >> in new buffer. Just reverting the buffer didn't show this. I don't know > >> why it is so. > > > > Because --group-directories-first includes 'r'? > No, it is removed from switches before sorting happends, in this patch. > > >> If you are OK with the patch2, then here is one without -U on top of > >> that one. > > > > I take it that the problem with the reverse order doesn't exist? Or > > does it still exist and needs to be debugged? > > No longer, the last patch fixes it by setting let-bound value of > ls-lisp-dirs-first to 't. I hope somebody else test it too, > beside me. Thanks, I installed it, with some minimal changes. Btw, I don't see a copyright assignment for your contributions on file. Would you like to start the legal paperwork rolling, so we could accept further contributions from you in the future?