From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: tumashu@163.com, emacs-devel@gnu.org
Subject: Re: [PATCH] xwidget: Add xwidget-webkit-buffer-name-format (Re:Re: About rename xwidget-webkit-buffer-name-prefix)
Date: Thu, 11 Nov 2021 08:54:36 +0200 [thread overview]
Message-ID: <8335o32ndf.fsf@gnu.org> (raw)
In-Reply-To: <87pmr73562.fsf@yahoo.com> (message from Po Lu on Thu, 11 Nov 2021 08:30:13 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Cc: tumashu <tumashu@163.com>, emacs-devel@gnu.org
> Date: Thu, 11 Nov 2021 08:30:13 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> + (rename-buffer
> >> + (format-spec
> >> + xwidget-webkit-buffer-name-format
> >> + `((?T . ,title)))
> >> + t)))))
>
> > Hmmm... does this mean that the format spec _must_ contain %T?
> > Because otherwise all the buffers will have the same name, no?
> > Which would mean this change introduces a regression wrt how this
> > worked previously, right?
>
> It tells `rename-buffer' to come up with a new name in that cases, which
> is pretty much how the old code worked (except it called
> `generate-new-buffer-name' manually).
Thanks, I have no more comments to that patch.
next prev parent reply other threads:[~2021-11-11 6:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 12:31 About rename xwidget-webkit-buffer-name-prefix tumashu
2021-11-09 12:34 ` Po Lu
2021-11-10 6:33 ` Po Lu
2021-11-10 6:46 ` tumashu
2021-11-10 6:52 ` Po Lu
2021-11-10 6:54 ` Lars Ingebrigtsen
2021-11-10 8:16 ` [PATCH] xwidget: Add xwidget-webkit-buffer-name-format (Re:Re: About rename xwidget-webkit-buffer-name-prefix) tumashu
2021-11-10 9:32 ` Po Lu
2021-11-10 9:49 ` tumashu
2021-11-10 9:50 ` Po Lu
2021-11-10 13:54 ` Eli Zaretskii
2021-11-10 22:41 ` tumashu
2021-11-11 0:15 ` tumashu
2021-11-11 0:30 ` Po Lu
2021-11-11 6:54 ` Eli Zaretskii [this message]
2021-11-11 10:26 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8335o32ndf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
--cc=tumashu@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).