From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] xwidget: Add xwidget-webkit-buffer-name-format (Re:Re: About rename xwidget-webkit-buffer-name-prefix) Date: Thu, 11 Nov 2021 08:54:36 +0200 Message-ID: <8335o32ndf.fsf@gnu.org> References: <1fb88962.612a.17d04aea638.Coremail.tumashu@163.com> <87tugkcyfj.fsf@yahoo.com> <4e33ab77.4b00.17d08eb9d6c.Coremail.tumashu@163.com> <87k0hg73vb.fsf@yahoo.com> <5a34c1b6.5a6c.17d09403c8c.Coremail.tumashu@163.com> <831r3o3ylu.fsf@gnu.org> <87pmr73562.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31670"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tumashu@163.com, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 11 07:55:42 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ml3zq-0007xk-5I for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Nov 2021 07:55:42 +0100 Original-Received: from localhost ([::1]:54310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ml3zo-0002ag-Uu for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Nov 2021 01:55:40 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ml3yo-0001CZ-U3 for emacs-devel@gnu.org; Thu, 11 Nov 2021 01:54:38 -0500 Original-Received: from [2001:470:142:3::e] (port=43320 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ml3yo-0001sx-L9; Thu, 11 Nov 2021 01:54:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dyVvdL94NPDYVJmeWVxFXfrGPfEfNjjja63cZZfCp2U=; b=VuZnyTFyGWX6 xhkahwYEhUf70j5SAbEJ37qcAdHSSQOu5wS2rCUC2EJuu5tx5Zk6O3h2vOyjKRjcfnjouvNmr78wf qOxH2Ur656Wb1ARqFZMRRdARpxCWKnSx5WYVrjtV2vc+hT+BGFpr7GWczVF/LuhL25xEdu8TN+hsd Jjic+qvESPb5OTdc3zJQ0XAcxjZ0juwMyTq7LP84LwuoifWERyMTSfGC/ZVv5TY7Q7XEsZcyF1ttv Zl+JM4/UNO/249K7ZkL8ZGLVeeVJcr1lAVBrwzxw38hST+afEtaj2ag76ERo9NVts00Mb2N0iADU1 1vOTAtJxt/yXxNUW8P+iBQ==; Original-Received: from [87.69.77.57] (port=3628 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ml3yo-0005iN-7c; Thu, 11 Nov 2021 01:54:38 -0500 In-Reply-To: <87pmr73562.fsf@yahoo.com> (message from Po Lu on Thu, 11 Nov 2021 08:30:13 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279226 Archived-At: > From: Po Lu > Cc: tumashu , emacs-devel@gnu.org > Date: Thu, 11 Nov 2021 08:30:13 +0800 > > Eli Zaretskii writes: > > >> + (rename-buffer > >> + (format-spec > >> + xwidget-webkit-buffer-name-format > >> + `((?T . ,title))) > >> + t))))) > > > Hmmm... does this mean that the format spec _must_ contain %T? > > Because otherwise all the buffers will have the same name, no? > > Which would mean this change introduces a regression wrt how this > > worked previously, right? > > It tells `rename-buffer' to come up with a new name in that cases, which > is pretty much how the old code worked (except it called > `generate-new-buffer-name' manually). Thanks, I have no more comments to that patch.