From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: casouri@gmail.com, emacs-devel@gnu.org, monnier@iro.umontreal.ca,
theo@thornhill.no
Subject: Re: Tree-sitter and major mode inheritance
Date: Sun, 20 Nov 2022 09:28:09 +0200 [thread overview]
Message-ID: <8335ae6q5y.fsf@gnu.org> (raw)
In-Reply-To: <cf68f54d-fc54-b999-2f08-61ac43f18300@yandex.ru> (message from Dmitry Gutov on Sun, 20 Nov 2022 01:42:04 +0200)
> Date: Sun, 20 Nov 2022 01:42:04 +0200
> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org,
> monnier@iro.umontreal.ca, theo@thornhill.no
> From: Dmitry Gutov <dgutov@yandex.ru>
>
> On 20.11.2022 01:36, Yuan Fu wrote:
> > If we keep js-mode as-is, and add js-base-mode and js-ts-mode, (derived-mode-p ‘js-mode) should keep working as before, or maybe I’m msiunderstanding your question?
>
> (derived-mode-p 'js-mode) will return nil in js-ts-mode.
>
> Which could be a problem when this call is used as a substitute for a
> file type check (e.g. "are we editing a JavaScript file?"), which is one
> of its common uses.
This test can only work on the assumption that there's a single parent mode
for all the modes which support a given programming language. This is a
fragile assumption, so code which is based on it is broken and should be
fixed.
IOW, I don't think we should feel ourselves bound by this fragile
assumption (assuming the solution we decide on breaks it).
next prev parent reply other threads:[~2022-11-20 7:28 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 20:45 Tree-sitter and major mode inheritance Yuan Fu
2022-11-18 21:54 ` Suggesting that feature/tree-sitter be merged (was Re: Tree-sitter and major mode inheritance) Jostein Kjønigsen
2022-11-18 22:34 ` Philip Kaludercic
2022-11-18 22:58 ` Yuan Fu
2022-11-18 23:36 ` Stefan Monnier
2022-11-19 7:09 ` Philip Kaludercic
2022-11-19 14:07 ` Standardized access to a REPL (was: Suggesting that feature/tree-sitter be merged) Stefan Monnier
2022-11-19 15:03 ` Standardized access to a REPL Philip Kaludercic
2022-11-19 16:07 ` Stefan Monnier
2022-11-19 16:10 ` Philip Kaludercic
2022-11-19 16:18 ` Eli Zaretskii
2022-11-19 22:31 ` Stefan Monnier
2022-11-20 9:25 ` Philip Kaludercic
2022-11-19 8:29 ` Suggesting that feature/tree-sitter be merged (was Re: Tree-sitter and major mode inheritance) Eli Zaretskii
2022-11-19 10:46 ` Philip Kaludercic
2022-11-19 11:36 ` Eli Zaretskii
2022-11-19 12:15 ` Philip Kaludercic
2022-11-19 13:05 ` Eli Zaretskii
2022-11-19 21:34 ` Dmitry Gutov
2022-11-18 22:52 ` Yuan Fu
2022-11-19 5:21 ` Theodor Thornhill
2022-11-19 18:35 ` Eli Zaretskii
2022-11-19 18:46 ` Theodor Thornhill
2022-11-19 18:51 ` Eli Zaretskii
2022-11-19 18:59 ` Theodor Thornhill
2022-11-19 7:36 ` Stefan Kangas
2022-11-19 8:09 ` Eli Zaretskii
2022-11-19 11:25 ` Stefan Kangas
2022-11-19 11:49 ` Theodor Thornhill
2022-11-19 12:03 ` Eli Zaretskii
2022-11-19 8:16 ` Eli Zaretskii
2022-11-19 9:41 ` Tree-sitter and major mode inheritance Yuan Fu
2022-11-19 10:26 ` Eli Zaretskii
2022-11-19 10:29 ` Po Lu
2022-11-19 15:19 ` Stefan Monnier
2022-11-19 17:17 ` Yuan Fu
2022-11-19 17:52 ` Eli Zaretskii
2022-11-19 21:45 ` Yuan Fu
2022-11-20 7:05 ` Eli Zaretskii
2022-11-20 0:38 ` Po Lu
2022-11-19 21:39 ` Dmitry Gutov
2022-11-19 21:49 ` Yuan Fu
2022-11-19 22:03 ` Dmitry Gutov
2022-11-19 22:36 ` Dmitry Gutov
2022-11-19 23:36 ` Yuan Fu
2022-11-19 23:42 ` Dmitry Gutov
2022-11-20 7:28 ` Eli Zaretskii [this message]
2022-11-20 13:22 ` Dmitry Gutov
2022-11-20 14:49 ` Eli Zaretskii
2022-11-20 15:24 ` Dmitry Gutov
2022-11-20 7:11 ` Eli Zaretskii
2022-11-20 9:19 ` Yuan Fu
2022-11-20 10:02 ` Eli Zaretskii
2022-11-20 22:57 ` Yuan Fu
2022-11-20 7:05 ` Eli Zaretskii
2022-11-20 17:12 ` Dmitry Gutov
2022-11-20 17:34 ` Eli Zaretskii
2022-11-20 6:51 ` Eli Zaretskii
2022-11-20 12:45 ` Dmitry Gutov
2022-11-20 14:42 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8335ae6q5y.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=casouri@gmail.com \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).