unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: mattiase@acm.org, emacs-devel@gnu.org
Subject: Re: Scan of broken conditional forms
Date: Sat, 04 Jan 2020 21:39:07 +0200	[thread overview]
Message-ID: <831rsfggf8.fsf@gnu.org> (raw)
In-Reply-To: <1abe6fdc-7466-193a-cbd3-4e2d3bf2660b@cs.ucla.edu> (message from Paul Eggert on Sat, 4 Jan 2020 11:23:29 -0800)

> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Sat, 4 Jan 2020 11:23:29 -0800
> Cc: Emacs developers <emacs-devel@gnu.org>
> 
> Thanks for doing that checking.
> 
> On 1/4/20 4:37 AM, Mattias Engdegård wrote:
> 
> > the code in mml-smime.el looks like it fails to return failure from an unsuccessful encryption attempt
> 
> smime-encrypt-buffer always returns nil (it signals an error on failure), so
> that code happens to work though it is too complicated.
> 
> I fixed that issue along with the others (other than the two that you and
> Michael already fixed) by installing the attached into the emacs-27 branch.

Why are we making non-essential changes on the release branch?



  reply	other threads:[~2020-01-04 19:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-04 12:37 Scan of broken conditional forms Mattias Engdegård
2020-01-04 13:03 ` Michael Albinus
2020-01-04 19:23 ` Paul Eggert
2020-01-04 19:39   ` Eli Zaretskii [this message]
2020-01-04 21:40     ` Paul Eggert
2020-01-05 15:45       ` Eli Zaretskii
2020-01-05 20:48         ` Paul Eggert
2020-01-05 20:57           ` Stefan Monnier
2021-01-27  3:02           ` Broken `if big5-p` code in titdic-cnv.el (was: Scan of broken conditional forms) Stefan Monnier
2021-01-27  8:18             ` Broken `if big5-p` code in titdic-cnv.el Andreas Schwab
2021-01-27 16:16             ` Broken `if big5-p` code in titdic-cnv.el (was: Scan of broken conditional forms) Eli Zaretskii
2021-01-27 17:35               ` Broken `if big5-p` code in titdic-cnv.el Stefan Monnier
2020-01-04 22:04   ` Scan of broken conditional forms Mattias Engdegård
2020-01-04 22:11     ` Paul Eggert
2020-01-31 16:22 ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831rsfggf8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).