From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Scan of broken conditional forms Date: Sat, 04 Jan 2020 21:39:07 +0200 Message-ID: <831rsfggf8.fsf@gnu.org> References: <1abe6fdc-7466-193a-cbd3-4e2d3bf2660b@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="266207"; mail-complaints-to="usenet@blaine.gmane.org" Cc: mattiase@acm.org, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 04 20:39:13 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1inpGT-00179j-Ep for ged-emacs-devel@m.gmane.org; Sat, 04 Jan 2020 20:39:13 +0100 Original-Received: from localhost ([::1]:36324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inpGS-0001rP-Bj for ged-emacs-devel@m.gmane.org; Sat, 04 Jan 2020 14:39:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38428) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inpGM-0001rF-A2 for emacs-devel@gnu.org; Sat, 04 Jan 2020 14:39:07 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1inpGM-0000zp-3Z; Sat, 04 Jan 2020 14:39:06 -0500 Original-Received: from [176.228.60.248] (port=1918 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1inpGL-0001K0-9l; Sat, 04 Jan 2020 14:39:05 -0500 In-reply-to: <1abe6fdc-7466-193a-cbd3-4e2d3bf2660b@cs.ucla.edu> (message from Paul Eggert on Sat, 4 Jan 2020 11:23:29 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243933 Archived-At: > From: Paul Eggert > Date: Sat, 4 Jan 2020 11:23:29 -0800 > Cc: Emacs developers > > Thanks for doing that checking. > > On 1/4/20 4:37 AM, Mattias Engdegård wrote: > > > the code in mml-smime.el looks like it fails to return failure from an unsuccessful encryption attempt > > smime-encrypt-buffer always returns nil (it signals an error on failure), so > that code happens to work though it is too complicated. > > I fixed that issue along with the others (other than the two that you and > Michael already fixed) by installing the attached into the emacs-27 branch. Why are we making non-essential changes on the release branch?