From: Eli Zaretskii <eliz@gnu.org>
To: "Miha Rihtaršič" <miha@kamnitnik.top>,
"Lars Ingebrigtsen" <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 90744ff0be 1/2: comint-fl: Prevent fontification of output as input
Date: Sat, 01 Oct 2022 09:44:16 +0300 [thread overview]
Message-ID: <831qrscabj.fsf@gnu.org> (raw)
> branch: master
> commit 90744ff0be581b69cedea1194b7e78265bdb67a4
> Author: Miha Rihtaršič <miha@kamnitnik.top>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
> comint-fl: Prevent fontification of output as input
>
> * lisp/comint.el (comint-output-filter): Inhibit jit-lock
> fontification of inserted process output before marking it with the
> 'output' filed property (bug#58169).
> ---
> lisp/comint.el | 24 +++++++++++++-----------
> 1 file changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/lisp/comint.el b/lisp/comint.el
> index e7d2136c84..15c9388ea4 100644
> --- a/lisp/comint.el
> +++ b/lisp/comint.el
> @@ -2150,24 +2150,26 @@ Make backspaces delete the previous character."
> ;; insert-before-markers is a bad thing. XXX
> ;; Luckily we don't have to use it any more, we use
> ;; window-point-insertion-type instead.
> - (insert string)
> + (make-local-variable 'jit-lock-mode)
> + (let ((jit-lock-mode nil)) <<<<<<<<<<<<<<<<<<<<<<<<<<<<
> + (insert string)
Isn't that hammer too large/blunt for this job? It will disable every
single function registered with jit-lock, not just the fontification
functions. Some of the functions registered with jit-lock have
nothing to do with fontifications.
next reply other threads:[~2022-10-01 6:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 6:44 Eli Zaretskii [this message]
2022-10-06 18:31 ` master 90744ff0be 1/2: comint-fl: Prevent fontification of output as input miha
2022-10-07 11:44 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831qrscabj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=miha@kamnitnik.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).