From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 90744ff0be 1/2: comint-fl: Prevent fontification of output as input Date: Sat, 01 Oct 2022 09:44:16 +0300 Message-ID: <831qrscabj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17542"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Miha =?utf-8?B?UmlodGFyxaFpxI0=?= , Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 01 08:45:14 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oeWFN-0004Kv-Rh for ged-emacs-devel@m.gmane-mx.org; Sat, 01 Oct 2022 08:45:14 +0200 Original-Received: from localhost ([::1]:45996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oeWFM-0000Mx-9N for ged-emacs-devel@m.gmane-mx.org; Sat, 01 Oct 2022 02:45:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oeWEf-00085q-J9 for emacs-devel@gnu.org; Sat, 01 Oct 2022 02:44:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60528) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oeWEe-0007IF-1k; Sat, 01 Oct 2022 02:44:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:To:From:Date:in-reply-to: references; bh=RXaY3uwXEs6FoUHqdnINzHdwn1TsFQ1dKxxNdoiLTVo=; b=FCIOfjxxe+mfIO Y/IF//RBN4c83rEigZPfj1XpX0Oz7LRYh0Y0XVO/rGwrnqCsbCorch1G7LZHeTCwnq1Do6UWL4dLv e2hrKz0MhR/Lt7sVR+aLLZ6/1p14BGLJZwwkhBqDcgnbddIGoBNkTV68twLy+GiM0HVSm7dthhRPv 2BtwNuaej0rwmk2Dpu1pmNrqP+aZfxSd63ncJJ+pKnZujXM8Nm4F+EPHaycbArTklX71JC2pa5SjH ZqncDs3eOynl182OHG53Zufz50Js1rED1o8z0Rg2qRzdnZsPwicmRzW1HbfyTicAy++/olJf6d7kA QKAU3z3vfmOI+XIPnQ+w==; Original-Received: from [87.69.77.57] (port=4977 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oeWEd-00017O-GW; Sat, 01 Oct 2022 02:44:27 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296543 Archived-At: > branch: master > commit 90744ff0be581b69cedea1194b7e78265bdb67a4 > Author: Miha Rihtaršič > Commit: Lars Ingebrigtsen > > comint-fl: Prevent fontification of output as input > > * lisp/comint.el (comint-output-filter): Inhibit jit-lock > fontification of inserted process output before marking it with the > 'output' filed property (bug#58169). > --- > lisp/comint.el | 24 +++++++++++++----------- > 1 file changed, 13 insertions(+), 11 deletions(-) > > diff --git a/lisp/comint.el b/lisp/comint.el > index e7d2136c84..15c9388ea4 100644 > --- a/lisp/comint.el > +++ b/lisp/comint.el > @@ -2150,24 +2150,26 @@ Make backspaces delete the previous character." > ;; insert-before-markers is a bad thing. XXX > ;; Luckily we don't have to use it any more, we use > ;; window-point-insertion-type instead. > - (insert string) > + (make-local-variable 'jit-lock-mode) > + (let ((jit-lock-mode nil)) <<<<<<<<<<<<<<<<<<<<<<<<<<<< > + (insert string) Isn't that hammer too large/blunt for this job? It will disable every single function registered with jit-lock, not just the fontification functions. Some of the functions registered with jit-lock have nothing to do with fontifications.