* Re: feature/tree-sitter e06953b02a 1/2: Add more font-lock faces (Bug#58940)
[not found] ` <20221110110504.D0D7FC0E4CA@vcs2.savannah.gnu.org>
@ 2022-11-10 11:15 ` Robert Pluim
2022-11-10 11:41 ` Eli Zaretskii
2022-11-11 0:49 ` Randy Taylor
0 siblings, 2 replies; 6+ messages in thread
From: Robert Pluim @ 2022-11-10 11:15 UTC (permalink / raw)
To: emacs-devel; +Cc: Randy Taylor
>>>>> On Thu, 10 Nov 2022 06:05:04 -0500 (EST), Eli Zaretskii <eliz@gnu.org> said:
Eli> +
Eli> +(defface font-lock-bracket-face
Eli> + '((t :inherit font-lock-punctuation-face))
Eli> + "Font Lock mode face used to highlight brackets."
Eli> + :group 'font-lock-faces
Eli> + :version "29.1")
<mode=pedantic>
This applies to parens, brackets, and braces, not just brackets, so
perhaps we should mention that in the docstring?
</mode>
Robert
--
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: feature/tree-sitter e06953b02a 1/2: Add more font-lock faces (Bug#58940)
2022-11-10 11:15 ` feature/tree-sitter e06953b02a 1/2: Add more font-lock faces (Bug#58940) Robert Pluim
@ 2022-11-10 11:41 ` Eli Zaretskii
2022-11-10 11:49 ` Robert Pluim
2022-11-11 0:49 ` Randy Taylor
1 sibling, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2022-11-10 11:41 UTC (permalink / raw)
To: Robert Pluim; +Cc: emacs-devel, dev
> From: Robert Pluim <rpluim@gmail.com>
> Cc: Randy Taylor <dev@rjt.dev>
> Date: Thu, 10 Nov 2022 12:15:26 +0100
>
> >>>>> On Thu, 10 Nov 2022 06:05:04 -0500 (EST), Eli Zaretskii <eliz@gnu.org> said:
> Eli> +
> Eli> +(defface font-lock-bracket-face
> Eli> + '((t :inherit font-lock-punctuation-face))
> Eli> + "Font Lock mode face used to highlight brackets."
> Eli> + :group 'font-lock-faces
> Eli> + :version "29.1")
>
> <mode=pedantic>
> This applies to parens, brackets, and braces, not just brackets, so
> perhaps we should mention that in the docstring?
> </mode>
Feel free.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: feature/tree-sitter e06953b02a 1/2: Add more font-lock faces (Bug#58940)
2022-11-10 11:41 ` Eli Zaretskii
@ 2022-11-10 11:49 ` Robert Pluim
0 siblings, 0 replies; 6+ messages in thread
From: Robert Pluim @ 2022-11-10 11:49 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel, dev
>>>>> On Thu, 10 Nov 2022 13:41:54 +0200, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: Randy Taylor <dev@rjt.dev>
>> Date: Thu, 10 Nov 2022 12:15:26 +0100
>>
>> >>>>> On Thu, 10 Nov 2022 06:05:04 -0500 (EST), Eli Zaretskii <eliz@gnu.org> said:
Eli> +
Eli> +(defface font-lock-bracket-face
Eli> + '((t :inherit font-lock-punctuation-face))
Eli> + "Font Lock mode face used to highlight brackets."
Eli> + :group 'font-lock-faces
Eli> + :version "29.1")
>>
>> <mode=pedantic>
>> This applies to parens, brackets, and braces, not just brackets, so
>> perhaps we should mention that in the docstring?
>> </mode>
Eli> Feel free.
Done.
Robert
--
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: feature/tree-sitter e06953b02a 1/2: Add more font-lock faces (Bug#58940)
2022-11-10 11:15 ` feature/tree-sitter e06953b02a 1/2: Add more font-lock faces (Bug#58940) Robert Pluim
2022-11-10 11:41 ` Eli Zaretskii
@ 2022-11-11 0:49 ` Randy Taylor
2022-11-11 4:52 ` [External] : " Drew Adams
1 sibling, 1 reply; 6+ messages in thread
From: Randy Taylor @ 2022-11-11 0:49 UTC (permalink / raw)
To: Robert Pluim; +Cc: emacs-devel
On Thursday, November 10th, 2022 at 06:15, Robert Pluim <rpluim@gmail.com> wrote:
>
> <mode=pedantic>
>
> This applies to parens, brackets, and braces, not just brackets, so
> perhaps we should mention that in the docstring?
> </mode>
>
>
> Robert
> --
Parens and braces are types of brackets, but it certainly doesn't hurt to be more specific.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [External] : Re: feature/tree-sitter e06953b02a 1/2: Add more font-lock faces (Bug#58940)
2022-11-11 0:49 ` Randy Taylor
@ 2022-11-11 4:52 ` Drew Adams
2022-11-11 8:09 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Drew Adams @ 2022-11-11 4:52 UTC (permalink / raw)
To: Randy Taylor, Robert Pluim; +Cc: emacs-devel@gnu.org
> > This applies to parens, brackets, and braces, not just brackets, so
> > perhaps we should mention that in the docstring?
>
> Parens and braces are types of brackets, but it certainly doesn't hurt to
> be more specific.
https://english.stackexchange.com/questions/168762/brackets-vs-parenthesis
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [External] : Re: feature/tree-sitter e06953b02a 1/2: Add more font-lock faces (Bug#58940)
2022-11-11 4:52 ` [External] : " Drew Adams
@ 2022-11-11 8:09 ` Eli Zaretskii
0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2022-11-11 8:09 UTC (permalink / raw)
To: Drew Adams; +Cc: dev, rpluim, emacs-devel
> From: Drew Adams <drew.adams@oracle.com>
> CC: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
> Date: Fri, 11 Nov 2022 04:52:37 +0000
>
> > > This applies to parens, brackets, and braces, not just brackets, so
> > > perhaps we should mention that in the docstring?
> >
> > Parens and braces are types of brackets, but it certainly doesn't hurt to
> > be more specific.
>
> https://english.stackexchange.com/questions/168762/brackets-vs-parenthesis
Not necessarily relevant in our context. A more relevant description:
https://www.unicode.org/notes/tn39/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-11 8:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <166807830426.3010.6809092297480378637@vcs2.savannah.gnu.org>
[not found] ` <20221110110504.D0D7FC0E4CA@vcs2.savannah.gnu.org>
2022-11-10 11:15 ` feature/tree-sitter e06953b02a 1/2: Add more font-lock faces (Bug#58940) Robert Pluim
2022-11-10 11:41 ` Eli Zaretskii
2022-11-10 11:49 ` Robert Pluim
2022-11-11 0:49 ` Randy Taylor
2022-11-11 4:52 ` [External] : " Drew Adams
2022-11-11 8:09 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).