Re: [ELPA] New Package: phpinspect.el

[Hugo Thunnissen <devel@hugot.nl>]

On 8/12/23 06:56, Stefan Monnier wrote:
>> I would like to propose my package, phpinspect.el, to be added to GNU Elpa.
> Done.
>
> AFAICT the code has currently some significant problems in terms of
> dependencies which make its compilation fail because variables are used
> by macros during compilation when the var has not yet been defined, or
> macros are used before they're defined, etc...
>
> The patch below seems to make the compilation go through (and fixes
> various warnings), but there are a lot of compilation warnings left
> which you might want to check.  It also includes a few FIXMEs.
>
>
>          Stefan
>
>

And here I was thinking that I had fixed all of the byte compilation 
problems.. Turns out it was only working because I byte compiled 
everything within the same emacs session. I made some changes and think 
things should be in order now. At least, the following shell script 
doesn't seem to result in any errors:

for file in ./*.el; do
     cask emacs -batch -L . --eval '(setq byte-compile-error-on-warn t)' 
-f batch-byte-compile "$file" || break
done

I see some warnings in your log that concern files in the "benchmark" 
and "test" directories. These files are not required for the package to 
function. Can these be excluded from the ELPA build somehow? I have seen 
some projects use a "lisp" directory for their source code, is that the 
recommended approach for this?


Thanks,

- Hugo