From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Hugo Thunnissen Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New Package: phpinspect.el Date: Tue, 15 Aug 2023 19:45:38 +0200 Message-ID: <6c692fd7-24ba-be42-7c73-0cc950561479@hugot.nl> References: <25249bd1-bd1b-5888-b67f-718ffd0ad6ff@hugot.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26982"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 15 19:47:05 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qVy8G-0006ib-DP for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Aug 2023 19:47:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVy7N-0006jT-8F; Tue, 15 Aug 2023 13:46:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVy7A-0006cN-B3 for emacs-devel@gnu.org; Tue, 15 Aug 2023 13:46:02 -0400 Original-Received: from mailtransmit04.runbox.com ([2a0c:5a00:149::25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVy76-000630-Nx for emacs-devel@gnu.org; Tue, 15 Aug 2023 13:45:55 -0400 Original-Received: from mailtransmit02.runbox ([10.9.9.162] helo=aibo.runbox.com) by mailtransmit04.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1qVy6x-0001WD-9U; Tue, 15 Aug 2023 19:45:43 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugot.nl; s=selector2; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=hanjYLYAlmGGLhJ6woWIG2o7uFqJ8Kb0XrZ+r2UmSDg=; b=Glmg0/UZsQ7MGcv0V8L+YWMnsC ywJpTqEJ6QnumU54LFWnVy9GwJwaLRyz7lWwdTYEHjJ9enT2kFTwujQlCrI4HwC69h71BF+pY3ISM gOQp/JLnYl4zXCxUPVGRlsX6/3do34pxBYjgOxGi2lmg2Y8ruCkIhPVgURKWWWn26MbtWlweY6mmG 2Ijvg9E8R/Ru+1q+RsPB2WtE+1mDRO3uqxBqovc1o6elM2J8BQuAlQenfrZ93845aCcdDYnVN2wh7 /nE+hiqCkboY6srkPaRq7vMKiO+Xq0KxHlPSDhmsfbMyjMu26PsDT/CB8uYFKc+plKW6ksQH1lwvy g7xb9L+g==; Original-Received: from [10.9.9.73] (helo=submission02.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1qVy6w-0006FZ-OQ; Tue, 15 Aug 2023 19:45:42 +0200 Original-Received: by submission02.runbox with esmtpsa [Authenticated ID (1060096)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1qVy6u-0006wu-AO; Tue, 15 Aug 2023 19:45:40 +0200 Content-Language: en-US, nl In-Reply-To: Received-SPF: pass client-ip=2a0c:5a00:149::25; envelope-from=devel@hugot.nl; helo=mailtransmit04.runbox.com X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.045, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308769 Archived-At: On 8/12/23 06:56, Stefan Monnier wrote: >> I would like to propose my package, phpinspect.el, to be added to GNU Elpa. > Done. > > AFAICT the code has currently some significant problems in terms of > dependencies which make its compilation fail because variables are used > by macros during compilation when the var has not yet been defined, or > macros are used before they're defined, etc... > > The patch below seems to make the compilation go through (and fixes > various warnings), but there are a lot of compilation warnings left > which you might want to check. It also includes a few FIXMEs. > > > Stefan > > And here I was thinking that I had fixed all of the byte compilation problems.. Turns out it was only working because I byte compiled everything within the same emacs session. I made some changes and think things should be in order now. At least, the following shell script doesn't seem to result in any errors: for file in ./*.el; do     cask emacs -batch -L . --eval '(setq byte-compile-error-on-warn t)' -f batch-byte-compile "$file" || break done I see some warnings in your log that concern files in the "benchmark" and "test" directories. These files are not required for the package to function. Can these be excluded from the ELPA build somehow? I have seen some projects use a "lisp" directory for their source code, is that the recommended approach for this? Thanks, - Hugo