Re: master aea9365 3/3: * lisp/gnus/gnus-search.el (gnus-search-contact-tables): Fix type.

Re: master aea9365 3/3: * lisp/gnus/gnus-search.el (gnus-search-contact-tables): Fix type.

[Eric Abrahamsen]

Mattias Engdegård <mattiase@savannah.gnu.org> writes:

> branch: master
> commit aea936562b033899f0b7160cc492bbea1006863b
> Author: Mattias Engdegård <mattiase@acm.org>
> Commit: Mattias Engdegård <mattiase@acm.org>
>
>     * lisp/gnus/gnus-search.el (gnus-search-contact-tables): Fix type.
>     
>     A more precise type is desirable but at it is now correct ('list' is not).
> ---
>  lisp/gnus/gnus-search.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/gnus/gnus-search.el b/lisp/gnus/gnus-search.el
> index 15d96e3..7ee7c53 100644
> --- a/lisp/gnus/gnus-search.el
> +++ b/lisp/gnus/gnus-search.el
> @@ -410,7 +410,7 @@ returned by `completion-at-point-functions'.  That usually means
>  a list of strings, a hash table, or an alist."
>    :group 'gnus-search
>    :version "28.1"
> -  :type 'list)
> +  :type '(repeat sexp))

Doesn't this type demand a list of lists? It could also be a list of
hashtables, or functions, or a mix of alist/list/function/hashtable...

Re: master aea9365 3/3: * lisp/gnus/gnus-search.el (gnus-search-contact-tables): Fix type.

[Mattias Engdegård]

6 nov. 2020 kl. 18.17 skrev Eric Abrahamsen <eric@ericabrahamsen.net>:

>> -  :type 'list)
>> +  :type '(repeat sexp))
> 
> Doesn't this type demand a list of lists? It could also be a list of
> hashtables, or functions, or a mix of alist/list/function/hashtable...

'sexp' means any Lisp type, thus (repeat sexp) is any list.
You may want to replace it with a smaller (more precise) type.

Re: master aea9365 3/3: * lisp/gnus/gnus-search.el (gnus-search-contact-tables): Fix type.

[Basil L. Contovounesios]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Mattias Engdegård <mattiase@savannah.gnu.org> writes:
>
>> branch: master
>> commit aea936562b033899f0b7160cc492bbea1006863b
>> Author: Mattias Engdegård <mattiase@acm.org>
>> Commit: Mattias Engdegård <mattiase@acm.org>
>>
>>     * lisp/gnus/gnus-search.el (gnus-search-contact-tables): Fix type.
>>     
>>     A more precise type is desirable but at it is now correct ('list' is not).
>> ---
>>  lisp/gnus/gnus-search.el | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lisp/gnus/gnus-search.el b/lisp/gnus/gnus-search.el
>> index 15d96e3..7ee7c53 100644
>> --- a/lisp/gnus/gnus-search.el
>> +++ b/lisp/gnus/gnus-search.el
>> @@ -410,7 +410,7 @@ returned by `completion-at-point-functions'.  That usually means
>>  a list of strings, a hash table, or an alist."
>>    :group 'gnus-search
>>    :version "28.1"
>> -  :type 'list)
>> +  :type '(repeat sexp))
>
> Doesn't this type demand a list of lists? It could also be a list of
> hashtables, or functions, or a mix of alist/list/function/hashtable...

A sexp in this context is "any Lisp object that can be printed and read
back".  That covers most completion table types, right?  AFAICT the only
type more general than that is restricted-sexp.

-- 
Basil

Re: master aea9365 3/3: * lisp/gnus/gnus-search.el (gnus-search-contact-tables): Fix type.

[Eric Abrahamsen]

On November 6, 2020 1:33:33 PM PST, "Basil L. Contovounesios" <contovob@tcd.ie> wrote:
>Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Mattias Engdegård <mattiase@savannah.gnu.org> writes:
>>
>>> branch: master
>>> commit aea936562b033899f0b7160cc492bbea1006863b
>>> Author: Mattias Engdegård <mattiase@acm.org>
>>> Commit: Mattias Engdegård <mattiase@acm.org>
>>>
>>>     * lisp/gnus/gnus-search.el (gnus-search-contact-tables): Fix
>type.
>>>     
>>>     A more precise type is desirable but at it is now correct
>('list' is not).
>>> ---
>>>  lisp/gnus/gnus-search.el | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/lisp/gnus/gnus-search.el b/lisp/gnus/gnus-search.el
>>> index 15d96e3..7ee7c53 100644
>>> --- a/lisp/gnus/gnus-search.el
>>> +++ b/lisp/gnus/gnus-search.el
>>> @@ -410,7 +410,7 @@ returned by `completion-at-point-functions'. 
>That usually means
>>>  a list of strings, a hash table, or an alist."
>>>    :group 'gnus-search
>>>    :version "28.1"
>>> -  :type 'list)
>>> +  :type '(repeat sexp))
>>
>> Doesn't this type demand a list of lists? It could also be a list of
>> hashtables, or functions, or a mix of
>alist/list/function/hashtable...
>
>A sexp in this context is "any Lisp object that can be printed and read
>back".  That covers most completion table types, right?  AFAICT the
>only
>type more general than that is restricted-sexp.

Oh, I didn't realize that was the definition of a sexp. For some reason I thought it was more or less equivalent to list. Carry on!

Thanks, 
Eric

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Re: master aea9365 3/3: * lisp/gnus/gnus-search.el (gnus-search-contact-tables): Fix type.

[Eric Abrahamsen]

Mattias Engdegård <mattiase@acm.org> writes:

> 6 nov. 2020 kl. 18.17 skrev Eric Abrahamsen <eric@ericabrahamsen.net>:
>
>>> -  :type 'list)
>>> +  :type '(repeat sexp))
>> 
>> Doesn't this type demand a list of lists? It could also be a list of
>> hashtables, or functions, or a mix of alist/list/function/hashtable...
>
> 'sexp' means any Lisp type, thus (repeat sexp) is any list.
> You may want to replace it with a smaller (more precise) type.

Thanks! I think I will do that.