unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Adrian Robert <adrian.b.robert@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Chong Yidong <cyd@stupidchicken.com>,
	emacs-devel@gnu.org, Jason Rumney <jasonr@gnu.org>
Subject: Re: Pretest next week
Date: Wed, 28 Jan 2009 18:24:00 +0200	[thread overview]
Message-ID: <6634D95E-39A0-410C-8F28-065D997D5208@gmail.com> (raw)
In-Reply-To: <jwvk58fo77x.fsf-monnier+emacs@gnu.org>


On Jan 28, 2009, at 4:08 PM, Stefan Monnier wrote:

>> might be simpler if there's any way to get the  conventional  
>> keyboard.c
>> timer-driven input polling done through the  QUIT macro under NS.
>
> There is no such thing as a timer-driven polling in the QUIT macro.
> The polling done via the QUIT macro is "polling for some C var to
> change", not "polling for some external thingy".

Right.  The polling I meant was running poll_for_input() in  
keyboard.c in response to the atimer 'poll_timer' firing, if running  
in polling mode (Fset_input_interrupt_mode(Qnil)).  I wasn't sure if  
atimers just weren't supposed to be called while tight loops are  
running, or if some code just wasn't working as expected under NS.   
My initial thought was to add something like

   do_pending_atimers();

to QUIT under HAVE_NS.

As it turns out, this isn't needed.  SIGALRM is triggering  
alarm_signal_handler() in atimer.c correctly, but run_timers() never  
gets called under SYNC_INPUT.  I don't fully understand why or where  
the problem is here.  But undefining SYNC_INPUT gets poll_for_input()  
called (and hence Ctrl-g detected) even in tight loops, with no ill  
effects so far.  Patch below.

It would be of interest to find out why it fails under the SYNC_INPUT  
case...

I also investigated the SIGIO thing a bit more.  I can trigger the  
handler using kill -IO from the command line.  But no SIGIO seems to  
be being sent to the process when keyboard input is given.


-Adrian



*** configure.in.~1.583.~	Thu Jan 22 15:08:19 2009
--- configure.in	Wed Jan 28 17:47:55 2009
***************
*** 2096,2101 ****
--- 2096,2103 ----
     fi
     # We also have mouse menus.
     HAVE_MENUS=yes
+   # SYNC_INPUT prevents Ctrl-g detection in many cases.
+   AC_DEFINE(SYNC_INPUT, 0, [Process async input synchronously.])
   fi


*** nsterm.m.~1.53.~	Sun Jan 25 21:23:24 2009
--- nsterm.m	Wed Jan 28 17:19:50 2009
***************
*** 3746,3752 ****
       
------------------------------------------------------------------------ 
-- */
   {
     baud_rate = 38400;
!   Fset_input_interrupt_mode (Qt);
   }


--- 3763,3769 ----
       
------------------------------------------------------------------------ 
-- */
   {
     baud_rate = 38400;
!   Fset_input_interrupt_mode (Qnil);
   }


***************





  reply	other threads:[~2009-01-28 16:24 UTC|newest]

Thread overview: 125+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-22  5:03 Pretest next week Chong Yidong
2009-01-22  5:11 ` YAMAMOTO Mitsuharu
2009-01-22 13:49   ` Chong Yidong
2009-01-22 14:23     ` Adrian Robert
2009-01-22 14:37       ` Adrian Robert
2009-01-22 15:12         ` Juanma Barranquero
2009-01-22 19:33       ` Stefan Monnier
2009-01-24  8:43         ` Adrian Robert
2009-01-25 11:58           ` Adrian Robert
2009-01-23  0:03       ` YAMAMOTO Mitsuharu
2009-01-26 15:45       ` Adrian Robert
2009-01-26 22:07         ` Chong Yidong
2009-01-26 23:08           ` Adrian Robert
2009-01-27  2:10         ` Jason Rumney
2009-01-27 13:02           ` Adrian Robert
2009-01-28  4:22             ` Chong Yidong
2009-01-28  9:34               ` Jason Rumney
2009-01-28 12:19                 ` Adrian Robert
2009-01-28 14:08                   ` Stefan Monnier
2009-01-28 16:24                     ` Adrian Robert [this message]
2009-01-28 17:40                       ` Stefan Monnier
2009-01-28 19:25                         ` Adrian Robert
2009-01-29  2:11                           ` Stefan Monnier
2009-01-28 20:52                         ` Chong Yidong
2009-01-29  2:12                           ` Stefan Monnier
2009-01-22 14:44   ` Stefan Monnier
2009-01-23  0:16     ` YAMAMOTO Mitsuharu
2009-01-24  8:51       ` Adrian Robert
2009-01-26  4:46         ` YAMAMOTO Mitsuharu
2009-01-26 20:07           ` Chong Yidong
2009-01-26 23:24             ` YAMAMOTO Mitsuharu
2009-01-27 13:04               ` Adrian Robert
2009-01-28  0:16                 ` YAMAMOTO Mitsuharu
2009-01-26 22:36           ` Eli Zaretskii
2009-01-26 23:27             ` YAMAMOTO Mitsuharu
2009-01-27  3:28               ` Eli Zaretskii
2009-01-28  0:10                 ` YAMAMOTO Mitsuharu
2009-01-27 12:57               ` Adrian Robert
2009-01-29  0:58                 ` YAMAMOTO Mitsuharu
2009-01-24 11:17   ` Alex Ott
2009-01-22 10:56 ` Bastien
2009-01-22 17:24   ` Bastien
2009-01-22 20:59     ` Stefan Monnier
2009-01-22 21:41     ` Glenn Morris
2009-01-23 10:41       ` Bastien
2009-01-23 17:46         ` Glenn Morris
2009-01-25 18:54           ` Bastien
2009-01-25 20:01             ` David Kastrup
2009-01-25 21:28               ` Lennart Borgman
2009-01-26  8:38                 ` Frank Schmitt
2009-01-26 14:20               ` Stefan Monnier
2009-01-22 17:42 ` merging pmail [was Re: Pretest next week] Glenn Morris
2009-01-22 18:12   ` merging pmail Glenn Morris
2009-01-22 20:04     ` Glenn Morris
2009-01-23  2:41       ` Miles Bader
2009-01-23  4:06         ` Glenn Morris
2009-01-23  4:49           ` Miles Bader
2009-01-23  4:59             ` Glenn Morris
2009-01-23 10:37             ` Bastien
2009-01-23 10:40       ` Bastien
2009-01-23 17:52         ` Glenn Morris
2009-01-26  0:00           ` Bastien
2009-01-23 15:01       ` David Engster
2009-02-05  6:37         ` Glenn Morris
2009-02-20 13:30           ` David Engster
2009-01-24  3:38       ` Glenn Morris
2009-01-23  4:30   ` Chong Yidong
2009-01-23  4:35     ` Glenn Morris
2009-01-29 15:29 ` Pretest next week Chong Yidong
2009-01-30  0:51   ` YAMAMOTO Mitsuharu
2009-01-30  1:42     ` Chong Yidong
2009-01-30  1:46       ` YAMAMOTO Mitsuharu
2009-02-01  7:47         ` YAMAMOTO Mitsuharu
2009-02-01 14:34           ` Chong Yidong
2009-02-02  4:59             ` YAMAMOTO Mitsuharu
2009-02-03  1:42               ` Richard M Stallman
2009-02-03  1:56                 ` YAMAMOTO Mitsuharu
2009-02-04  7:04                   ` Richard M Stallman
2009-02-04  8:13                     ` YAMAMOTO Mitsuharu
2009-02-04 12:16                       ` Adrian Robert
2009-07-14  3:32             ` YAMAMOTO Mitsuharu
2009-07-14 18:40               ` Stefan Monnier
2009-07-15  2:22                 ` YAMAMOTO Mitsuharu
2009-07-15 10:40                 ` David Reitter
2009-07-15 14:33                   ` Chong Yidong
2009-02-01 22:17           ` Stefan Monnier
2009-02-03  0:53             ` YAMAMOTO Mitsuharu
2009-02-04 12:08               ` Adrian Robert
2009-02-05  0:08                 ` YAMAMOTO Mitsuharu
2009-02-05  5:40                 ` Richard M Stallman
2009-02-05 11:43                   ` YAMAMOTO Mitsuharu
2009-02-05 17:39                     ` Adrian Robert
2009-02-06  1:10                       ` YAMAMOTO Mitsuharu
2009-01-31  6:44       ` Richard M Stallman
2009-01-31  7:35         ` YAMAMOTO Mitsuharu
2009-03-05  0:56           ` YAMAMOTO Mitsuharu
2009-03-05  5:24             ` YAMAMOTO Mitsuharu
2009-01-30  9:44   ` Eli Zaretskii
2009-01-30  9:56     ` Tassilo Horn
2009-01-30 11:19       ` Kenichi Handa
2009-01-30 12:34         ` Tassilo Horn
2009-01-30 12:52           ` Kenichi Handa
2009-01-30 13:39             ` Tassilo Horn
2009-01-31  1:20               ` Kenichi Handa
2009-01-31 11:07                 ` Tassilo Horn
2009-01-30 11:14     ` Kenichi Handa
2009-01-30 11:20       ` Eli Zaretskii
2009-02-04  2:49       ` Kenichi Handa
2009-02-06 15:49         ` Eli Zaretskii
2009-02-10  0:44           ` Kenichi Handa
2009-01-30 17:43     ` Glenn Morris
  -- strict thread matches above, loose matches on Subject: below --
2009-01-24 20:27 Stefan Monnier
2009-01-27  0:42 Stefan Monnier
2009-01-29  3:39 Chetan Pandya
2009-03-05 17:15 Adrian Robert
2009-03-06  1:01 ` YAMAMOTO Mitsuharu
2009-03-07  0:48   ` YAMAMOTO Mitsuharu
2009-03-07 13:28     ` Adrian Robert
2009-03-08  1:24       ` YAMAMOTO Mitsuharu
2009-03-08  3:10       ` Stefan Monnier
2009-05-15  2:31 Chong Yidong
2009-05-20 23:39 Chong Yidong
2009-05-23  4:45 ` Chong Yidong
2009-05-23 10:55   ` Lennart Borgman
2012-11-17  8:17 Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6634D95E-39A0-410C-8F28-065D997D5208@gmail.com \
    --to=adrian.b.robert@gmail.com \
    --cc=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=jasonr@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).