unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Adrian Robert <adrian.b.robert@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: Pretest next week
Date: Sat, 24 Jan 2009 10:43:33 +0200	[thread overview]
Message-ID: <6362553F-3B8F-4A06-83B5-F59ED69DA70E@gmail.com> (raw)
In-Reply-To: <jwvzlhji9yv.fsf-monnier+emacs@gnu.org>


On Jan 22, 2009, at 9:33 PM, Stefan Monnier wrote:

>> 1) Complete removal of all Feval() calls in bad places as  
>> discussed earlier
>> on this list.  A quick check reveals four places, relating  to: emacs
>> termination, deadkey input handling, toolbar toggle, and   
>> preferences-help.
>
>> - Mostly straightforward (but taking some time) by using custom
>> nonascii-keystroke' events,
>
> Sound right.
>
>> except for the case of input-method handling when in isearch mode,
>> where passing such an event breaks out of the isearch entry; I could
>> use some help on this.
>
> Most likely those events should not be handled by the global-map, but
> instead either directly by the C code (e.g. in  
> kbd_buffer_get_event), or
> via special-event-map, or via input-decode-map.

I tried using special-event-map, following the example of delete- 
frame, but I still get a "Wrong type argument: commandp, ns-echo- 
working-text"  message.  I'm trying to get ns-echo-working-text  
called non-interactively so it can make some text changes in the echo  
area.  Is there any way to do this?

(See ns-win.el for defn of ns-echo-working-text.)


Index: keyboard.c
===================================================================
RCS file: /sources/emacs/emacs/src/keyboard.c,v
retrieving revision 1.990
diff -u -p -r1.990 keyboard.c
--- keyboard.c  12 Jan 2009 09:21:19 -0000      1.990
+++ keyboard.c  24 Jan 2009 08:36:25 -0000
@@ -477,6 +477,9 @@ Lisp_Object Qsave_session;
  #ifdef HAVE_DBUS
  Lisp_Object Qdbus_event;
  #endif
+#ifdef HAVE_NS
+Lisp_Object Qns_echo_working_text;
+#endif
  /* Lisp_Object Qmouse_movement; - also an event header */

  /* Properties of event headers.  */
@@ -4113,6 +4116,14 @@ kbd_buffer_get_event (kbp, used_mouse_me
  #endif
         }

+#if defined (HAVE_NS)
+      else if (event->kind == NS_TEXT_EVENT)
+        {
+         obj = Fcons (intern ("ns-echo-working-text"), Qnil);
+         kbd_fetch_ptr = event + 1;
+        }
+#endif
+
  #if defined (HAVE_X11) || defined (HAVE_NTGUI) \
      || defined (HAVE_NS)
        else if (event->kind == DELETE_WINDOW_EVENT)
@@ -11596,6 +11607,9 @@ struct event_head head_table[] = {
    {&Qdelete_frame,        "delete-frame",        &Qdelete_frame},
    {&Qiconify_frame,       "iconify-frame",       &Qiconify_frame},
    {&Qmake_frame_visible,  "make-frame-visible",   
&Qmake_frame_visible},
+#ifdef HAVE_NS
+  {&Qns_echo_working_text,"ns-echo-working- 
text",&Qns_echo_working_text},
+#endif
    /* `select-window' should be handled just like `switch-frame'
       in read_key_sequence.  */
    {&Qselect_window,       "select-window",       &Qswitch_frame}
@@ -11682,6 +11696,11 @@ syms_of_keyboard ()
    staticpro (&Qdbus_event);
  #endif

+#ifdef HAVE_NS
+  Qns_echo_working_text = intern("ns-echo-working-text");
+  staticpro (&Qns_echo_working_text);
+#endif
+
    Qmenu_enable = intern ("menu-enable");
    staticpro (&Qmenu_enable);
    Qmenu_alias = intern ("menu-alias");
@@ -12382,6 +12401,8 @@ keys_of_keyboard ()

    initial_define_lispy_key (Vspecial_event_map, "delete-frame",
                             "handle-delete-frame");
+  initial_define_lispy_key (Vspecial_event_map, "ns-echo-working-text",
+                           "ns-echo-working-text");
    /* Here we used to use `ignore-event' which would simple set  
prefix-arg to
       current-prefix-arg, as is done in `handle-switch-frame'.
       But `handle-switch-frame is not run from the special-map.






  reply	other threads:[~2009-01-24  8:43 UTC|newest]

Thread overview: 125+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-22  5:03 Pretest next week Chong Yidong
2009-01-22  5:11 ` YAMAMOTO Mitsuharu
2009-01-22 13:49   ` Chong Yidong
2009-01-22 14:23     ` Adrian Robert
2009-01-22 14:37       ` Adrian Robert
2009-01-22 15:12         ` Juanma Barranquero
2009-01-22 19:33       ` Stefan Monnier
2009-01-24  8:43         ` Adrian Robert [this message]
2009-01-25 11:58           ` Adrian Robert
2009-01-23  0:03       ` YAMAMOTO Mitsuharu
2009-01-26 15:45       ` Adrian Robert
2009-01-26 22:07         ` Chong Yidong
2009-01-26 23:08           ` Adrian Robert
2009-01-27  2:10         ` Jason Rumney
2009-01-27 13:02           ` Adrian Robert
2009-01-28  4:22             ` Chong Yidong
2009-01-28  9:34               ` Jason Rumney
2009-01-28 12:19                 ` Adrian Robert
2009-01-28 14:08                   ` Stefan Monnier
2009-01-28 16:24                     ` Adrian Robert
2009-01-28 17:40                       ` Stefan Monnier
2009-01-28 19:25                         ` Adrian Robert
2009-01-29  2:11                           ` Stefan Monnier
2009-01-28 20:52                         ` Chong Yidong
2009-01-29  2:12                           ` Stefan Monnier
2009-01-22 14:44   ` Stefan Monnier
2009-01-23  0:16     ` YAMAMOTO Mitsuharu
2009-01-24  8:51       ` Adrian Robert
2009-01-26  4:46         ` YAMAMOTO Mitsuharu
2009-01-26 20:07           ` Chong Yidong
2009-01-26 23:24             ` YAMAMOTO Mitsuharu
2009-01-27 13:04               ` Adrian Robert
2009-01-28  0:16                 ` YAMAMOTO Mitsuharu
2009-01-26 22:36           ` Eli Zaretskii
2009-01-26 23:27             ` YAMAMOTO Mitsuharu
2009-01-27  3:28               ` Eli Zaretskii
2009-01-28  0:10                 ` YAMAMOTO Mitsuharu
2009-01-27 12:57               ` Adrian Robert
2009-01-29  0:58                 ` YAMAMOTO Mitsuharu
2009-01-24 11:17   ` Alex Ott
2009-01-22 10:56 ` Bastien
2009-01-22 17:24   ` Bastien
2009-01-22 20:59     ` Stefan Monnier
2009-01-22 21:41     ` Glenn Morris
2009-01-23 10:41       ` Bastien
2009-01-23 17:46         ` Glenn Morris
2009-01-25 18:54           ` Bastien
2009-01-25 20:01             ` David Kastrup
2009-01-25 21:28               ` Lennart Borgman
2009-01-26  8:38                 ` Frank Schmitt
2009-01-26 14:20               ` Stefan Monnier
2009-01-22 17:42 ` merging pmail [was Re: Pretest next week] Glenn Morris
2009-01-22 18:12   ` merging pmail Glenn Morris
2009-01-22 20:04     ` Glenn Morris
2009-01-23  2:41       ` Miles Bader
2009-01-23  4:06         ` Glenn Morris
2009-01-23  4:49           ` Miles Bader
2009-01-23  4:59             ` Glenn Morris
2009-01-23 10:37             ` Bastien
2009-01-23 10:40       ` Bastien
2009-01-23 17:52         ` Glenn Morris
2009-01-26  0:00           ` Bastien
2009-01-23 15:01       ` David Engster
2009-02-05  6:37         ` Glenn Morris
2009-02-20 13:30           ` David Engster
2009-01-24  3:38       ` Glenn Morris
2009-01-23  4:30   ` Chong Yidong
2009-01-23  4:35     ` Glenn Morris
2009-01-29 15:29 ` Pretest next week Chong Yidong
2009-01-30  0:51   ` YAMAMOTO Mitsuharu
2009-01-30  1:42     ` Chong Yidong
2009-01-30  1:46       ` YAMAMOTO Mitsuharu
2009-02-01  7:47         ` YAMAMOTO Mitsuharu
2009-02-01 14:34           ` Chong Yidong
2009-02-02  4:59             ` YAMAMOTO Mitsuharu
2009-02-03  1:42               ` Richard M Stallman
2009-02-03  1:56                 ` YAMAMOTO Mitsuharu
2009-02-04  7:04                   ` Richard M Stallman
2009-02-04  8:13                     ` YAMAMOTO Mitsuharu
2009-02-04 12:16                       ` Adrian Robert
2009-07-14  3:32             ` YAMAMOTO Mitsuharu
2009-07-14 18:40               ` Stefan Monnier
2009-07-15  2:22                 ` YAMAMOTO Mitsuharu
2009-07-15 10:40                 ` David Reitter
2009-07-15 14:33                   ` Chong Yidong
2009-02-01 22:17           ` Stefan Monnier
2009-02-03  0:53             ` YAMAMOTO Mitsuharu
2009-02-04 12:08               ` Adrian Robert
2009-02-05  0:08                 ` YAMAMOTO Mitsuharu
2009-02-05  5:40                 ` Richard M Stallman
2009-02-05 11:43                   ` YAMAMOTO Mitsuharu
2009-02-05 17:39                     ` Adrian Robert
2009-02-06  1:10                       ` YAMAMOTO Mitsuharu
2009-01-31  6:44       ` Richard M Stallman
2009-01-31  7:35         ` YAMAMOTO Mitsuharu
2009-03-05  0:56           ` YAMAMOTO Mitsuharu
2009-03-05  5:24             ` YAMAMOTO Mitsuharu
2009-01-30  9:44   ` Eli Zaretskii
2009-01-30  9:56     ` Tassilo Horn
2009-01-30 11:19       ` Kenichi Handa
2009-01-30 12:34         ` Tassilo Horn
2009-01-30 12:52           ` Kenichi Handa
2009-01-30 13:39             ` Tassilo Horn
2009-01-31  1:20               ` Kenichi Handa
2009-01-31 11:07                 ` Tassilo Horn
2009-01-30 11:14     ` Kenichi Handa
2009-01-30 11:20       ` Eli Zaretskii
2009-02-04  2:49       ` Kenichi Handa
2009-02-06 15:49         ` Eli Zaretskii
2009-02-10  0:44           ` Kenichi Handa
2009-01-30 17:43     ` Glenn Morris
  -- strict thread matches above, loose matches on Subject: below --
2009-01-24 20:27 Stefan Monnier
2009-01-27  0:42 Stefan Monnier
2009-01-29  3:39 Chetan Pandya
2009-03-05 17:15 Adrian Robert
2009-03-06  1:01 ` YAMAMOTO Mitsuharu
2009-03-07  0:48   ` YAMAMOTO Mitsuharu
2009-03-07 13:28     ` Adrian Robert
2009-03-08  1:24       ` YAMAMOTO Mitsuharu
2009-03-08  3:10       ` Stefan Monnier
2009-05-15  2:31 Chong Yidong
2009-05-20 23:39 Chong Yidong
2009-05-23  4:45 ` Chong Yidong
2009-05-23 10:55   ` Lennart Borgman
2012-11-17  8:17 Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6362553F-3B8F-4A06-83B5-F59ED69DA70E@gmail.com \
    --to=adrian.b.robert@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).