Recent changes to easy-menu.el breaks "printing.el".

Recent changes to easy-menu.el breaks "printing.el".

[Kim F. Storm]

I've been using Vinicius Jose Latorre's excellent "printing"
package without a glitch -- until recently.

The printing package does some pretty obscure things to setup
its Printing entry on the Tools menu, and it no longer works
for me.

I traces the problem to a recent change to easy-menu where
strings are now downcased before they are interned.

Since printing.el does not expect this, it fails.

I've fixed it in printing.el with the following small modification.
I'm using version 2.1 which may be out-dated, but I'm unable to find
anything newer.

*** printing.el~	Tue May 23 09:33:13 2000
--- printing.el	Fri May  3 12:28:09 2002
***************
*** 2740,2746 ****
  
  (defun pr-menu-get-item (name-list)
    ;; NAME-LIST is a string or a list of strings.
!   (let ((ipath [menu-bar tools Printing])
  	(len   (and (listp name-list) (length name-list))))
      (and len
  	 (cond ((= len 0) (setq name-list "nil"))
--- 2740,2746 ----
  
  (defun pr-menu-get-item (name-list)
    ;; NAME-LIST is a string or a list of strings.
!   (let ((ipath (vector 'menu-bar 'tools (pr-get-symbol "Printing")))
  	(len   (and (listp name-list) (length name-list))))
      (and len
  	 (cond ((= len 0) (setq name-list "nil"))
***************
*** 2767,2772 ****
--- 2767,2775 ----
  
  
  (defun pr-get-symbol (name)
+   ;; Recent versions of easy-menu downcase names before interning them.
+   (if (fboundp 'easy-menu-name-match)
+       (setq name (downcase name)))
    (or (intern-soft name)
        (make-symbol name)))
  

-- 
Kim F. Storm  <storm@cua.dk>

Re: Recent changes to easy-menu.el breaks "printing.el".

[Richard Stallman]

Would you please install that change?

    !   (let ((ipath (vector 'menu-bar 'tools (pr-get-symbol "Printing")))

However, [menu-bar tools printing] would be cleaner than
calling functions to create that list.

Re: Recent changes to easy-menu.el breaks "printing.el".

[Eli Zaretskii]

> From: storm@cua.dk (Kim F. Storm)
> Date: 04 May 2002 20:49:50 +0200
> 
> I don't think "printing.el" is included with emacs?
> 
> I definitely think it should be....  

I agree.  IIRC, the author submitted it some time ago, and got a few
comments.  Somehow, there was no followups.

Vinicius, is there anything we can do to help you with including
printing.el in the EMacs distribution?

Re: Recent changes to easy-menu.el breaks "printing.el".

[Kim F. Storm]

Richard Stallman <rms@gnu.org> writes:

> Would you please install that change?
> 
>     !   (let ((ipath (vector 'menu-bar 'tools (pr-get-symbol "Printing")))
> 
> However, [menu-bar tools printing] would be cleaner than
> calling functions to create that list.

I don't think "printing.el" is included with emacs?

I definitely think it should be....  

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Recent changes to easy-menu.el breaks "printing.el".

[Kim F. Storm]

"Eli Zaretskii" <eliz@is.elta.co.il> writes:

> > From: storm@cua.dk (Kim F. Storm)
> > Date: 04 May 2002 20:49:50 +0200
> > 
> > I don't think "printing.el" is included with emacs?
> > 
> > I definitely think it should be....  
> 
> I agree.  IIRC, the author submitted it some time ago, and got a few
> comments.  Somehow, there was no followups.
> 
> Vinicius, is there anything we can do to help you with including
> printing.el in the EMacs distribution?

Did you get a response from Vinicius ?

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Recent changes to easy-menu.el breaks "printing.el".

[Eli Zaretskii]

> From: storm@cua.dk
> Date: 24 May 2002 00:35:56 +0200
> 
> "Eli Zaretskii" <eliz@is.elta.co.il> writes:
> 
> > Vinicius, is there anything we can do to help you with including
> > printing.el in the EMacs distribution?
> 
> Did you get a response from Vinicius ?

No, I did not.

Re: Recent changes to easy-menu.el breaks "printing.el".

[Richard Stallman]

If Vinicius doesn't respond in another week, could people
try their best to go ahead without his help?  If he thinks
we did something wrong, he can correct it later.

Re: Recent changes to easy-menu.el breaks "printing.el".

[Kim F. Storm]

Richard Stallman <rms@gnu.org> writes:

> If Vinicius doesn't respond in another week, could people
> try their best to go ahead without his help?  If he thinks
> we did something wrong, he can correct it later.

The problem is that we want to add printing.el by Vinicius to emacs.

I don't know if he has signed papers for it.  If he has, there is
no problem (I already made a fix for using printing.el with 21.4).

If he hasn't signed papers, we need to get in contact with him
to proceed.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Recent changes to easy-menu.el breaks "printing.el".

[Richard Stallman]

    > If Vinicius doesn't respond in another week, could people
    > try their best to go ahead without his help?  If he thinks
    > we did something wrong, he can correct it later.

    The problem is that we want to add printing.el by Vinicius to emacs.

    I don't know if he has signed papers for it.

He has not.  Thanks for reminding me to check.