unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: storm@cua.dk (Kim F. Storm)
Cc: emacs-devel@gnu.org
Subject: Re: risky-local-variable-p called with 1 argument
Date: 25 Oct 2002 11:41:37 +0200	[thread overview]
Message-ID: <5xhefayhwu.fsf@kfs2.cua.dk> (raw)
In-Reply-To: <20021025090851.D41A.LEKTU@terra.es>

Juanma Barranquero <lektu@terra.es> writes:

> After a recent change to `risky-local-variable-p', compiling
> emacs-lisp/usafep.el gives:
> 

That change is not recorded in the lisp/ChangeLog, but I found this in
the CVS log for lisp/files.el:

revision 1.619
date: 2002/10/23 17:38:44;  author: rms;  state: Exp;  lines: +16 -11
(risky-local-variable-p): New function.
(compile-command): Use `stringp' for `safe-local-variable' prop.
(hack-one-local-variable): Use `risky-local-variable-p'.


However, that log message is mis-leading, as the change doesn't define
a new function risky-local-variable-p, but rather adds a second
mandatory VAL argument to it.

I suppose the proper log message would have been:

(risky-local-variable-p): New VAL arg.  Callers NOT changed.

And of course, the last part of that message should have rung a bell :-)



> > In unsafep-variable:
> > unsafep.el:253:6:Warning: risky-local-variable-p called with 1 argument, but
> >     requires 2
> 

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

  reply	other threads:[~2002-10-25  9:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-25  7:10 risky-local-variable-p called with 1 argument Juanma Barranquero
2002-10-25  9:41 ` Kim F. Storm [this message]
2002-10-25  8:57   ` Juanma Barranquero
2002-10-25 10:08     ` Kim F. Storm
2002-10-26 20:15 ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5xhefayhwu.fsf@kfs2.cua.dk \
    --to=storm@cua.dk \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).