From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: risky-local-variable-p called with 1 argument Date: 25 Oct 2002 11:41:37 +0200 Sender: emacs-devel-admin@gnu.org Message-ID: <5xhefayhwu.fsf@kfs2.cua.dk> References: <20021025090851.D41A.LEKTU@terra.es> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1035535307 25784 80.91.224.249 (25 Oct 2002 08:41:47 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 25 Oct 2002 08:41:47 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18502L-0006hi-00 for ; Fri, 25 Oct 2002 10:41:45 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18504v-0005ra-00 for ; Fri, 25 Oct 2002 10:44:26 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 18502q-0002el-00; Fri, 25 Oct 2002 04:42:16 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 185028-0001VD-00 for emacs-devel@gnu.org; Fri, 25 Oct 2002 04:41:32 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 185026-0001V2-00 for emacs-devel@gnu.org; Fri, 25 Oct 2002 04:41:31 -0400 Original-Received: from mail.filanet.dk ([195.215.206.179]) by monty-python.gnu.org with esmtp (Exim 4.10) id 185025-0001Uo-00 for emacs-devel@gnu.org; Fri, 25 Oct 2002 04:41:29 -0400 Original-Received: from kfs2.cua.dk.cua.dk (kfs2.local.filanet.dk [192.168.1.182]) by mail.filanet.dk (Postfix) with SMTP id CC2007C017; Fri, 25 Oct 2002 08:41:28 +0000 (GMT) Original-To: Juanma Barranquero In-Reply-To: <20021025090851.D41A.LEKTU@terra.es> Original-Lines: 35 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:8777 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:8777 Juanma Barranquero writes: > After a recent change to `risky-local-variable-p', compiling > emacs-lisp/usafep.el gives: > That change is not recorded in the lisp/ChangeLog, but I found this in the CVS log for lisp/files.el: revision 1.619 date: 2002/10/23 17:38:44; author: rms; state: Exp; lines: +16 -11 (risky-local-variable-p): New function. (compile-command): Use `stringp' for `safe-local-variable' prop. (hack-one-local-variable): Use `risky-local-variable-p'. However, that log message is mis-leading, as the change doesn't define a new function risky-local-variable-p, but rather adds a second mandatory VAL argument to it. I suppose the proper log message would have been: (risky-local-variable-p): New VAL arg. Callers NOT changed. And of course, the last part of that message should have rung a bell :-) > > In unsafep-variable: > > unsafep.el:253:6:Warning: risky-local-variable-p called with 1 argument, but > > requires 2 > -- Kim F. Storm http://www.cua.dk