read-file-name argument clash with xemacs

read-file-name argument clash with xemacs

[Noah Friedman]

XEmacs's 6th argument to read-file-name is a history list variable.
In the Emacs development sources, it's a predicate.

This is a somewhat nasty situation because functions which currently
inspect the argument list or use a condition-case to trap
wrong-number-of-arguments, are suddenly failing.

So I suggest adding the history variable support to Emacs and moving the
predicate out to the 7th argument.  Any objections?

Re: read-file-name argument clash with xemacs

[Richard Stallman]

    So I suggest adding the history variable support to Emacs and moving the
    predicate out to the 7th argument.

Ok.  The predicate arg feature was added since the last release so
there is no problem in changing it now.  Would you like to do this?

Please change the appropriate callers, too.

Re: read-file-name argument clash with xemacs

[Kim F. Storm]

Richard Stallman <rms@gnu.org> writes:

>     So I suggest adding the history variable support to Emacs and moving the
>     predicate out to the 7th argument.
> 
> Ok.  The predicate arg feature was added since the last release so
> there is no problem in changing it now.  Would you like to do this?
> 
> Please change the appropriate callers, too.

Remember to change read-file-name-function and it uses (e.g. ido-read-file-name) too.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk