* Re: emacs-28 6b89578: ; * lisp/progmodes/flymake.el: Update the minimum Emacs version.
[not found] ` <20211209150233.DE3FB207E0@vcs0.savannah.gnu.org>
@ 2021-12-20 0:07 ` Dmitry Gutov
2021-12-20 15:17 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Gutov @ 2021-12-20 0:07 UTC (permalink / raw)
To: emacs-devel, Eli Zaretskii
Hi Eli,
On 09.12.2021 18:02, Eli Zaretskii wrote:
> -;; Package-Requires: ((emacs "26.1") (eldoc "1.1.0") (project "0.7.1"))
> +;; Package-Requires: ((emacs "28.1") (eldoc "1.1.0") (project "0.7.1"))
Could you explain that change?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: emacs-28 6b89578: ; * lisp/progmodes/flymake.el: Update the minimum Emacs version.
2021-12-20 0:07 ` emacs-28 6b89578: ; * lisp/progmodes/flymake.el: Update the minimum Emacs version Dmitry Gutov
@ 2021-12-20 15:17 ` Eli Zaretskii
2021-12-21 4:08 ` Dmitry Gutov
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2021-12-20 15:17 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: emacs-devel
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Mon, 20 Dec 2021 03:07:08 +0300
>
> Hi Eli,
>
> On 09.12.2021 18:02, Eli Zaretskii wrote:
> > -;; Package-Requires: ((emacs "26.1") (eldoc "1.1.0") (project "0.7.1"))
> > +;; Package-Requires: ((emacs "28.1") (eldoc "1.1.0") (project "0.7.1"))
>
> Could you explain that change?
See
https://lists.gnu.org/archive/html/help-gnu-emacs/2021-12/msg00166.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: emacs-28 6b89578: ; * lisp/progmodes/flymake.el: Update the minimum Emacs version.
2021-12-20 15:17 ` Eli Zaretskii
@ 2021-12-21 4:08 ` Dmitry Gutov
2021-12-21 5:57 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Gutov @ 2021-12-21 4:08 UTC (permalink / raw)
To: Eli Zaretskii, João Távora; +Cc: emacs-devel
On 20.12.2021 18:17, Eli Zaretskii wrote:
>> From: Dmitry Gutov<dgutov@yandex.ru>
>> Date: Mon, 20 Dec 2021 03:07:08 +0300
>>
>> Hi Eli,
>>
>> On 09.12.2021 18:02, Eli Zaretskii wrote:
>>> -;; Package-Requires: ((emacs "26.1") (eldoc "1.1.0") (project "0.7.1"))
>>> +;; Package-Requires: ((emacs "28.1") (eldoc "1.1.0") (project "0.7.1"))
>> Could you explain that change?
> See
>
> https://lists.gnu.org/archive/html/help-gnu-emacs/2021-12/msg00166.html
That doesn't seem like a good idea: other packages depend on it being
compatible with Emacs 26.
The change that broke that should be reverted instead.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: emacs-28 6b89578: ; * lisp/progmodes/flymake.el: Update the minimum Emacs version.
2021-12-21 4:08 ` Dmitry Gutov
@ 2021-12-21 5:57 ` Eli Zaretskii
2021-12-21 16:19 ` Dmitry Gutov
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2021-12-21 5:57 UTC (permalink / raw)
To: emacs-devel, Dmitry Gutov, João Távora
On December 21, 2021 6:08:25 AM GMT+02:00, Dmitry Gutov <dgutov@yandex.ru> wrote:
> On 20.12.2021 18:17, Eli Zaretskii wrote:
> >> From: Dmitry Gutov<dgutov@yandex.ru>
> >> Date: Mon, 20 Dec 2021 03:07:08 +0300
> >>
> >> Hi Eli,
> >>
> >> On 09.12.2021 18:02, Eli Zaretskii wrote:
> >>> -;; Package-Requires: ((emacs "26.1") (eldoc "1.1.0") (project "0.7.1"))
> >>> +;; Package-Requires: ((emacs "28.1") (eldoc "1.1.0") (project "0.7.1"))
> >> Could you explain that change?
> > See
> >
> > https://lists.gnu.org/archive/html/help-gnu-emacs/2021-12/msg00166.html
>
> That doesn't seem like a good idea: other packages depend on it being
> compatible with Emacs 26.
>
> The change that broke that should be reverted instead.
>
>
I'm okay with doing that provided that the patch to revert is simple and safe. Please show the patch.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: emacs-28 6b89578: ; * lisp/progmodes/flymake.el: Update the minimum Emacs version.
2021-12-21 5:57 ` Eli Zaretskii
@ 2021-12-21 16:19 ` Dmitry Gutov
2021-12-21 16:43 ` João Távora
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Gutov @ 2021-12-21 16:19 UTC (permalink / raw)
To: Eli Zaretskii, emacs-devel, João Távora
On 21.12.2021 08:57, Eli Zaretskii wrote:
> On December 21, 2021 6:08:25 AM GMT+02:00, Dmitry Gutov <dgutov@yandex.ru> wrote:
>> On 20.12.2021 18:17, Eli Zaretskii wrote:
>>>> From: Dmitry Gutov<dgutov@yandex.ru>
>>>> Date: Mon, 20 Dec 2021 03:07:08 +0300
>>>>
>>>> Hi Eli,
>>>>
>>>> On 09.12.2021 18:02, Eli Zaretskii wrote:
>>>>> -;; Package-Requires: ((emacs "26.1") (eldoc "1.1.0") (project "0.7.1"))
>>>>> +;; Package-Requires: ((emacs "28.1") (eldoc "1.1.0") (project "0.7.1"))
>>>> Could you explain that change?
>>> See
>>>
>>> https://lists.gnu.org/archive/html/help-gnu-emacs/2021-12/msg00166.html
>>
>> That doesn't seem like a good idea: other packages depend on it being
>> compatible with Emacs 26.
>>
>> The change that broke that should be reverted instead.
>>
>>
>
> I'm okay with doing that provided that the patch to revert is simple and safe. Please show the patch.
I think I will let Joao take point on that.
Note that the Package-Requires header in emacs-28 doesn't matter much.
The problem will arise when that change is merged to master and then
(sometime later) the Version header is also bumped in flymake.el.
From that POV your change in emacs-28 wasn't necessary either, but we
can ignore that branch and fix it better on master (do the revert of the
previous change).
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: emacs-28 6b89578: ; * lisp/progmodes/flymake.el: Update the minimum Emacs version.
2021-12-21 16:19 ` Dmitry Gutov
@ 2021-12-21 16:43 ` João Távora
0 siblings, 0 replies; 6+ messages in thread
From: João Távora @ 2021-12-21 16:43 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: Eli Zaretskii, emacs-devel
[-- Attachment #1: Type: text/plain, Size: 1557 bytes --]
On Tue, Dec 21, 2021 at 4:20 PM Dmitry Gutov <dgutov@yandex.ru> wrote:
> > I'm okay with doing that provided that the patch to revert is simple
and safe. Please show the patch.
> I think I will let Joao take point on that.
It would seem that the right thing to do is to keep 26.1 dep
and do what Guillaume Pasquet suggests:
"or substitute the `string-replace` call with `replace-regexp-in-string` to
maintain compatibility as I have done here:
https://github.com/Etenil/flymake/commit/9f5f76907b1c258645f65728dd71e7cacffe6d22
"
> Note that the Package-Requires header in emacs-28 doesn't matter much.
> The problem will arise when that change is merged to master and then
> (sometime later) the Version header is also bumped in flymake.el.
Yup, yes this is indeed a problem. That's why "core packages" have
this warning:
;; This is a GNU ELPA :core package. Avoid functionality that is not
;; compatible with the version of Emacs recorded above.
(the version recorded above being 26.1) So whoever added string-replace
violated that. It might have been me, didn't check, but I don't think so.
Unfortunately, I don't have great solution for avoiding these kinds
of problems in the future. An automatic test of `flymake.el` in Emacs
the recorded 26.1 could have picked this up. But we don't have them
and it's not super-easy to setup either.
I can only say that :core packages are a very good thing and
a way for users to get updates to fundamental packages
without waiting for the next major.
HTH,
João
[-- Attachment #2: Type: text/html, Size: 2087 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-12-21 16:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20211209150232.17813.54295@vcs0.savannah.gnu.org>
[not found] ` <20211209150233.DE3FB207E0@vcs0.savannah.gnu.org>
2021-12-20 0:07 ` emacs-28 6b89578: ; * lisp/progmodes/flymake.el: Update the minimum Emacs version Dmitry Gutov
2021-12-20 15:17 ` Eli Zaretskii
2021-12-21 4:08 ` Dmitry Gutov
2021-12-21 5:57 ` Eli Zaretskii
2021-12-21 16:19 ` Dmitry Gutov
2021-12-21 16:43 ` João Távora
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).