unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: About the 'minibuffer' frame parameter
Date: Tue, 09 Aug 2016 10:27:55 +0200	[thread overview]
Message-ID: <57A9940B.6030005@gmx.at> (raw)
In-Reply-To: <83popji89w.fsf@gnu.org>

 > So what is your suggestion for the course of actions?

(1) Make sure that store_frame_param doesn't store invalid parameter
     values.

(2) Never store a minibuffer window as frame parameter.

(3) Have ‘frame-parameter’ return the 'minibuffer' parameter as stored
     internally.  If no stored value is available, return t.

(4) Wait for regression reports.

(5) Fix the documentation.

(6) Fix/remove related comments.

Together (1) and (2) mean that the parameter becomes immutable as
occasionally already claimed.  (3) will require changes to frameset.el.
FWIW, the only code in frameset.el that seems to depend on the old
behavior is:

			    (let ((w (frame-parameter f 'minibuffer)))
			      (and (window-live-p w)
				   (window-minibuffer-p w)
				   (eq (window-frame w) f))))

This would be probably replaced by:

			    (let ((w (minibuffer-window f)))
			      (and (window-live-p w)
				   (eq (window-frame w) f))))

If anyone knows about code that does similar things in this or any other
package please tell us.

One open question is how to handle the minibuffer window in frame
configurations.  For example, the valid form

(let ((minibuffer-less-frame (make-frame '((minibuffer . nil))))
       (configuration (current-frame-configuration))
       (minibuffer-only-frame (make-frame '((minibuffer . only)))))
   (set-frame-parameter
    minibuffer-less-frame 'minibuffer (frame-root-window minibuffer-only-frame))
   (set-frame-configuration configuration))

currently throws an error while

(let ((initial-frame (selected-frame))
       (minibuffer-less-frame (make-frame '((minibuffer . nil))))
       (configuration (current-frame-configuration))
       (minibuffer-only-frame (make-frame '((minibuffer . only)))))
   (set-frame-parameter
    minibuffer-less-frame 'minibuffer (frame-root-window minibuffer-only-frame))
   (delete-frame initial-frame)
   (set-frame-configuration configuration))

in addition leaves me with a minibuffer-less frame I can't neither make
visible nor deiconify.

martin




  reply	other threads:[~2016-08-09  8:27 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-31 18:12 About the 'minibuffer' frame parameter martin rudalics
2016-08-05 13:33 ` Eli Zaretskii
2016-08-05 16:37   ` martin rudalics
2016-08-05 17:18     ` Drew Adams
2016-08-05 17:35       ` martin rudalics
2016-08-05 17:52         ` Drew Adams
2016-08-05 18:19           ` martin rudalics
2016-08-05 18:37             ` Drew Adams
2016-08-06  9:32               ` martin rudalics
2016-08-06 16:46                 ` Drew Adams
2016-08-07  8:46                   ` martin rudalics
2017-01-14  0:59                     ` Juanma Barranquero
2017-01-14  7:47                       ` Eli Zaretskii
2017-01-14  9:18                         ` Juanma Barranquero
2017-01-14 10:42                           ` Eli Zaretskii
2017-01-14 11:05                           ` martin rudalics
2017-01-14 14:01                             ` Juanma Barranquero
2017-01-19  3:54                               ` John Wiegley
2017-01-14 15:56                             ` Drew Adams
2017-01-15  3:01                           ` Richard Stallman
2016-08-05 19:25     ` Eli Zaretskii
2016-08-06  9:33       ` martin rudalics
2016-08-07 13:54         ` Eli Zaretskii
2016-08-08  8:27           ` martin rudalics
2016-08-08 15:34             ` Eli Zaretskii
2016-08-09  8:27               ` martin rudalics [this message]
2016-08-09 14:51                 ` Eli Zaretskii
2016-08-09 16:07                   ` martin rudalics
2016-08-09 16:21                     ` Eli Zaretskii
2016-08-09 17:34                       ` martin rudalics
2016-08-09 17:51                         ` Eli Zaretskii
2016-08-10 12:15                           ` martin rudalics
2016-08-10 14:23                             ` Stefan Monnier
2016-08-10 14:54                               ` Eli Zaretskii
2016-08-10 14:49                             ` Eli Zaretskii
2016-08-21  9:41                               ` martin rudalics
2016-08-21 20:51                                 ` Kaushal Modi
2016-08-22 12:49                                   ` Kaushal Modi
2016-08-22 13:03                                     ` Kaushal Modi
2016-08-22 15:51                                       ` Kaushal Modi
2016-08-22 16:01                                       ` martin rudalics
2016-08-22 16:27                                         ` Kaushal Modi
2016-08-23  8:19                                           ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57A9940B.6030005@gmx.at \
    --to=rudalics@gmx.at \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).