configure.in (START_FILES + LIB_STANDARD) and CRT_DIR sequence

configure.in (START_FILES + LIB_STANDARD) and CRT_DIR sequence

[Makoto Fujiwara]

After following commit, with some Operating system, say NetBSD,
build fails to find _fini symbols.
  -------------
  2011-06-29  Glenn Morris  <rgm@gnu.org>

         * configure.in: Try to test for the required crt*.o files.
  -------------

 It turned out the testing line 1011 of below never get true
because CRT_DIR is empty yet. (Missing parenthesis is not important :-)
---------
t-105@makoto 17:49:33/110924(..work/emacs)% cat -n configure.in | sed -n 1002,1019p
  1002    gnu-linux | gnu-kfreebsd )
  1003      LIB_STANDARD='-lgcc -lc -lgcc $(CRT_DIR)/crtn.o'
  1004      START_FILES='pre-crt0.o $(CRT_DIR)/crt1.o $(CRT_DIR)/crti.o'
  1005      ;;
  1006    hpux10-20 | hpux11 )
  1007      LIB_STANDARD=-lc
  1008      START_FILES='pre-crt0.o $(CRT_DIR)/crt0.o'
  1009      ;;
  1010    netbsd | openbsd )
  1011      if test -f $CRT_DIR/crti.o; then
  1012          LIB_STANDARD='-lgcc -lc -lgcc $(CRT_DIR)/crtend.o $(CRT_DIR)/crtn.o'
  1013          START_FILES='pre-crt0.o $(CRT_DIR)/crt0.o $(CRT_DIR)/crti.o $(CRT_DIR)/crtbegin.o'
  1014      else
  1015          LIB_STANDARD='-lgcc -lc -lgcc $(CRT_DIR)/crtend.o'
  1016          START_FILES='pre-crt0.o $(CRT_DIR)/crt0.o $(CRT_DIR)/crtbegin.o'
  1017      fi
  1018      ;;
  1019  esac
t-105@makoto 17:49:38/110924(..work/emacs)% 
---------

I think the order of 
START_FILES + LIB_STANDARD 
 and 
CRT_DIR handling of configure.in
should be swapped. Say CRT_DIR comes before
START_FILES processing.

Am I right ?

Thanks always,
---
Makoto Fujiwara, 
Chiba, Japan, Narita Airport and Disneyland prefecture.

Re: configure.in (START_FILES + LIB_STANDARD) and CRT_DIR sequence

[Makoto Fujiwara]

| From: Makoto Fujiwara <makoto@ki.nu>
| Subject: configure.in (START_FILES + LIB_STANDARD) and CRT_DIR sequence
| Date: Sat, 24 Sep 2011 17:57:41 +0900
| Message-ID: <yfm7h4ys4fu.wl%makoto@ki.nu>

> I think the order of 
> START_FILES + LIB_STANDARD 
>  and 
> CRT_DIR handling of configure.in
> should be swapped. Say CRT_DIR comes before
> START_FILES processing.

I now know these are mutually dependent, not easily swapped.

Thanks anyway,
---
Makoto Fujiwara, 
Chiba, Japan, Narita Airport and Disneyland prefecture.

Re: configure.in (START_FILES + LIB_STANDARD) and CRT_DIR sequence

[Makoto Fujiwara]

How about eliminating if condition ?
With NetBSD-5.1 is OK at least.


--- configure.in.orig	2011-09-24 18:33:08.000000000 +0900
+++ configure.in	2011-09-24 19:36:36.000000000 +0900
@@ -1026,13 +1026,8 @@
     START_FILES='pre-crt0.o $(CRT_DIR)/crt0.o'
     ;;
   netbsd | openbsd )
-    if test -f $CRT_DIR/crti.o; then
 	LIB_STANDARD='-lgcc -lc -lgcc $(CRT_DIR)/crtend.o $(CRT_DIR)/crtn.o'
-        START_FILES='pre-crt0.o $(CRT_DIR)/crt0.o $(CRT_DIR)/crti.o $(CRT_DIR)/crtbegin.o'
-    else
-	LIB_STANDARD='-lgcc -lc -lgcc $(CRT_DIR)/crtend.o'
-	START_FILES='pre-crt0.o $(CRT_DIR)/crt0.o $(CRT_DIR)/crtbegin.o'
-    fi
+	START_FILES='pre-crt0.o $(CRT_DIR)/crt0.o $(CRT_DIR)/crti.o $(CRT_DIR)/crtbegin.o'
     ;;
 esac

---
Makoto Fujiwara, 
Chiba, Japan, Narita Airport and Disneyland prefecture.

Re: configure.in (START_FILES + LIB_STANDARD) and CRT_DIR sequence

[Glenn Morris]

Hopefully it is fixed now. What did you mean about a missing parenthesis?
BTW, I recommend reporting this kind of thing to the bug list in future.