From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 0679159: Use the VC root in `log-edit-listfun'
Date: Sat, 11 Apr 2015 07:11:23 +0300 [thread overview]
Message-ID: <55289EEB.3020200@yandex.ru> (raw)
In-Reply-To: <jwv1tjsjxxa.fsf-monnier+emacsdiffs@gnu.org>
On 04/10/2015 09:33 AM, Stefan Monnier wrote:
> The remaining problem is that when marking ".", log-edit may find the
> right ./ChangeLog file but without knowing which files in "." will be
> committed, it can't know which entries to select.
Actually, it ends up working for "." because
`log-edit-changelog-entries' tries to fall back to "just look for FILE"
if it doesn't find exact matches, and then does (setq pattern
(file-name-nondirectory "./")), which is an empty string. No such luck
for any subdirectory.
I think I've fixed that now, but `log-edit-changelog-insert-entries'
replacement logic for relative paths won't in general work for these
directory entries. Also not a problem for Emacs master.
next prev parent reply other threads:[~2015-04-11 4:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150410010013.30467.14459@vcs.savannah.gnu.org>
[not found] ` <E1YgNIr-000805-SH@vcs.savannah.gnu.org>
2015-04-10 5:02 ` [Emacs-diffs] master 0679159: Use the VC root in `log-edit-listfun' Stefan Monnier
2015-04-10 6:33 ` Stefan Monnier
2015-04-11 4:11 ` Dmitry Gutov [this message]
2015-04-11 14:11 ` Stefan Monnier
2015-04-11 4:11 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55289EEB.3020200@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).