From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 0679159: Use the VC root in `log-edit-listfun' Date: Sat, 11 Apr 2015 07:11:23 +0300 Message-ID: <55289EEB.3020200@yandex.ru> References: <20150410010013.30467.14459@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1428725521 25036 80.91.229.3 (11 Apr 2015 04:12:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 11 Apr 2015 04:12:01 +0000 (UTC) To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 11 06:11:54 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ygmlu-0005zO-K3 for ged-emacs-devel@m.gmane.org; Sat, 11 Apr 2015 06:11:54 +0200 Original-Received: from localhost ([::1]:41764 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ygmlt-00072t-MQ for ged-emacs-devel@m.gmane.org; Sat, 11 Apr 2015 00:11:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgmlW-0006hV-8e for emacs-devel@gnu.org; Sat, 11 Apr 2015 00:11:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YgmlS-0004Mt-Oi for emacs-devel@gnu.org; Sat, 11 Apr 2015 00:11:30 -0400 Original-Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]:36160) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgmlS-0004MV-HF for emacs-devel@gnu.org; Sat, 11 Apr 2015 00:11:26 -0400 Original-Received: by wgsk9 with SMTP id k9so34089085wgs.3 for ; Fri, 10 Apr 2015 21:11:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=TWlvrvgOdVbuC9iWO/mE6eup139CUJG1yaKpHYcTAg8=; b=PxPvgWxtqv7LX6Ry8Qlrz+J+KFMJYt0zLVkYpRUxbiqMTaoQq7jxNSF2O11gfLtadF KPMT1UAhuLhTyzRYW649dAEO9MTOdPlgnoCa4CkRfzachAN2wcSBpe3CKAupJ4819D4s EwjiVrG3UUxzuPcGruEPy+T8xEV3sxqb+Zr6rinSTbYD4tTVtpRHBu/pCM7F0oWKUG5e +H0Twm456fxvYhRhEiLv4ywa5jDi5ksVwZWEUVk2PBchOrCprU9BXm9rRqmOhewAngt+ N7Qjgd+IdiziehpkVPYPp+QgYTfZbDLtHd29H0Pk6JEpMKKVfVnk+RZRdjckbMqZl2iM rZRQ== X-Received: by 10.194.8.99 with SMTP id q3mr8618965wja.88.1428725486001; Fri, 10 Apr 2015 21:11:26 -0700 (PDT) Original-Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id dr7sm2269295wib.22.2015.04.10.21.11.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Apr 2015 21:11:25 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:185276 Archived-At: On 04/10/2015 09:33 AM, Stefan Monnier wrote: > The remaining problem is that when marking ".", log-edit may find the > right ./ChangeLog file but without knowing which files in "." will be > committed, it can't know which entries to select. Actually, it ends up working for "." because `log-edit-changelog-entries' tries to fall back to "just look for FILE" if it doesn't find exact matches, and then does (setq pattern (file-name-nondirectory "./")), which is an empty string. No such luck for any subdirectory. I think I've fixed that now, but `log-edit-changelog-insert-entries' replacement logic for relative paths won't in general work for these directory entries. Also not a problem for Emacs master.