unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* "enum class" supports for cc-mode
@ 2014-10-27 18:36 Daniel Colascione
  2014-10-29 16:49 ` Alan Mackenzie
  0 siblings, 1 reply; 7+ messages in thread
From: Daniel Colascione @ 2014-10-27 18:36 UTC (permalink / raw)
  To: Emacs developers, Alan Mackenzie

[-- Attachment #1: Type: text/plain, Size: 7844 bytes --]

Here's a small patch that teaches cc-mode about C++11 "enum class" syntax.
See http://msdn.microsoft.com/en-us/library/2dzy4k6e.aspx

Alan, can you take a look?


=== modified file 'lisp/progmodes/cc-engine.el'
--- lisp/progmodes/cc-engine.el	2014-10-18 10:02:59 +0000
+++ lisp/progmodes/cc-engine.el	2014-10-27 18:00:51 +0000
@@ -8460,28 +8460,41 @@
 	   (cond
 	    ((c-syntactic-re-search-forward c-decl-block-key open-brace t t t)
 	     (goto-char (setq kwd-start (match-beginning 0)))
-	     (or
-
-	      ;; Found a keyword that can't be a type?
-	      (match-beginning 1)
-
-	      ;; Can be a type too, in which case it's the return type of a
-	      ;; function (under the assumption that no declaration level
-	      ;; block construct starts with a type).
-	      (not (c-forward-type))
-
-	      ;; Jumped over a type, but it could be a declaration keyword
-	      ;; followed by the declared identifier that we've jumped over
-	      ;; instead (e.g. in "class Foo {").  If it indeed is a type
-	      ;; then we should be at the declarator now, so check for a
-	      ;; valid declarator start.
-	      ;;
-	      ;; Note: This doesn't cope with the case when a declared
-	      ;; identifier is followed by e.g. '(' in a language where '('
-	      ;; also might be part of a declarator expression.  Currently
-	      ;; there's no such language.
-	      (not (or (looking-at c-symbol-start)
-		       (looking-at c-type-decl-prefix-key)))))
+             (and
+              ;; Exclude cases where we matched what would ordinarily
+              ;; be a block declaration keyword, except where it's not
+              ;; legal because it's part of a "compound keyword" like
+              ;; "enum class".  Of course, if c-after-brace-list-key
+              ;; is nil, we can skip the test.
+              (or (null c-after-brace-list-key)
+                  (save-match-data
+                    (save-excursion
+                      (not
+                       (and
+                        (looking-at c-after-brace-list-key)
+                        (= (c-backward-token-2 1 t) 0)
+                        (looking-at c-brace-list-key))))))
+              (or
+               ;; Found a keyword that can't be a type?
+               (match-beginning 1)
+
+               ;; Can be a type too, in which case it's the return type of a
+               ;; function (under the assumption that no declaration level
+               ;; block construct starts with a type).
+               (not (c-forward-type))
+
+               ;; Jumped over a type, but it could be a declaration keyword
+               ;; followed by the declared identifier that we've jumped over
+               ;; instead (e.g. in "class Foo {").  If it indeed is a type
+               ;; then we should be at the declarator now, so check for a
+               ;; valid declarator start.
+               ;;
+               ;; Note: This doesn't cope with the case when a declared
+               ;; identifier is followed by e.g. '(' in a language where '('
+               ;; also might be part of a declarator expression.  Currently
+               ;; there's no such language.
+               (not (or (looking-at c-symbol-start)
+                        (looking-at c-type-decl-prefix-key))))))
 
 	    ;; In Pike a list of modifiers may be followed by a brace
 	    ;; to make them apply to many identifiers.  Note that the
@@ -8586,9 +8599,35 @@
 		      (not (looking-at "=")))))
       b-pos)))
 
+(defun c-backward-colon-prefixed-type ()
+  ;; We're after what might be a type prefixed with a colon.  Try
+  ;; moving backward over this type and the colon.  On success, return
+  ;; t and leave point before colon, on falure, leave point unchanged.
+  ;; Will clobber match data.
+  (let ((colon-pos nil))
+    (save-excursion
+      (while
+          (and (eql (c-backward-token-2) 0)
+               (or (not (looking-at "\\s)"))
+                   (c-go-up-list-backward))
+               (cond
+                 ((eql (char-after) ?:)
+                  (setq colon-pos (point))
+                  nil)
+                 ((eql (char-after) ?\()
+                  t)
+                 ((looking-at c-symbol-key)
+                  t)
+                 (t nil)))))
+    (when colon-pos
+      (goto-char colon-pos)
+      t)))
+
 (defun c-backward-over-enum-header ()
   ;; We're at a "{".  Move back to the enum-like keyword that starts this
   ;; declaration and return t, otherwise don't move and return nil.
+  (when c-recognize-post-brace-list-type-p
+    (c-backward-colon-prefixed-type))
   (let ((here (point))
 	up-sexp-pos before-identifier)
     (while
@@ -8596,21 +8635,22 @@
 	 (eq (c-backward-token-2) 0)
 	 (or (not (looking-at "\\s)"))
 	     (c-go-up-list-backward))
-	 (cond
-	  ((and (looking-at c-symbol-key) (c-on-identifier)
-		(not before-identifier))
-	   (setq before-identifier t))
-	  ((and before-identifier
-		(or (eq (char-after) ?,)
-		    (looking-at c-postfix-decl-spec-key)))
-	   (setq before-identifier nil)
-	   t)
-	  ((looking-at c-brace-list-key) nil)
-	  ((and c-recognize-<>-arglists
-		(eq (char-after) ?<)
-		(looking-at "\\s("))
-	   t)
-	  (t nil))))
+         (cond
+           ((and (looking-at c-symbol-key) (c-on-identifier)
+                 (not before-identifier))
+            (setq before-identifier t))
+           ((and before-identifier
+                 (or (eql (char-after) ?,)
+                     (looking-at c-postfix-decl-spec-key)))
+            (setq before-identifier nil)
+            t)
+           ((looking-at c-after-brace-list-key) t)
+           ((looking-at c-brace-list-key) nil)
+           ((and c-recognize-<>-arglists
+                 (eq (char-after) ?<)
+                 (looking-at "\\s("))
+            t)
+           (t nil))))
     (or (looking-at c-brace-list-key)
 	(progn (goto-char here) nil))))
 

=== modified file 'lisp/progmodes/cc-langs.el'
--- lisp/progmodes/cc-langs.el	2014-10-12 20:09:15 +0000
+++ lisp/progmodes/cc-langs.el	2014-10-27 17:34:41 +0000
@@ -1805,8 +1805,31 @@
   ;; Regexp matching the start of declarations where the following
   ;; block is a brace list.
   t (c-make-keywords-re t (c-lang-const c-brace-list-decl-kwds)))
+
 (c-lang-defvar c-brace-list-key (c-lang-const c-brace-list-key))
 
+(c-lang-defconst c-after-brace-list-decl-kwds
+  "Keywords that might follow keywords in `c-brace-list-decl-kwds'
+and precede the opening brace."
+  t    nil
+  c++  '("class" "struct"))
+
+(c-lang-defconst c-after-brace-list-key
+  ;; Regexp matching keywords that can fall between a brace-list
+  ;; keyword and the associated brace list.
+  t (c-make-keywords-re t (c-lang-const c-after-brace-list-decl-kwds)))
+
+(c-lang-defvar c-after-brace-list-key (c-lang-const c-after-brace-list-key))
+
+(c-lang-defconst c-recognize-post-brace-list-type-p
+  ;; Recognize a colon and then a type after an enum, e.g.,
+  ;; enum foo : int { A, B, C };
+  t nil
+  c++ t)
+
+(c-lang-defvar c-recognize-post-brace-list-type-p
+               (c-lang-const c-recognize-post-brace-list-type-p))
+
 (c-lang-defconst c-other-block-decl-kwds
   "Keywords where the following block (if any) contains another
 declaration level that should not be considered a class.  For every
@@ -2000,6 +2023,7 @@
   ;; prefixes.
   t (delete-duplicates (append (c-lang-const c-class-decl-kwds)
 			       (c-lang-const c-brace-list-decl-kwds)
+                               (c-lang-const c-after-brace-list-decl-kwds)
 			       (c-lang-const c-other-block-decl-kwds)
 			       (c-lang-const c-typedef-decl-kwds)
 			       (c-lang-const c-typeless-decl-kwds)



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: "enum class" supports for cc-mode
  2014-10-27 18:36 "enum class" supports for cc-mode Daniel Colascione
@ 2014-10-29 16:49 ` Alan Mackenzie
  2014-10-29 17:02   ` Daniel Colascione
  0 siblings, 1 reply; 7+ messages in thread
From: Alan Mackenzie @ 2014-10-29 16:49 UTC (permalink / raw)
  To: Daniel Colascione; +Cc: Emacs developers

Hi, Daniel.

On Mon, Oct 27, 2014 at 06:36:09PM +0000, Daniel Colascione wrote:
> Here's a small patch that teaches cc-mode about C++11 "enum class" syntax.
> See http://msdn.microsoft.com/en-us/library/2dzy4k6e.aspx

> Alan, can you take a look?

Thanks for this, it looks good.  I'll definitely install it (with proper
attribution).

Just one or two little details:
(i) You've used `eql' rather than `eq' for comparing things in a few
  places.  Is there any reason for this?
(ii) c-after-brace-list-key will be "\\<\\>" (not nil) for non-C++
  languages, I think.  It's definition in cc-langs.el needs tweaking a
  bit to make it nil.
(iii) There's a question as to whether the backward searching in
  c-backward-colon-prefixed-type should have an optional search limit.
  But the existing c-backward-over-enum-header doesn't, so that's
  something new to think about.

Now, I'll go and try actually merging and running it.

> === modified file 'lisp/progmodes/cc-engine.el'
> --- lisp/progmodes/cc-engine.el	2014-10-18 10:02:59 +0000
> +++ lisp/progmodes/cc-engine.el	2014-10-27 18:00:51 +0000
> @@ -8460,28 +8460,41 @@
>  	   (cond
>  	    ((c-syntactic-re-search-forward c-decl-block-key open-brace t t t)
>  	     (goto-char (setq kwd-start (match-beginning 0)))
> -	     (or
> -
> -	      ;; Found a keyword that can't be a type?
> -	      (match-beginning 1)
> -
> -	      ;; Can be a type too, in which case it's the return type of a
> -	      ;; function (under the assumption that no declaration level
> -	      ;; block construct starts with a type).
> -	      (not (c-forward-type))
> -
> -	      ;; Jumped over a type, but it could be a declaration keyword
> -	      ;; followed by the declared identifier that we've jumped over
> -	      ;; instead (e.g. in "class Foo {").  If it indeed is a type
> -	      ;; then we should be at the declarator now, so check for a
> -	      ;; valid declarator start.
> -	      ;;
> -	      ;; Note: This doesn't cope with the case when a declared
> -	      ;; identifier is followed by e.g. '(' in a language where '('
> -	      ;; also might be part of a declarator expression.  Currently
> -	      ;; there's no such language.
> -	      (not (or (looking-at c-symbol-start)
> -		       (looking-at c-type-decl-prefix-key)))))
> +             (and
> +              ;; Exclude cases where we matched what would ordinarily
> +              ;; be a block declaration keyword, except where it's not
> +              ;; legal because it's part of a "compound keyword" like
> +              ;; "enum class".  Of course, if c-after-brace-list-key
> +              ;; is nil, we can skip the test.
> +              (or (null c-after-brace-list-key)
> +                  (save-match-data
> +                    (save-excursion
> +                      (not
> +                       (and
> +                        (looking-at c-after-brace-list-key)
> +                        (= (c-backward-token-2 1 t) 0)
> +                        (looking-at c-brace-list-key))))))
> +              (or
> +               ;; Found a keyword that can't be a type?
> +               (match-beginning 1)
> +
> +               ;; Can be a type too, in which case it's the return type of a
> +               ;; function (under the assumption that no declaration level
> +               ;; block construct starts with a type).
> +               (not (c-forward-type))
> +
> +               ;; Jumped over a type, but it could be a declaration keyword
> +               ;; followed by the declared identifier that we've jumped over
> +               ;; instead (e.g. in "class Foo {").  If it indeed is a type
> +               ;; then we should be at the declarator now, so check for a
> +               ;; valid declarator start.
> +               ;;
> +               ;; Note: This doesn't cope with the case when a declared
> +               ;; identifier is followed by e.g. '(' in a language where '('
> +               ;; also might be part of a declarator expression.  Currently
> +               ;; there's no such language.
> +               (not (or (looking-at c-symbol-start)
> +                        (looking-at c-type-decl-prefix-key))))))
>  
>  	    ;; In Pike a list of modifiers may be followed by a brace
>  	    ;; to make them apply to many identifiers.  Note that the
> @@ -8586,9 +8599,35 @@
>  		      (not (looking-at "=")))))
>        b-pos)))
>  
> +(defun c-backward-colon-prefixed-type ()
> +  ;; We're after what might be a type prefixed with a colon.  Try
> +  ;; moving backward over this type and the colon.  On success, return
> +  ;; t and leave point before colon, on falure, leave point unchanged.
> +  ;; Will clobber match data.
> +  (let ((colon-pos nil))
> +    (save-excursion
> +      (while
> +          (and (eql (c-backward-token-2) 0)
> +               (or (not (looking-at "\\s)"))
> +                   (c-go-up-list-backward))
> +               (cond
> +                 ((eql (char-after) ?:)
> +                  (setq colon-pos (point))
> +                  nil)
> +                 ((eql (char-after) ?\()
> +                  t)
> +                 ((looking-at c-symbol-key)
> +                  t)
> +                 (t nil)))))
> +    (when colon-pos
> +      (goto-char colon-pos)
> +      t)))
> +
>  (defun c-backward-over-enum-header ()
>    ;; We're at a "{".  Move back to the enum-like keyword that starts this
>    ;; declaration and return t, otherwise don't move and return nil.
> +  (when c-recognize-post-brace-list-type-p
> +    (c-backward-colon-prefixed-type))
>    (let ((here (point))
>  	up-sexp-pos before-identifier)
>      (while
> @@ -8596,21 +8635,22 @@
>  	 (eq (c-backward-token-2) 0)
>  	 (or (not (looking-at "\\s)"))
>  	     (c-go-up-list-backward))
> -	 (cond
> -	  ((and (looking-at c-symbol-key) (c-on-identifier)
> -		(not before-identifier))
> -	   (setq before-identifier t))
> -	  ((and before-identifier
> -		(or (eq (char-after) ?,)
> -		    (looking-at c-postfix-decl-spec-key)))
> -	   (setq before-identifier nil)
> -	   t)
> -	  ((looking-at c-brace-list-key) nil)
> -	  ((and c-recognize-<>-arglists
> -		(eq (char-after) ?<)
> -		(looking-at "\\s("))
> -	   t)
> -	  (t nil))))
> +         (cond
> +           ((and (looking-at c-symbol-key) (c-on-identifier)
> +                 (not before-identifier))
> +            (setq before-identifier t))
> +           ((and before-identifier
> +                 (or (eql (char-after) ?,)
> +                     (looking-at c-postfix-decl-spec-key)))
> +            (setq before-identifier nil)
> +            t)
> +           ((looking-at c-after-brace-list-key) t)
> +           ((looking-at c-brace-list-key) nil)
> +           ((and c-recognize-<>-arglists
> +                 (eq (char-after) ?<)
> +                 (looking-at "\\s("))
> +            t)
> +           (t nil))))
>      (or (looking-at c-brace-list-key)
>  	(progn (goto-char here) nil))))
>  
> 
> === modified file 'lisp/progmodes/cc-langs.el'
> --- lisp/progmodes/cc-langs.el	2014-10-12 20:09:15 +0000
> +++ lisp/progmodes/cc-langs.el	2014-10-27 17:34:41 +0000
> @@ -1805,8 +1805,31 @@
>    ;; Regexp matching the start of declarations where the following
>    ;; block is a brace list.
>    t (c-make-keywords-re t (c-lang-const c-brace-list-decl-kwds)))
> +
>  (c-lang-defvar c-brace-list-key (c-lang-const c-brace-list-key))
>  
> +(c-lang-defconst c-after-brace-list-decl-kwds
> +  "Keywords that might follow keywords in `c-brace-list-decl-kwds'
> +and precede the opening brace."
> +  t    nil
> +  c++  '("class" "struct"))
> +
> +(c-lang-defconst c-after-brace-list-key
> +  ;; Regexp matching keywords that can fall between a brace-list
> +  ;; keyword and the associated brace list.
> +  t (c-make-keywords-re t (c-lang-const c-after-brace-list-decl-kwds)))
> +
> +(c-lang-defvar c-after-brace-list-key (c-lang-const c-after-brace-list-key))
> +
> +(c-lang-defconst c-recognize-post-brace-list-type-p
> +  ;; Recognize a colon and then a type after an enum, e.g.,
> +  ;; enum foo : int { A, B, C };
> +  t nil
> +  c++ t)
> +
> +(c-lang-defvar c-recognize-post-brace-list-type-p
> +               (c-lang-const c-recognize-post-brace-list-type-p))
> +
>  (c-lang-defconst c-other-block-decl-kwds
>    "Keywords where the following block (if any) contains another
>  declaration level that should not be considered a class.  For every
> @@ -2000,6 +2023,7 @@
>    ;; prefixes.
>    t (delete-duplicates (append (c-lang-const c-class-decl-kwds)
>  			       (c-lang-const c-brace-list-decl-kwds)
> +                               (c-lang-const c-after-brace-list-decl-kwds)
>  			       (c-lang-const c-other-block-decl-kwds)
>  			       (c-lang-const c-typedef-decl-kwds)
>  			       (c-lang-const c-typeless-decl-kwds)


-- 
Alan Mackenzie (Nuremberg, Germany).



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: "enum class" supports for cc-mode
  2014-10-29 16:49 ` Alan Mackenzie
@ 2014-10-29 17:02   ` Daniel Colascione
  2014-10-30 16:21     ` Alan Mackenzie
  0 siblings, 1 reply; 7+ messages in thread
From: Daniel Colascione @ 2014-10-29 17:02 UTC (permalink / raw)
  To: Alan Mackenzie; +Cc: Emacs developers

[-- Attachment #1: Type: text/plain, Size: 1323 bytes --]

On 10/29/2014 04:49 PM, Alan Mackenzie wrote:
> Hi, Daniel.
> 
> On Mon, Oct 27, 2014 at 06:36:09PM +0000, Daniel Colascione wrote:
>> Here's a small patch that teaches cc-mode about C++11 "enum class" syntax.
>> See http://msdn.microsoft.com/en-us/library/2dzy4k6e.aspx
> 
>> Alan, can you take a look?
> 
> Thanks for this, it looks good.  I'll definitely install it (with proper
> attribution).

Thanks.

> Just one or two little details:
> (i) You've used `eql' rather than `eq' for comparing things in a few
>   places.  Is there any reason for this?

eql is a good habit for numbers; = and eq would work just as well in
these contexts though in Emacs.

> (ii) c-after-brace-list-key will be "\\<\\>" (not nil) for non-C++
>   languages, I think.  It's definition in cc-langs.el needs tweaking a
>   bit to make it nil.

Good point. Would you mind making this change?

> (iii) There's a question as to whether the backward searching in
>   c-backward-colon-prefixed-type should have an optional search limit.
>   But the existing c-backward-over-enum-header doesn't, so that's
>   something new to think about.

I figure that the search will stop soon enough when we come across a
token that can't be part of the enum header. Placing a generically
correct bound on it seemed hard.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: "enum class" supports for cc-mode
  2014-10-29 17:02   ` Daniel Colascione
@ 2014-10-30 16:21     ` Alan Mackenzie
  2014-10-30 18:56       ` Daniel Colascione
  2014-10-31 20:35       ` Glenn Morris
  0 siblings, 2 replies; 7+ messages in thread
From: Alan Mackenzie @ 2014-10-30 16:21 UTC (permalink / raw)
  To: Daniel Colascione; +Cc: Emacs developers

Hello, Daniel.

On Wed, Oct 29, 2014 at 05:02:28PM +0000, Daniel Colascione wrote:
> On 10/29/2014 04:49 PM, Alan Mackenzie wrote:

> > On Mon, Oct 27, 2014 at 06:36:09PM +0000, Daniel Colascione wrote:
> >> Here's a small patch that teaches cc-mode about C++11 "enum class" syntax.
> >> See http://msdn.microsoft.com/en-us/library/2dzy4k6e.aspx

I've installed the patch.

Just as a matter of interest, I had to toughen up
c-backward-colon-prefixed-type, since it had supriously captured

    class Foo {
    public:
        enum {

, mistaking the colon after "public" for a colon inside an enum
declaration.

Also, in general, please prefer tabs to spaces for indentation in CC
Mode.  In cc-langs.el, there's no need for a blank line between
(c-lang-defconst foo ..) and (c-lang-defvar foo ...).

> Thanks.

> > Just one or two little details:
> > (i) You've used `eql' rather than `eq' for comparing things in a few
> >   places.  Is there any reason for this?

> eql is a good habit for numbers; = and eq would work just as well in
> these contexts though in Emacs.

OK.  I've left eql in.

> > (ii) c-after-brace-list-key will be "\\<\\>" (not nil) for non-C++
> >   languages, I think.  It's definition in cc-langs.el needs tweaking a
> >   bit to make it nil.

> Good point. Would you mind making this change?

My mistake - the "\\<\\>" value was needed somewhere else.  I changed the
test against nil to an `equal' test against "\\<\\>".  It seems to work.

> > (iii) There's a question as to whether the backward searching in
> >   c-backward-colon-prefixed-type should have an optional search limit.
> >   But the existing c-backward-over-enum-header doesn't, so that's
> >   something new to think about.

> I figure that the search will stop soon enough when we come across a
> token that can't be part of the enum header. Placing a generically
> correct bound on it seemed hard.

It is, isn't it.  What will cost is if there's an unbalanced close
paren/brace/bracket.  That might cause a lot of scanning from BOB.  I'll
have another look at this, sometime.

-- 
Alan Mackenzie (Nuremberg, Germany).



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: "enum class" supports for cc-mode
  2014-10-30 16:21     ` Alan Mackenzie
@ 2014-10-30 18:56       ` Daniel Colascione
  2014-10-31 20:35       ` Glenn Morris
  1 sibling, 0 replies; 7+ messages in thread
From: Daniel Colascione @ 2014-10-30 18:56 UTC (permalink / raw)
  To: Alan Mackenzie; +Cc: Emacs developers

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

On 10/30/2014 04:21 PM, Alan Mackenzie wrote:
> Hello, Daniel.
> 
> On Wed, Oct 29, 2014 at 05:02:28PM +0000, Daniel Colascione wrote:
>> On 10/29/2014 04:49 PM, Alan Mackenzie wrote:
> 
>>> On Mon, Oct 27, 2014 at 06:36:09PM +0000, Daniel Colascione wrote:
>>>> Here's a small patch that teaches cc-mode about C++11 "enum class" syntax.
>>>> See http://msdn.microsoft.com/en-us/library/2dzy4k6e.aspx
> 
> I've installed the patch.

Thanks. Are you planning on merging into Emacs soon?


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: "enum class" supports for cc-mode
  2014-10-30 16:21     ` Alan Mackenzie
  2014-10-30 18:56       ` Daniel Colascione
@ 2014-10-31 20:35       ` Glenn Morris
  2014-11-01 10:39         ` Alan Mackenzie
  1 sibling, 1 reply; 7+ messages in thread
From: Glenn Morris @ 2014-10-31 20:35 UTC (permalink / raw)
  To: Alan Mackenzie; +Cc: Daniel Colascione, Emacs developers

Alan Mackenzie wrote:

>> > On Mon, Oct 27, 2014 at 06:36:09PM +0000, Daniel Colascione wrote:
>> >> Here's a small patch that teaches cc-mode about C++11 "enum class"
>> >> syntax
[...]
> I've installed the patch.

Please make ChangeLog entries in the name of the patch author, not the
committer. (Ideally, use commit --author as well, which vc-dir can do
automatically based on the ChangeLog.)



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: "enum class" supports for cc-mode
  2014-10-31 20:35       ` Glenn Morris
@ 2014-11-01 10:39         ` Alan Mackenzie
  0 siblings, 0 replies; 7+ messages in thread
From: Alan Mackenzie @ 2014-11-01 10:39 UTC (permalink / raw)
  To: Glenn Morris; +Cc: Daniel Colascione, Emacs developers

Hello, Glenn.

On Fri, Oct 31, 2014 at 04:35:50PM -0400, Glenn Morris wrote:
> Alan Mackenzie wrote:

> >> > On Mon, Oct 27, 2014 at 06:36:09PM +0000, Daniel Colascione wrote:
> >> >> Here's a small patch that teaches cc-mode about C++11 "enum class"
> >> >> syntax
> [...]
> > I've installed the patch.

> Please make ChangeLog entries in the name of the patch author, not the
> committer. (Ideally, use commit --author as well, which vc-dir can do
> automatically based on the ChangeLog.)

Sorry.  I forgot.  I've just corrected the ChangeLog.

-- 
Alan Mackenzie (Nuremberg, Germany).



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-11-01 10:39 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-27 18:36 "enum class" supports for cc-mode Daniel Colascione
2014-10-29 16:49 ` Alan Mackenzie
2014-10-29 17:02   ` Daniel Colascione
2014-10-30 16:21     ` Alan Mackenzie
2014-10-30 18:56       ` Daniel Colascione
2014-10-31 20:35       ` Glenn Morris
2014-11-01 10:39         ` Alan Mackenzie

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).