* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r108762: Replace eshell-defgroup with plain defgroup
[not found] <E1SjmV7-0004Bb-KL@vcs.savannah.gnu.org>
@ 2012-06-27 14:08 ` Stefan Monnier
2012-06-27 16:24 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2012-06-27 14:08 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
> Borrowing a trick from vc-sccs.el, wrap the defgroup in a progn
> so that the whole thing ends up in the generated autoload file,
> esh-groups.el.
Curious: why do we need that?
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r108762: Replace eshell-defgroup with plain defgroup
2012-06-27 14:08 ` [Emacs-diffs] /srv/bzr/emacs/trunk r108762: Replace eshell-defgroup with plain defgroup Stefan Monnier
@ 2012-06-27 16:24 ` Glenn Morris
2012-06-27 21:19 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2012-06-27 16:24 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier wrote:
>> Borrowing a trick from vc-sccs.el, wrap the defgroup in a progn
>> so that the whole thing ends up in the generated autoload file,
>> esh-groups.el.
>
> Curious: why do we need that?
Why does the whole thing need to be in esh-groups?
IIRC, because of the way esh-module.el uses that file.
Browsing the eshell-module group is supposed to show you all the other
related groups you can customize and their full descriptions,
without having to load the associated file.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r108762: Replace eshell-defgroup with plain defgroup
2012-06-27 16:24 ` Glenn Morris
@ 2012-06-27 21:19 ` Stefan Monnier
2012-06-28 0:42 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2012-06-27 21:19 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
>>> Borrowing a trick from vc-sccs.el, wrap the defgroup in a progn
>>> so that the whole thing ends up in the generated autoload file,
>>> esh-groups.el.
>> Curious: why do we need that?
> Why does the whole thing need to be in esh-groups?
No: why do we need to autoload this form?
What fails to happen if we don't?
I thought that custom groups get automatically autoloaded via cus-load.el.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r108762: Replace eshell-defgroup with plain defgroup
2012-06-27 21:19 ` Stefan Monnier
@ 2012-06-28 0:42 ` Glenn Morris
0 siblings, 0 replies; 4+ messages in thread
From: Glenn Morris @ 2012-06-28 0:42 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier wrote:
> No: why do we need to autoload this form?
> What fails to happen if we don't?
IIUC, it is so that you can do:
emacs -Q -l esh-module
M-x customize-variable RET eshell-modules-list RET
and see the full documentation of each piece, without having to load all
the associated files. So not terribly important, but not quite the same
as normal browsing of custom groups. (I think...)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-06-28 0:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1SjmV7-0004Bb-KL@vcs.savannah.gnu.org>
2012-06-27 14:08 ` [Emacs-diffs] /srv/bzr/emacs/trunk r108762: Replace eshell-defgroup with plain defgroup Stefan Monnier
2012-06-27 16:24 ` Glenn Morris
2012-06-27 21:19 ` Stefan Monnier
2012-06-28 0:42 ` Glenn Morris
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).