unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [Emacs-diffs] trunk r117013: Merge from emacs-24; up to r117008
       [not found] <E1WciJU-0001lo-9L@vcs.savannah.gnu.org>
@ 2014-04-22 21:35 ` Daniel Colascione
  2014-04-22 21:38   ` Paul Eggert
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel Colascione @ 2014-04-22 21:35 UTC (permalink / raw)
  To: Paul Eggert, emacs-devel

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

On 04/22/2014 02:33 PM, Paul Eggert wrote:
> ------------------------------------------------------------
> revno: 117013 [merge]
> revision-id: eggert@cs.ucla.edu-20140422213251-cat6fcono12drtef
> parent: monnier@iro.umontreal.ca-20140422174543-1k1x43ceqs1pkl7j
> parent: eggert@cs.ucla.edu-20140422201917-u7ln27kdjk0sxsl3
> committer: Paul Eggert <eggert@cs.ucla.edu>
> branch nick: trunk
> timestamp: Tue 2014-04-22 14:32:51 -0700
> message:
>   Merge from emacs-24; up to r117008

It looks like you re-introduced the cl-loop destructuring bug.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Emacs-diffs] trunk r117013: Merge from emacs-24; up to r117008
  2014-04-22 21:35 ` [Emacs-diffs] trunk r117013: Merge from emacs-24; up to r117008 Daniel Colascione
@ 2014-04-22 21:38   ` Paul Eggert
  2014-04-22 21:39     ` Daniel Colascione
  0 siblings, 1 reply; 4+ messages in thread
From: Paul Eggert @ 2014-04-22 21:38 UTC (permalink / raw)
  To: Daniel Colascione, emacs-devel

On 04/22/2014 02:35 PM, Daniel Colascione wrote:
> It looks like you re-introduced the cl-loop destructuring bug.

Ah, sorry, I'll take a look at that as soon as I can but won't be able 
to look at it for an hour or so.  Since it's something you're expert in 
(I'm not....) any advice would be appreciated.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Emacs-diffs] trunk r117013: Merge from emacs-24; up to r117008
  2014-04-22 21:38   ` Paul Eggert
@ 2014-04-22 21:39     ` Daniel Colascione
  2014-04-22 21:49       ` Daniel Colascione
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel Colascione @ 2014-04-22 21:39 UTC (permalink / raw)
  To: Paul Eggert, emacs-devel

[-- Attachment #1: Type: text/plain, Size: 532 bytes --]

On 04/22/2014 02:38 PM, Paul Eggert wrote:
> On 04/22/2014 02:35 PM, Daniel Colascione wrote:
>> It looks like you re-introduced the cl-loop destructuring bug.
> 
> Ah, sorry, I'll take a look at that as soon as I can but won't be able
> to look at it for an hour or so.  Since it's something you're expert in
> (I'm not....) any advice would be appreciated.

I'll fix it. I'm just not sure how that happened --- you should have
seen a merge conflict between the fix I put in trunk and Stefan's better
fix in emacs-24.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Emacs-diffs] trunk r117013: Merge from emacs-24; up to r117008
  2014-04-22 21:39     ` Daniel Colascione
@ 2014-04-22 21:49       ` Daniel Colascione
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel Colascione @ 2014-04-22 21:49 UTC (permalink / raw)
  To: Paul Eggert, emacs-devel

[-- Attachment #1: Type: text/plain, Size: 691 bytes --]

On 04/22/2014 02:39 PM, Daniel Colascione wrote:
> On 04/22/2014 02:38 PM, Paul Eggert wrote:
>> On 04/22/2014 02:35 PM, Daniel Colascione wrote:
>>> It looks like you re-introduced the cl-loop destructuring bug.
>>
>> Ah, sorry, I'll take a look at that as soon as I can but won't be able
>> to look at it for an hour or so.  Since it's something you're expert in
>> (I'm not....) any advice would be appreciated.
> 
> I'll fix it. I'm just not sure how that happened --- you should have
> seen a merge conflict between the fix I put in trunk and Stefan's better
> fix in emacs-24.

Never mind --- I misread the diff: trunk now contains the emacs-24 fix.
Sorry about that.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-04-22 21:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1WciJU-0001lo-9L@vcs.savannah.gnu.org>
2014-04-22 21:35 ` [Emacs-diffs] trunk r117013: Merge from emacs-24; up to r117008 Daniel Colascione
2014-04-22 21:38   ` Paul Eggert
2014-04-22 21:39     ` Daniel Colascione
2014-04-22 21:49       ` Daniel Colascione

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).