Resizing frames and windows pixelwise

Resizing frames and windows pixelwise

[martin rudalics]

[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]

I intend to install the attached patch in the next days.  Its main
purpose is to allow pixelwise resizing of frames and windows.  In order
to resize frames pixelwise use the option `frame-resize-pixelwise'.  In
order to resize windows pixelwise customize `window-resize-pixelwise'.

In addition, you can use dividers between windows which can be activated
by customizing the frame parameters `right-divider-width' and
`bottom-divider-width'.  The patch should also remove gaps between side
by side windows and the necessity of extending the fringe of the
rightmost window.  Finally, functions like `fit-window-to-buffer' and
`fit-frame-to-buffer' will use the size of displayed text to resize
windows and frames accurately.

I tested the changes on Windows XP and GNU/Linux Debian 7.0.  I did not
test them on OS X since I do not have access to such a machine.  Likely,
Emacs will crash or simply fail to compile on such systems.  I'd greatly
appreciate if someone could help me testing and fixing that.

Thanks for your attention, martin

[-- Attachment #2: pixelwise.diff.gz --]
[-- Type: application/gzip, Size: 87769 bytes --]

Re: Resizing frames and windows pixelwise

[Eli Zaretskii]

> Date: Thu, 28 Nov 2013 11:42:32 +0100
> From: martin rudalics <rudalics@gmx.at>
> 
> I intend to install the attached patch in the next days.  Its main
> purpose is to allow pixelwise resizing of frames and windows.  In order
> to resize frames pixelwise use the option `frame-resize-pixelwise'.  In
> order to resize windows pixelwise customize `window-resize-pixelwise'.
> 
> In addition, you can use dividers between windows which can be activated
> by customizing the frame parameters `right-divider-width' and
> `bottom-divider-width'.  The patch should also remove gaps between side
> by side windows and the necessity of extending the fringe of the
> rightmost window.  Finally, functions like `fit-window-to-buffer' and
> `fit-frame-to-buffer' will use the size of displayed text to resize
> windows and frames accurately.

Thanks for doing this, Martin.

Re: Resizing frames and windows pixelwise

[martin rudalics]

 > I intend to install the attached patch in the next days.

Installed in revision 115301 on trunk.  I'll add the NEWS entries later.

martin

Re: Resizing frames and windows pixelwise

[Romain Francoise]

martin rudalics <rudalics@gmx.at> writes:

> Installed in revision 115301 on trunk.

Hmm, it looks like setting `width' and `height' in `initial-frame-alist'
now resizes the initial frame in terms of pixels and not characters? Is
that expected? Because my usual 80x81 characters frame is now much, much
smaller than I need it to be...

Thanks.

Re: Resizing frames and windows pixelwise

[martin rudalics]

> Hmm, it looks like setting `width' and `height' in `initial-frame-alist'
> now resizes the initial frame in terms of pixels and not characters? Is
> that expected? Because my usual 80x81 characters frame is now much, much
> smaller than I need it to be...

Could you try the patch I proposed for bug#16013 ?

Thanks, martin

Re: Resizing frames and windows pixelwise

[Romain Francoise]

martin rudalics <rudalics@gmx.at> writes:

> Could you try the patch I proposed for bug#16013 ?

Yep, the patch works for me. Thanks!

Re: Resizing frames and windows pixelwise

[Alp Aker]

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

> I tested the changes on Windows XP and GNU/Linux Debian 7.0.  I did not
> test them on OS X since I do not have access to such a machine.  Likely,
> Emacs will crash or simply fail to compile on such systems.  I'd greatly
> appreciate if someone could help me testing and fixing that.

This breaks the OS X build, as reported in
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16018.

[-- Attachment #2: Type: text/html, Size: 636 bytes --]

Re: Resizing frames and windows pixelwise

[martin rudalics]

> Yep, the patch works for me. Thanks!

Are the sizes correct ?

martin

Re: Resizing frames and windows pixelwise

[martin rudalics]

> This breaks the OS X build, as reported in
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16018.

Unfortunately so.  Can you help fixing this ?

martin

Re: Resizing frames and windows pixelwise

[YAMAMOTO Mitsuharu]

>>>>> On Thu, 28 Nov 2013 11:42:32 +0100, martin rudalics <rudalics@gmx.at> said:

> The patch should also remove gaps between side by side windows and
> the necessity of extending the fringe of the rightmost window.

I removed code for fringe background extension on X11 at revno:
115343.  I could also make similar changes at least on W32, but I
think it would be better to do so after changing some (actually, most
of) members in `struct scroll_bar' from Lisp_Object to non-Lisp_Object
in order to leave at least one non-Lisp_Object member for the use of
ALLOCATE_PSEUDOVECTOR (currently, `fringe_extended_p' is the only
non-Lisp_Object member).  Does anyone having access to W32 systems
want to make such a change?  Also, I guess the `w32_widget_low/high'
members are unused.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Re: Resizing frames and windows pixelwise

[martin rudalics]

 >> The patch should also remove gaps between side by side windows and
 >> the necessity of extending the fringe of the rightmost window.
 >
 > I removed code for fringe background extension on X11 at revno:
 > 115343.

Thanks.  I hope your change is not premature, though ...

 > I could also make similar changes at least on W32, but I
 > think it would be better to do so after changing some (actually, most
 > of) members in `struct scroll_bar' from Lisp_Object to non-Lisp_Object
 > in order to leave at least one non-Lisp_Object member for the use of
 > ALLOCATE_PSEUDOVECTOR (currently, `fringe_extended_p' is the only
 > non-Lisp_Object member).  Does anyone having access to W32 systems
 > want to make such a change?  Also, I guess the `w32_widget_low/high'
 > members are unused.

I shall do that as soon as I sorted out the major bugs introduced by my
changes.  Do you have experienced additional problems?  Do you have any
ideas how to proceed with the OS X build?

Thanks, martin

Re: Resizing frames and windows pixelwise

[martin rudalics]

>> Could you try the patch I proposed for bug#16013 ?
> 
> Yep, the patch works for me. Thanks!

I sent a hopefully better one to that list.  Please try it.

Thanks, martin

Re: Resizing frames and windows pixelwise

[Romain Francoise]

martin rudalics <rudalics@gmx.at> writes:

> I sent a hopefully better one to that list.  Please try it.

As far as I can tell this new one seems to work just as well. Thanks.

Re: Resizing frames and windows pixelwise

[martin rudalics]

> As far as I can tell this new one seems to work just as well. Thanks.

Committed in revision 115361.

Thanks, martin

Re: Resizing frames and windows pixelwise

[martin rudalics]

 > I removed code for fringe background extension on X11 at revno:
 > 115343.  I could also make similar changes at least on W32, but I
 > think it would be better to do so after changing some (actually, most
 > of) members in `struct scroll_bar' from Lisp_Object to non-Lisp_Object
 > in order to leave at least one non-Lisp_Object member for the use of
 > ALLOCATE_PSEUDOVECTOR (currently, `fringe_extended_p' is the only
 > non-Lisp_Object member).  Does anyone having access to W32 systems
 > want to make such a change?

I've done that now.

 > Also, I guess the `w32_widget_low/high'
 > members are unused.

I think so too.  If nobody objects I'll remove them.

What about nsterm.m?

martin

Re: Resizing frames and windows pixelwise

[Jan Djärv]

Hello.

20 dec 2013 kl. 11:59 skrev martin rudalics <rudalics@gmx.at>:

> > I removed code for fringe background extension on X11 at revno:
> > 115343.  I could also make similar changes at least on W32, but I
> > think it would be better to do so after changing some (actually, most
> > of) members in `struct scroll_bar' from Lisp_Object to non-Lisp_Object
> > in order to leave at least one non-Lisp_Object member for the use of
> > ALLOCATE_PSEUDOVECTOR (currently, `fringe_extended_p' is the only
> > non-Lisp_Object member).  Does anyone having access to W32 systems
> > want to make such a change?
> 
> I've done that now.
> 
> > Also, I guess the `w32_widget_low/high'
> > members are unused.
> 
> I think so too.  If nobody objects I'll remove them.
> 
> What about nsterm.m?
> 
> martin

fringe_extended_p is just checked at one place, ns_set_vertical_scroll_bar.  It is trivial to remove.

	Jan D.