* Re: master 2644353: * .gitignore: add src/fingerprint.c
[not found] ` <20210115180320.0E5AF20B2C@vcs0.savannah.gnu.org>
@ 2021-01-15 21:38 ` Glenn Morris
2021-01-15 22:23 ` Stefan Monnier
0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2021-01-15 21:38 UTC (permalink / raw)
To: emacs-devel; +Cc: Stephen Leake
Stephen Leake wrote:
> branch: master
> commit 2644353cbc65927a6a0a76d68e00d017771cdd03
> * .gitignore: add src/fingerprint.c
Why? It's not generated since 2019-04-09.
Ref b697bb91a1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 2644353: * .gitignore: add src/fingerprint.c
2021-01-15 21:38 ` master 2644353: * .gitignore: add src/fingerprint.c Glenn Morris
@ 2021-01-15 22:23 ` Stefan Monnier
2021-01-16 23:55 ` Stephen Leake
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2021-01-15 22:23 UTC (permalink / raw)
To: Glenn Morris; +Cc: Stephen Leake, emacs-devel
>> branch: master
>> commit 2644353cbc65927a6a0a76d68e00d017771cdd03
>
>> * .gitignore: add src/fingerprint.c
>
> Why? It's not generated since 2019-04-09.
> Ref b697bb91a1
BTW, this is a recurring problem: every time we change our build
procedure such that an intermediate file isn't built any more,
someone ends up (re)adding it to `.gitignore`.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 2644353: * .gitignore: add src/fingerprint.c
2021-01-15 22:23 ` Stefan Monnier
@ 2021-01-16 23:55 ` Stephen Leake
2021-01-17 4:47 ` Stefan Monnier
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Leake @ 2021-01-16 23:55 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Glenn Morris, emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> branch: master
>>> commit 2644353cbc65927a6a0a76d68e00d017771cdd03
>>
>>> * .gitignore: add src/fingerprint.c
>>
>> Why? It's not generated since 2019-04-09.
>> Ref b697bb91a1
>
> BTW, this is a recurring problem: every time we change our build
> procedure such that an intermediate file isn't built any more,
> someone ends up (re)adding it to `.gitignore`.
Ah; I had fingerprint.c left over from some previous build, and did not
check that it is still generated.
I'll try to remember to check that in the future.
And to remember that other people keep .gitignore up to date, so a
previously generated file showing up means I should just delete it.
--
-- Stephe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 2644353: * .gitignore: add src/fingerprint.c
2021-01-16 23:55 ` Stephen Leake
@ 2021-01-17 4:47 ` Stefan Monnier
2021-01-17 13:43 ` Basil L. Contovounesios
2021-01-17 13:56 ` Robin Tarsiger
0 siblings, 2 replies; 6+ messages in thread
From: Stefan Monnier @ 2021-01-17 4:47 UTC (permalink / raw)
To: Stephen Leake; +Cc: Glenn Morris, emacs-devel
>> BTW, this is a recurring problem: every time we change our build
>> procedure such that an intermediate file isn't built any more,
>> someone ends up (re)adding it to `.gitignore`.
[...]
> I'll try to remember to check that in the future.
I don't think it'll help: I made the same mistake in the past as have
several others, then we learned, now you're learning as well but next
time around there'll be inevitably someone else who hasn't learned
it yet.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 2644353: * .gitignore: add src/fingerprint.c
2021-01-17 4:47 ` Stefan Monnier
@ 2021-01-17 13:43 ` Basil L. Contovounesios
2021-01-17 13:56 ` Robin Tarsiger
1 sibling, 0 replies; 6+ messages in thread
From: Basil L. Contovounesios @ 2021-01-17 13:43 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Glenn Morris, Stephen Leake, emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> BTW, this is a recurring problem: every time we change our build
>>> procedure such that an intermediate file isn't built any more,
>>> someone ends up (re)adding it to `.gitignore`.
> [...]
>> I'll try to remember to check that in the future.
>
> I don't think it'll help: I made the same mistake in the past as have
> several others, then we learned, now you're learning as well but next
> time around there'll be inevitably someone else who hasn't learned
> it yet.
Would a comment at the top of the file help, or is that too easily
missed?
--
Basil
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 2644353: * .gitignore: add src/fingerprint.c
2021-01-17 4:47 ` Stefan Monnier
2021-01-17 13:43 ` Basil L. Contovounesios
@ 2021-01-17 13:56 ` Robin Tarsiger
1 sibling, 0 replies; 6+ messages in thread
From: Robin Tarsiger @ 2021-01-17 13:56 UTC (permalink / raw)
To: Stefan Monnier, Stephen Leake; +Cc: emacs-devel
Stefan Monnier wrote:
> I don't think it'll help: I made the same mistake in the past as have
> several others, then we learned, now you're learning as well but next
> time around there'll be inevitably someone else who hasn't learned
> it yet.
I would suggest that when a file transitions from generated to
source, it gains a negated entry in a section at the end of .gitignore
which is commented to this effect. That way, someone editing the file
at the end will see the negation section and be reminded to
slow down and check it, and someone editing an earlier section will
find that the effect is canceled out and be encouraged to pause and
look around for why.
(These can be pruned after some time if the section becomes large,
of course.)
-RTT
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-17 13:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210115180318.2341.87079@vcs0.savannah.gnu.org>
[not found] ` <20210115180320.0E5AF20B2C@vcs0.savannah.gnu.org>
2021-01-15 21:38 ` master 2644353: * .gitignore: add src/fingerprint.c Glenn Morris
2021-01-15 22:23 ` Stefan Monnier
2021-01-16 23:55 ` Stephen Leake
2021-01-17 4:47 ` Stefan Monnier
2021-01-17 13:43 ` Basil L. Contovounesios
2021-01-17 13:56 ` Robin Tarsiger
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).