Re: [Emacs-diffs] trunk r113123: Use C99-style flexible array members if available.

Re: [Emacs-diffs] trunk r113123: Use C99-style flexible array members if available.

[Juanma Barranquero]

On Fri, Jun 21, 2013 at 10:11 PM, Paul Eggert <eggert@cs.ucla.edu> wrote:
> ------------------------------------------------------------
> revno: 113123
> revision-id: eggert@cs.ucla.edu-20130621201144-55tf8kmjdrhvsm25
> parent: rgm@gnu.org-20130621160000-kis3jmxv413jqtc0
> committer: Paul Eggert <eggert@cs.ucla.edu>
> branch nick: trunk
> timestamp: Fri 2013-06-21 13:11:44 -0700
> message:
>   Use C99-style flexible array members if available.


c:/Devel/emacs/repo/trunk/lib-src/ebrowse.c: In function 'add_sym':
c:/Devel/emacs/repo/trunk/lib-src/ebrowse.c:570:7: warning: implicit
declaration of function 'offsetof' [-Wimplicit-function-declaration]
c:/Devel/emacs/repo/trunk/lib-src/ebrowse.c:570:32: error: expected
expression before 'struct'
c:/Devel/emacs/repo/trunk/lib-src/ebrowse.c:571:33: error: expected
expression before 'struct'
c:/Devel/emacs/repo/trunk/lib-src/ebrowse.c: In function 'add_member':
c:/Devel/emacs/repo/trunk/lib-src/ebrowse.c:855:41: error: expected
expression before 'struct'
c:/Devel/emacs/repo/trunk/lib-src/ebrowse.c: In function 'make_namespace':
c:/Devel/emacs/repo/trunk/lib-src/ebrowse.c:966:38: error: expected
expression before 'struct'
c:/Devel/emacs/repo/trunk/lib-src/ebrowse.c:967:27: error: expected
expression before 'struct'
c:/Devel/emacs/repo/trunk/lib-src/ebrowse.c: In function
'register_namespace_alias':
c:/Devel/emacs/repo/trunk/lib-src/ebrowse.c:1050:27: error: expected
expression before 'struct'
Makefile:326: recipe for target `ebrowse.exe' failed
make[1]: *** [ebrowse.exe] Error 1
make[1]: Leaving directory `/c/Devel/emacs/repo/trunk/lib-src'
Makefile:367: recipe for target `lib-src' failed

Re: [Emacs-diffs] trunk r113123: Use C99-style flexible array members if available.

[Paul Eggert]

On 06/21/13 13:21, Juanma Barranquero wrote:
> c:/Devel/emacs/repo/trunk/lib-src/ebrowse.c:570:32: error: expected
> expression before 'struct'

Thanks, that problem didn't happen on Fedora, but I guess Fedora
drags in stddef.h for some other reason.  I hope I have fixed it
by installing the following as trunk bzr 113124:

=== modified file 'lib-src/ChangeLog'
--- lib-src/ChangeLog	2013-06-21 20:11:44 +0000
+++ lib-src/ChangeLog	2013-06-21 20:27:13 +0000
@@ -1,7 +1,8 @@
 2013-06-21  Paul Eggert  <eggert@cs.ucla.edu>
 
 	Use C99-style flexible array members if available.
-	* ebrowse.c (struct member, struct alias, struct sym):
+	* ebrowse.c: Include <stddef.h>, for offsetof.
+	(struct member, struct alias, struct sym):
 	Use FLEXIBLE_ARRAY_MEMBER.
 	(add_sym, add_member, make_namespace, register_namespace_alias):
 	Use offsetof (struct, flex_array_member), not sizeof (struct), as

=== modified file 'lib-src/ebrowse.c'
--- lib-src/ebrowse.c	2013-06-21 20:11:44 +0000
+++ lib-src/ebrowse.c	2013-06-21 20:27:13 +0000
@@ -19,6 +19,7 @@
 
 
 #include <config.h>
+#include <stddef.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>