Failure to compile this morning

Failure to compile this morning

[Susan Cragin]

Hmmm... 
After I was unable to compile this morning I deleted my git repository and downloaded a new one, and got this error. 
Any ideas?

/home/susan/emacs/lib-src/movemail.c:296:7: warning: implicit declaration of function ‘concat’ [-Wimplicit-function-declaration]
/home/susan/emacs/lib-src/movemail.c:296:16: warning: assignment makes pointer from integer without a cast [enabled by default]
/tmp/ccBpLmch.o: In function `main':
/home/susan/emacs/lib-src/movemail.c:296: undefined reference to `concat'
collect2: ld returned 1 exit status
make[1]: *** [movemail] Error 1
make[1]: Leaving directory `/home/susan/emacs/lib-src'
make: *** [lib-src] Error 2

Re: Failure to compile this morning

[Paul Eggert]

Sorry about that -- I introduced some code that didn't
port to Solaris and similar hosts.  Should be fixed in
trunk bzr 109035.

The problem that you had after git update looks like
a parallel-make dependency that's missing, i.e., it looks
like you executed config.status while it was being updated.
That shouldn't happen, but to fix this we'd need to know
more about the situation that made it happen.

Re: Failure to compile this morning

[Glenn Morris]

By the way, in case people don't know about this resource, this issue
was flagged by the automated builds

http://lists.gnu.org/archive/html/emacs-buildstatus/2012-07/msg00026.html
http://hydra.nixos.org/jobset/gnu/emacs-trunk

(So as INSTALL.BZR says, it's not generally necessary to report such
things. Shame there are so many spurious "dependency failed"s though...)

Re: Failure to compile this morning

[Sven Joachim]

On 2012-07-12 00:51 +0200, Paul Eggert wrote:

> Sorry about that -- I introduced some code that didn't
> port to Solaris and similar hosts.  Should be fixed in
> trunk bzr 109035.

It isn't:

.../lib-src/movemail.c:149:6: error: operator '||' has no left operand

Suggested fix:

--8<---------------cut here---------------start------------->8---
=== modified file 'lib-src/movemail.c'
--- lib-src/movemail.c	2012-07-11 22:44:07 +0000
+++ lib-src/movemail.c	2012-07-12 06:51:17 +0000
@@ -145,7 +145,7 @@ static int mbx_delimit_begin (FILE *mbf)
 static int mbx_delimit_end (FILE *mbf);
 #endif
 
-#if (MAIL_USE_MAILLOCK							\
+#if (defined MAIL_USE_MAILLOCK						\
      || (!defined DISABLE_DIRECT_ACCESS && !defined MAIL_USE_MMDF	\
 	 && !defined MAIL_USE_SYSTEM_LOCK))
 /* Like malloc but get fatal error if memory is exhausted.  */

--8<---------------cut here---------------end--------------->8---

Cheers,
       Sven

Re: Failure to compile this morning

[Paul Eggert]

On 07/12/2012 12:27 AM, Sven Joachim wrote:
> -#if (MAIL_USE_MAILLOCK							\
> +#if (defined MAIL_USE_MAILLOCK						\

Thanks, I pushed that as trunk bzr 109052.
(I had tested on GNU/Linux with
gcc -DMAIL_USE_MAILLOCK, but -Dfoo defines
foo to 1, not to the empty string....)