Re: bug#11672: 23.3; info menu-bar acts on wrong window

Re: bug#11672: 23.3; info menu-bar acts on wrong window

[martin rudalics]

 > Proposition for a bugfix:

Please keep emacs-devel cc'd.

 > Change the call to the interactive-function in Info-up, Info-next, and
 > Info-prev in the source file "info.el"
 >
 > from
 >     (interactive)
 > to
 >     (interactive "@")
 >
 > I think that's all. Or is that too simple? What do you think?
 >
 > I tested the bugfix by loading a file with the redefined functions
 > (load-file "bugfix.el") and it seems to work. For emacs in a text
 > console with gpm mouse support navigating by mouse in an inactive window
 > seems to be not possible.
 >
 > Maybe the save-window-excursion in the function source, that seems to be
 > provided for the case that another window is selected, is not really
 > necessary, because selecting the window with the menu-bar

To avoid confusion, this is "the window with the header line".

 > is most
 > probably intended by the user.

When he used the mouse.  In any case the

     (or (eq major-mode 'Info-mode) (switch-to-buffer "*info*"))

in `Info-up' and friends means that we do have to make current the
buffer of the window where the mouse click happened.  So I think using
(interactive "@") is TRT.  Any objections?

martin

Re: bug#11672: 23.3; info menu-bar acts on wrong window

[martin rudalics]

 > So I think using
 > (interactive "@") is TRT.  Any objections?

Apparently there are no objections.  Gerhard could you please provide a
patch and a ChangeLog entry?

Thanks, martin

Re: bug#11672: 23.3; info menu-bar acts on wrong window

[Dr. Gerhard Kahl]

Am 22.06.2012 12:21, schrieb martin rudalics:
> Gerhard could you please provide a
> patch and a ChangeLog entry?
>
> Thanks, martin


as a ChangeLog entry I would suggest:


	* info.el (Info-next, Info-prev, Info-up): Select the window
	with the header that was clicked, so that the node gets changed
	in the right window in case there is another info buffer
	in another window that is still active (Bug #11672).


and here is the patch:


--- emacs-24.1/lisp/info.el	2012-05-14 14:00:02.000000000 +0200
+++ modified/lisp/info.el	2012-06-22 17:09:04.672818093 +0200
@@ -2036,7 +2036,7 @@

  (defun Info-next ()
    "Go to the next node of this node."
-  (interactive)
+  (interactive "@")
    ;; In case another window is currently selected
    (save-window-excursion
      (or (eq major-mode 'Info-mode) (switch-to-buffer "*info*"))
@@ -2044,7 +2044,7 @@

  (defun Info-prev ()
    "Go to the previous node of this node."
-  (interactive)
+  (interactive "@")
    ;; In case another window is currently selected
    (save-window-excursion
      (or (eq major-mode 'Info-mode) (switch-to-buffer "*info*"))
@@ -2053,7 +2053,7 @@
  (defun Info-up (&optional same-file)
    "Go to the superior node of this node.
  If SAME-FILE is non-nil, do not move to a different Info file."
-  (interactive)
+  (interactive "@")
    ;; In case another window is currently selected
    (save-window-excursion
      (or (eq major-mode 'Info-mode) (switch-to-buffer "*info*"))


Gerhard

Re: bug#11672: 23.3; info menu-bar acts on wrong window

[Chong Yidong]

martin rudalics <rudalics@gmx.at> writes:

>> So I think using
>> (interactive "@") is TRT.  Any objections?
>
> Apparently there are no objections.  Gerhard could you please provide a
> patch and a ChangeLog entry?

I committed a few other changes to the code (it doesn't make sense to
use four almost-identical keymaps for those buttons), and included the @
interactive spec along the way.  Thanks for the bug report and the fix
suggestion, Gerhard.