unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* gdb-create-source-file-list and gdb-mi.el
@ 2011-11-18 10:29 Aneesh Kumar K.V
  0 siblings, 0 replies; 9+ messages in thread
From: Aneesh Kumar K.V @ 2011-11-18 10:29 UTC (permalink / raw)
  To: Emacs development discussions; +Cc: Chong Yidong, Stefan Monnier


gdb-mi.el does the below

  ;; find source file and compilation directory here
  (gdb-input
                                        ; Needs GDB 6.2 onwards.
   (list "-file-list-exec-source-files" 'gdb-get-source-file-list))
  (if gdb-create-source-file-list
      (gdb-input
                                        ; Needs GDB 6.0 onwards.
       (list "-file-list-exec-source-file" 'gdb-get-source-file)))

Don't we need to make sure the the "-file-list-exec-source-files"  also
come withing the gdb-crate-source-file-list check ?. Current gdb with
linux kernel vmlinux takes so much time to give me the prompt.

-aneesh




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re:gdb-create-source-file-list and gdb-mi.el
@ 2011-11-23  7:05 Nick Roberts
  2011-11-25 22:28 ` gdb-create-source-file-list " Ken Brown
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Nick Roberts @ 2011-11-23  7:05 UTC (permalink / raw)
  To: aneesh.kumar; +Cc: emacs-devel

> gdb-mi.el does the below
> 
>   ;; find source file and compilation directory here
>   (gdb-input
>                                         ; Needs GDB 6.2 onwards.
>    (list "-file-list-exec-source-files" 'gdb-get-source-file-list))
>   (if gdb-create-source-file-list
>       (gdb-input
>                                         ; Needs GDB 6.0 onwards.
>        (list "-file-list-exec-source-file" 'gdb-get-source-file)))

> Don't we need to make sure the the "-file-list-exec-source-files"  also
> come withing the gdb-crate-source-file-list check ?. Current gdb with
> linux kernel vmlinux takes so much time to give me the prompt.

Yes it looks like I made a mistake.  The if clause should be around the first gdb-input.

I don't know the status of the freeze so I've not committed this change. 

Nick




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: gdb-create-source-file-list and gdb-mi.el
  2011-11-23  7:05 Re:gdb-create-source-file-list and gdb-mi.el Nick Roberts
@ 2011-11-25 22:28 ` Ken Brown
  2011-11-26  7:00 ` Chong Yidong
  2011-11-29  7:52 ` Aneesh Kumar K.V
  2 siblings, 0 replies; 9+ messages in thread
From: Ken Brown @ 2011-11-25 22:28 UTC (permalink / raw)
  To: Nick Roberts; +Cc: aneesh.kumar, emacs-devel

On 11/23/2011 2:05 AM, Nick Roberts wrote:
>> gdb-mi.el does the below
>>
>>    ;; find source file and compilation directory here
>>    (gdb-input
>>                                          ; Needs GDB 6.2 onwards.
>>     (list "-file-list-exec-source-files" 'gdb-get-source-file-list))
>>    (if gdb-create-source-file-list
>>        (gdb-input
>>                                          ; Needs GDB 6.0 onwards.
>>         (list "-file-list-exec-source-file" 'gdb-get-source-file)))
>
>> Don't we need to make sure the the "-file-list-exec-source-files"  also
>> come withing the gdb-crate-source-file-list check ?. Current gdb with
>> linux kernel vmlinux takes so much time to give me the prompt.
>
> Yes it looks like I made a mistake.  The if clause should be around the first gdb-input.
>
> I don't know the status of the freeze so I've not committed this change.

As long as you're looking at gdb-mi.el problems, there have been several 
other bugs reported:

   http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9853
   http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9858
   http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9878
   http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9944

Could you take a look at those also?

Ken




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: gdb-create-source-file-list and gdb-mi.el
  2011-11-23  7:05 Re:gdb-create-source-file-list and gdb-mi.el Nick Roberts
  2011-11-25 22:28 ` gdb-create-source-file-list " Ken Brown
@ 2011-11-26  7:00 ` Chong Yidong
  2011-11-29  7:52 ` Aneesh Kumar K.V
  2 siblings, 0 replies; 9+ messages in thread
From: Chong Yidong @ 2011-11-26  7:00 UTC (permalink / raw)
  To: Nick Roberts; +Cc: aneesh.kumar, emacs-devel

Nick Roberts <nickrob@snap.net.nz> writes:

> Yes it looks like I made a mistake.  The if clause should be around
> the first gdb-input.
>
> I don't know the status of the freeze so I've not committed this
> change.

It's a bugfix, so please go ahead and commit the change.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re:gdb-create-source-file-list and gdb-mi.el
  2011-11-23  7:05 Re:gdb-create-source-file-list and gdb-mi.el Nick Roberts
  2011-11-25 22:28 ` gdb-create-source-file-list " Ken Brown
  2011-11-26  7:00 ` Chong Yidong
@ 2011-11-29  7:52 ` Aneesh Kumar K.V
  2011-11-29  8:45   ` Nick Roberts
  2 siblings, 1 reply; 9+ messages in thread
From: Aneesh Kumar K.V @ 2011-11-29  7:52 UTC (permalink / raw)
  To: Nick Roberts; +Cc: emacs-devel

On Wed, 23 Nov 2011 20:05:13 +1300, Nick Roberts <nickrob@snap.net.nz> wrote:
> > gdb-mi.el does the below
> > 
> >   ;; find source file and compilation directory here
> >   (gdb-input
> >                                         ; Needs GDB 6.2 onwards.
> >    (list "-file-list-exec-source-files" 'gdb-get-source-file-list))
> >   (if gdb-create-source-file-list
> >       (gdb-input
> >                                         ; Needs GDB 6.0 onwards.
> >        (list "-file-list-exec-source-file" 'gdb-get-source-file)))
> 
> > Don't we need to make sure the the "-file-list-exec-source-files"  also
> > come withing the gdb-crate-source-file-list check ?. Current gdb with
> > linux kernel vmlinux takes so much time to give me the prompt.
> 
> Yes it looks like I made a mistake.  The if clause should be around the first gdb-input.
> 
> I don't know the status of the freeze so I've not committed this change. 
> 

The change committed also require to move the mode line update out of
gdb-get-source-file-list to gdb-init-1. Otherwise mode line will say
"Intializing.." even after giving (gdb) prompt.

-aneesh




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re:gdb-create-source-file-list and gdb-mi.el
  2011-11-29  7:52 ` Aneesh Kumar K.V
@ 2011-11-29  8:45   ` Nick Roberts
  2011-11-29 15:29     ` gdb-create-source-file-list " Ken Brown
  0 siblings, 1 reply; 9+ messages in thread
From: Nick Roberts @ 2011-11-29  8:45 UTC (permalink / raw)
  To: Aneesh Kumar K.V; +Cc: emacs-devel

Aneesh Kumar K.V writes:
 > On Wed, 23 Nov 2011 20:05:13 +1300, Nick Roberts <nickrob@snap.net.nz> wrote:
 > > > gdb-mi.el does the below
 > > > 
 > > >   ;; find source file and compilation directory here
 > > >   (gdb-input
 > > >                                         ; Needs GDB 6.2 onwards.
 > > >    (list "-file-list-exec-source-files" 'gdb-get-source-file-list))
 > > >   (if gdb-create-source-file-list
 > > >       (gdb-input
 > > >                                         ; Needs GDB 6.0 onwards.
 > > >        (list "-file-list-exec-source-file" 'gdb-get-source-file)))
 > > 
 > > > Don't we need to make sure the the "-file-list-exec-source-files"  also
 > > > come withing the gdb-crate-source-file-list check ?. Current gdb with
 > > > linux kernel vmlinux takes so much time to give me the prompt.
 > > 
 > > Yes it looks like I made a mistake.  The if clause should be around the first gdb-input.
 > > 
 > > I don't know the status of the freeze so I've not committed this change. 
 > > 
 > 
 > The change committed also require to move the mode line update out of
 > gdb-get-source-file-list to gdb-init-1. Otherwise mode line will say
 > "Intializing.." even after giving (gdb) prompt.

I think that you're probably more familiar with some of this code than I am
now.  I've don't have much time for emacs development at the moment and I
don't want to become a bottleneck.  So I'm happy for you to commit these
changes if it's OK with Cyd and Stefan.  Ken Brown's patches look good too.
One, at least, is a regression from gdb-ui.el which probably still has fewer
issues than gdb-mi.el

Nick



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: gdb-create-source-file-list and gdb-mi.el
  2011-11-29  8:45   ` Nick Roberts
@ 2011-11-29 15:29     ` Ken Brown
  2011-11-29 18:46       ` Stefan Monnier
  0 siblings, 1 reply; 9+ messages in thread
From: Ken Brown @ 2011-11-29 15:29 UTC (permalink / raw)
  To: Chong Yidong, Stefan Monnier; +Cc: Nick Roberts, Aneesh Kumar K.V, emacs-devel

On 11/29/2011 3:45 AM, Nick Roberts wrote:
> I think that you're probably more familiar with some of this code than I am
> now.  I've don't have much time for emacs development at the moment and I
> don't want to become a bottleneck.  So I'm happy for you to commit these
> changes if it's OK with Cyd and Stefan.  Ken Brown's patches look good too.
> One, at least, is a regression from gdb-ui.el which probably still has fewer
> issues than gdb-mi.el

Chong and Stefan,

Should I apply my patches, or would you rather they wait for 24.2 at 
this point?  Here are the references again:

   http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9853
   http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9858
   http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9878

Ken




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: gdb-create-source-file-list and gdb-mi.el
  2011-11-29 15:29     ` gdb-create-source-file-list " Ken Brown
@ 2011-11-29 18:46       ` Stefan Monnier
  2011-11-30  3:32         ` Ken Brown
  0 siblings, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2011-11-29 18:46 UTC (permalink / raw)
  To: Ken Brown; +Cc: Chong Yidong, emacs-devel, Nick Roberts, Aneesh Kumar K.V

> Should I apply my patches, or would you rather they wait for 24.2 at this
> point?  Here are the references again:

Please install them.


        Stefan



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: gdb-create-source-file-list and gdb-mi.el
  2011-11-29 18:46       ` Stefan Monnier
@ 2011-11-30  3:32         ` Ken Brown
  0 siblings, 0 replies; 9+ messages in thread
From: Ken Brown @ 2011-11-30  3:32 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Chong Yidong, emacs-devel, Nick Roberts, Aneesh Kumar K.V

On 11/29/2011 1:46 PM, Stefan Monnier wrote:
>> Should I apply my patches, or would you rather they wait for 24.2 at this
>> point?  Here are the references again:
>
> Please install them.

Done; revno 106552.




^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2011-11-30  3:32 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-23  7:05 Re:gdb-create-source-file-list and gdb-mi.el Nick Roberts
2011-11-25 22:28 ` gdb-create-source-file-list " Ken Brown
2011-11-26  7:00 ` Chong Yidong
2011-11-29  7:52 ` Aneesh Kumar K.V
2011-11-29  8:45   ` Nick Roberts
2011-11-29 15:29     ` gdb-create-source-file-list " Ken Brown
2011-11-29 18:46       ` Stefan Monnier
2011-11-30  3:32         ` Ken Brown
  -- strict thread matches above, loose matches on Subject: below --
2011-11-18 10:29 Aneesh Kumar K.V

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).