Re: mac/make-package, suggested patch

Re: mac/make-package, suggested patch

[Steven Tamm]

Thanks for the patch; I was wondering why the installation numbers were inflated ;-).  This change more than cosmetic because those numbers are what the installer uses to determine if there is enough disk space to install.

I just checked this in.  And AFAIK, this is the correct forum for patches of this nature.

-Steven

On Friday, Dec 27, 2002, at 03:24PM, Martin Fredriksson <martin@crt.se> wrote:

>I suggest a small modification to mac/make-package, patch below.  The 
>patch solves a small, relatively unimportant (mostly cosmetic) problem. 
>  I believe it just corrects a typing mistake.
>
>(I've only read emacs-devel for about a week, please let me know if I 
>should have sent this someplace else.)
>
>/m
>
>Index: make-package
>===================================================================
>RCS file: /cvsroot/emacs/emacs/mac/make-package,v
>retrieving revision 1.11
>diff -u -r1.11 make-package
>--- make-package	10 Dec 2002 16:53:12 -0000	1.11
>+++ make-package	27 Dec 2002 21:50:46 -0000
>@@ -331,8 +331,8 @@
>  echo "Generating sizes file"
>  sizesfile=Emacs.pkg/Contents/Resources/Emacs.sizes
>
>-numFiles=`du -a ${tmpparent} | wc -l`
>-installedSize=`du -s ${tmpparent} | cut -f1`
>+numFiles=`du -a ${tempparent} | wc -l`
>+installedSize=`du -s ${tempparent} | cut -f1`
>  compressedSize=`du -s Emacs.pkg | cut -f1`
>
>  echo "NumFiles ${numFiles}" > ${sizesfile}
>
>
>
>_______________________________________________
>Emacs-devel mailing list
>Emacs-devel@gnu.org
>http://mail.gnu.org/mailman/listinfo/emacs-devel
>
>

mac/make-package: behavior change

[Steven Tamm]

I just changed the behavior of make-package to by default perform the 
build in a temporary directory instead of in the source.  For the old 
behavior, add the option "--build-in-place".    A couple people had 
asked for it and since I regularly build both the X and the Carbon 
versions, I didn't want the source tree to be littered with .o files.  
I also made changes to src/Makefile to correctly create the Emacs.app 
if the build is done in a separate directory.

Here are the new options:

       --build-in-place    Build the application in the source directory
                           instead of a temporary directory.
       --build-dir=DIR     Build the application in the specified 
directory
                           instead of a temporary directory.  Mutually 
exclusive
                           with --build-in-place.

-Steven