SIGTYPE/RETSIGTYPE

SIGTYPE/RETSIGTYPE

[Glenn Morris]

The autoconf manual says:

Obsolete Macros: AC_TYPE_SIGNAL

    If signal.h declares signal as returning a pointer to a function
    returning void, define RETSIGTYPE to be void; otherwise, define it
    to be int. These days, it is portable to assume C89, and that signal
    handlers return void, without needing to use this macro or RETSIGTYPE. 

So is it OK to remove this test from Emacs's configure.in, and replace
RETSIGTYPE (and SIGTYPE, which we define equal to RETSIGTYPE in
AH_BOTTOM) with just `void' everywhere in the sources?

Re: SIGTYPE/RETSIGTYPE

[Paul Eggert]

On 03/26/2011 12:34 PM, Glenn Morris wrote:
> So is it OK to remove this test from Emacs's configure.in, and replace
> RETSIGTYPE (and SIGTYPE, which we define equal to RETSIGTYPE in
> AH_BOTTOM) with just `void' everywhere in the sources?

Yes, absolutely.  Other GNU projects have done that
for years, with no problems.

Re: SIGTYPE/RETSIGTYPE

[Glenn Morris]

Thanks; removed.

Now the only things that `autoreconf -Wall' still gripes about are in
lib/ and m4/.  ;)

Re: SIGTYPE/RETSIGTYPE

[Paul Eggert]

On 03/26/2011 07:30 PM, Glenn Morris wrote:
> Now the only things that `autoreconf -Wall' still gripes about are in
> lib/ and m4/.  ;)

The gripes about AC_GNU_SOURCE are because gnulib is still
intended to be portable to Autoconf 2.59, which doesn't have
the replacements for AC_GNU_SOURCE.  These gripes should go
away once gnulib is modernized to assume a later Autoconf.

The other gripe, about DEFAULT_INCLUDES, is due to the way
Emacs historically has put config.h into src.  Most other
packages put it into lib, and if we did that we could
remove the DEFAULT_INCLUDES bit and fix the gripe.