unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [ps-print] Why imposing symbols for user functions?
@ 2005-03-07 14:16 drkm
  2005-03-19  2:13 ` Vinicius Jose Latorre
  0 siblings, 1 reply; 3+ messages in thread
From: drkm @ 2005-03-07 14:16 UTC (permalink / raw)


  Hi

  Why does PS Print impose user functions (in `ps-left-header' for
example) to be symbols?  `ps-generate-string-list' and
`ps-generate-header-line' use `symbolp' and `fboundp' instead of
`functionp'.  Why don't use the following, to allowing lambdas in PS
Print customs:

*** ps-print.el-orig	Thu Dec 23 07:02:00 2004
--- ps-print.el	Mon Mar  7 15:06:00 2005
***************
*** 4823,4829 ****
  		       ((stringp (car content))
  			(car content))
  		       ;; function symbol
! 		       ((and (symbolp (car content)) (fboundp (car content)))
  			(concat "(" (funcall (car content)) ")"))
  		       ;; variable symbol
  		       ((and (symbolp (car content)) (boundp (car content)))
--- 4823,4829 ----
  		       ((stringp (car content))
  			(car content))
  		       ;; function symbol
! 		       ((functionp (car content))
  			(concat "(" (funcall (car content)) ")"))
  		       ;; variable symbol
  		       ((and (symbolp (car content)) (boundp (car content)))
***************
*** 4863,4869 ****
  
     ;; Functions are called -- they should return strings; they will be inserted
     ;; as strings and the PS string delimiters added.
!    ((and (symbolp content) (fboundp content))
      (ps-output-string (ps-mule-encode-header-string (funcall content)
  						    fonttag)))
  
--- 4863,4869 ----
  
     ;; Functions are called -- they should return strings; they will be inserted
     ;; as strings and the PS string delimiters added.
!    ((functionp content)
      (ps-output-string (ps-mule-encode-header-string (funcall content)
  						    fonttag)))
  

--drkm

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [ps-print] Why imposing symbols for user functions?
@ 2005-03-09 10:48 drkm
  0 siblings, 0 replies; 3+ messages in thread
From: drkm @ 2005-03-09 10:48 UTC (permalink / raw)


Richard Stallman <rms@gnu.org> wrote:

> If it works, I guess the change is ok.
> Have you tried it and does it work?

  Yes, I use it for many months ago, with lambda functions in
`ps-left-header' and `ps-right-header'.

--drkm



	

	
		
Découvrez le nouveau Yahoo! Mail : 250 Mo d'espace de stockage pour vos mails ! 
Créez votre Yahoo! Mail sur http://fr.mail.yahoo.com/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [ps-print] Why imposing symbols for user functions?
  2005-03-07 14:16 [ps-print] Why imposing symbols for user functions? drkm
@ 2005-03-19  2:13 ` Vinicius Jose Latorre
  0 siblings, 0 replies; 3+ messages in thread
From: Vinicius Jose Latorre @ 2005-03-19  2:13 UTC (permalink / raw)
  Cc: emacs-devel

Hi drkm,


 >   Why does PS Print impose user functions (in `ps-left-header' for
 > example) to be symbols?  `ps-generate-string-list' and
 > `ps-generate-header-line' use `symbolp' and `fboundp' instead of
 > `functionp'.  Why don't use the following, to allowing lambdas in PS
 > Print customs:

Sorry for this very late answer.

The original ps-print creator (Jim Thompson) implemented this way.  Jacques
Duthen (the maintainer before me) and I didn't notice this problem.

Well, I'll install your patch.


Thanks for your patch,


Vinicius

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-03-19  2:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-03-07 14:16 [ps-print] Why imposing symbols for user functions? drkm
2005-03-19  2:13 ` Vinicius Jose Latorre
  -- strict thread matches above, loose matches on Subject: below --
2005-03-09 10:48 drkm

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).