unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Automatic updates for loaddefs-type files
@ 2011-04-06  2:42 Glenn Morris
  2011-04-06  4:17 ` Glenn Morris
  0 siblings, 1 reply; 7+ messages in thread
From: Glenn Morris @ 2011-04-06  2:42 UTC (permalink / raw)
  To: emacs-devel


I've added automatic updating of ldefs-boot.el and other versioned files
that contain generated autoload information (cl-loaddefs, etc). This is
using the same cron job on fencepost as the autotools stuff. So there's
no need to commit such changes any more (though it's fine if you want to
do so, eg as part of the change that necessitates the update).



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Automatic updates for loaddefs-type files
  2011-04-06  2:42 Automatic updates for loaddefs-type files Glenn Morris
@ 2011-04-06  4:17 ` Glenn Morris
  2011-04-06  9:13   ` Eli Zaretskii
       [not found]   ` <jwvbp0jv1xj.fsf-monnier+emacs@gnu.org>
  0 siblings, 2 replies; 7+ messages in thread
From: Glenn Morris @ 2011-04-06  4:17 UTC (permalink / raw)
  To: emacs-devel


Though maybe the ldefs-boot part should only be run once a week? Month?
Otherwise it's going to update every time a file with an autoload gets
changed, which is probably going to be annoying.



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Automatic updates for loaddefs-type files
  2011-04-06  4:17 ` Glenn Morris
@ 2011-04-06  9:13   ` Eli Zaretskii
  2011-04-06 17:17     ` Glenn Morris
       [not found]   ` <jwvbp0jv1xj.fsf-monnier+emacs@gnu.org>
  1 sibling, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2011-04-06  9:13 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel

> From: Glenn Morris <rgm@gnu.org>
> Date: Wed, 06 Apr 2011 00:17:34 -0400
> 
> 
> Though maybe the ldefs-boot part should only be run once a week? Month?
> Otherwise it's going to update every time a file with an autoload gets
> changed, which is probably going to be annoying.

Can't we have some move-if-changed based wizardry to commit only if it
changed?



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Automatic updates for loaddefs-type files
  2011-04-06  9:13   ` Eli Zaretskii
@ 2011-04-06 17:17     ` Glenn Morris
  2011-04-06 18:07       ` Eli Zaretskii
  0 siblings, 1 reply; 7+ messages in thread
From: Glenn Morris @ 2011-04-06 17:17 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii wrote:

> Can't we have some move-if-changed based wizardry to commit only if it
> changed?

There's no need for such a thing, since you cannot commit unmodified
files (although, it does have such a thing anyway).

It's just that the main loaddefs.el has timestamps for every file it
scans, so every change to such a file (even if it's just a comment and
does not affect autoloads) causes a change in the generated loaddefs
file.



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Automatic updates for loaddefs-type files
       [not found]   ` <jwvbp0jv1xj.fsf-monnier+emacs@gnu.org>
@ 2011-04-06 17:21     ` Glenn Morris
  0 siblings, 0 replies; 7+ messages in thread
From: Glenn Morris @ 2011-04-06 17:21 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier wrote:

>> Though maybe the ldefs-boot part should only be run once a week? Month?
>> Otherwise it's going to update every time a file with an autoload gets
>> changed, which is probably going to be annoying.
>
> I was just going to complain about that, yes ;-)
> I think it's OK to update it "manually" when the need appears.
> After all, and old version is only a problem if it breaks bootstrap.

Well, at the moment I made the ldefs-boot bit once a month only.
No harm in keeping it reasonably up-to-date? But it's easily disabled
if you like, or if this turns out to be annoying.



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Automatic updates for loaddefs-type files
  2011-04-06 17:17     ` Glenn Morris
@ 2011-04-06 18:07       ` Eli Zaretskii
  2011-04-06 18:23         ` Glenn Morris
  0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2011-04-06 18:07 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel

> From: Glenn Morris <rgm@gnu.org>
> Cc: emacs-devel@gnu.org
> Date: Wed, 06 Apr 2011 13:17:51 -0400
> 
> It's just that the main loaddefs.el has timestamps for every file it
> scans, so every change to such a file (even if it's just a comment and
> does not affect autoloads) causes a change in the generated loaddefs
> file.

Well, that's why I said "move-if-changed based wizardry": I meant to
make the "if-changed" part ignore the time stamps.  E.g., can Diff be
asked (using the -I switch) to ignore the lines with time stamps?



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Automatic updates for loaddefs-type files
  2011-04-06 18:07       ` Eli Zaretskii
@ 2011-04-06 18:23         ` Glenn Morris
  0 siblings, 0 replies; 7+ messages in thread
From: Glenn Morris @ 2011-04-06 18:23 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii wrote:

> Well, that's why I said "move-if-changed based wizardry": I meant to
> make the "if-changed" part ignore the time stamps.  E.g., can Diff be
> asked (using the -I switch) to ignore the lines with time stamps?

Oh, right. Actually looks like it would be really easy:

diff -qI '^;' loaddefs.el ldefs-boot.el > /dev/null || \
    cp loaddefs.el ldefs-boot.el



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2011-04-06 18:23 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-06  2:42 Automatic updates for loaddefs-type files Glenn Morris
2011-04-06  4:17 ` Glenn Morris
2011-04-06  9:13   ` Eli Zaretskii
2011-04-06 17:17     ` Glenn Morris
2011-04-06 18:07       ` Eli Zaretskii
2011-04-06 18:23         ` Glenn Morris
     [not found]   ` <jwvbp0jv1xj.fsf-monnier+emacs@gnu.org>
2011-04-06 17:21     ` Glenn Morris

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).