* recentf suggestion
@ 2003-05-02 1:01 Tak Ota
2003-05-02 8:53 ` David Ponce
0 siblings, 1 reply; 2+ messages in thread
From: Tak Ota @ 2003-05-02 1:01 UTC (permalink / raw)
I encountered a minor problem while using recentf. The function
recentf-cleanup checks the file's accessibility first then tests if
the file should be excluded. I exclude network files since they many
not be available later time but the current testing order ruins this
arrangement. It anyway goes out to the network and blocks emacs until
the connecting attempt to an unreachable host times out. How about
swapping the two tests?
-Tak
$ diff -c ../../../pub/emacs/pure/emacs-21.3.50/lisp/recentf.el recentf.el
*** ../../../pub/emacs/pure/emacs-21.3.50/lisp/recentf.el Sun Apr 27 07:22:17 2003
--- recentf.el Thu May 1 17:49:06 2003
***************
*** 1127,1133 ****
(message "Cleaning up the recentf list...")
(let (newlist)
(dolist (f recentf-list)
! (if (and (file-readable-p f) (recentf-include-p f))
(push f newlist)
(message "File %s removed from the recentf list" f)))
(setq recentf-list (nreverse newlist))
--- 1127,1133 ----
(message "Cleaning up the recentf list...")
(let (newlist)
(dolist (f recentf-list)
! (if (and (recentf-include-p f) (file-readable-p f))
(push f newlist)
(message "File %s removed from the recentf list" f)))
(setq recentf-list (nreverse newlist))
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: recentf suggestion
2003-05-02 1:01 recentf suggestion Tak Ota
@ 2003-05-02 8:53 ` David Ponce
0 siblings, 0 replies; 2+ messages in thread
From: David Ponce @ 2003-05-02 8:53 UTC (permalink / raw)
Cc: emacs-devel
Hi Tak,
> I encountered a minor problem while using recentf. The function
> recentf-cleanup checks the file's accessibility first then tests if
> the file should be excluded. I exclude network files since they many
> not be available later time but the current testing order ruins this
> arrangement. It anyway goes out to the network and blocks emacs until
> the connecting attempt to an unreachable host times out. How about
> swapping the two tests?
That's a good suggestion. Please could someone check this patch in?
Thanks!
David
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-05-02 8:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-02 1:01 recentf suggestion Tak Ota
2003-05-02 8:53 ` David Ponce
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).