Re: [elpa] externals/csharp-mode 7d7bf8895b 3/3: Merge pull request #264 from emacs-csharp/feature/non-eask-test

Re: [elpa] externals/csharp-mode 7d7bf8895b 3/3: Merge pull request #264 from emacs-csharp/feature/non-eask-test

[Stefan Monnier]

> +;; development only packages, not declared as a package-dependency
> +;; FIXME: loading a .el file from `load-path' should not change user's settings
> +;; like that.  It can happen without the user explicitly requesting it!
> +(package-initialize)
> +(add-to-list 'package-archives '("melpa" . "https://stable.melpa.org/packages/"))

Thanks for the FIXME :-)

BTW, the standard way to fix this problem is to wrap that code inside
a function (say `csharp-mode-tests-setup`) and then instead of:

> -	$(EASK) test ert csharp-mode-tests.el
> +	$(EMACS) -Q -batch -L . -l csharp-mode-tests.el -f ert-run-tests-batch-and-exit

you do something like:

	$(EMACS) -Q -batch -L . -l csharp-mode-tests.el \
	         -f csharp-mode-tests-setup             \
	         -f ert-run-tests-batch-and-exit

Tho of course, you can also move some of that code to the new function
so that instead you might end up with something like:

	$(EMACS) -Q -batch -l csharp-mode-tests.el -f csharp-mode-tests-run


-- Stefan

Re: [elpa] externals/csharp-mode 7d7bf8895b 3/3: Merge pull request #264 from emacs-csharp/feature/non-eask-test

[Jostein Kjønigsen]

On 17.08.2022 13:58, Stefan Monnier wrote:
>
> BTW, the standard way to fix this problem is to wrap that code inside
> a function (say `csharp-mode-tests-setup`) and then instead of:
>
>> -	$(EASK) test ert csharp-mode-tests.el
>> +	$(EMACS) -Q -batch -L . -l csharp-mode-tests.el -f ert-run-tests-batch-and-exit
> you do something like:
>
> 	$(EMACS) -Q -batch -L . -l csharp-mode-tests.el \
> 	         -f csharp-mode-tests-setup             \
> 	         -f ert-run-tests-batch-and-exit
>
Thanks. That's a good suggestion. Consider it done!

-- 
Jostein